From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Prabhakar Lad <prabhakar.csengg@gmail.com>
Cc: "Etheridge, Darren" <detheridge@ti.com>,
DLOS <davinci-linux-open-source@linux.davincidsp.com>,
LFBDEV <linux-fbdev@vger.kernel.org>,
Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] video:da8xx-fb: Convert to devm_* api
Date: Wed, 26 Jun 2013 12:00:36 +0000 [thread overview]
Message-ID: <51CAD7E4.2000403@ti.com> (raw)
In-Reply-To: <CA+V-a8uhK5-QJKifkiSUN6Nz0aBc2moraWQUJPCmZg9zaFX0eg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 882 bytes --]
On 26/06/13 14:56, Prabhakar Lad wrote:
> Hi Tomi,
>
> On Wed, Jun 26, 2013 at 5:09 PM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>> On 16/05/13 10:10, Lad Prabhakar wrote:
>>> From: Lad, Prabhakar <prabhakar.csengg@gmail.com>
>>>
>>> Use devm_ioremap_resource instead of reques_mem_region()/ioremap() and
>>> devm_request_irq() instead of request_irq().
>>>
>>> This ensures more consistent error values and simplifies error paths.
>>>
>>> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
>>> ---
>>> drivers/video/da8xx-fb.c | 39 +++++++--------------------------------
>>> 1 files changed, 7 insertions(+), 32 deletions(-)
>>
>> There's something similar in Darren's da8xx-fb series. Can you check if
>> there are differences?
>>
> I don't see similar changes in his patch series.
[PATCH 14/23] video: da8xx-fb: use devres
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Prabhakar Lad <prabhakar.csengg@gmail.com>
Cc: "Etheridge, Darren" <detheridge@ti.com>,
DLOS <davinci-linux-open-source@linux.davincidsp.com>,
LFBDEV <linux-fbdev@vger.kernel.org>,
Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] video:da8xx-fb: Convert to devm_* api
Date: Wed, 26 Jun 2013 15:00:36 +0300 [thread overview]
Message-ID: <51CAD7E4.2000403@ti.com> (raw)
In-Reply-To: <CA+V-a8uhK5-QJKifkiSUN6Nz0aBc2moraWQUJPCmZg9zaFX0eg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 882 bytes --]
On 26/06/13 14:56, Prabhakar Lad wrote:
> Hi Tomi,
>
> On Wed, Jun 26, 2013 at 5:09 PM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>> On 16/05/13 10:10, Lad Prabhakar wrote:
>>> From: Lad, Prabhakar <prabhakar.csengg@gmail.com>
>>>
>>> Use devm_ioremap_resource instead of reques_mem_region()/ioremap() and
>>> devm_request_irq() instead of request_irq().
>>>
>>> This ensures more consistent error values and simplifies error paths.
>>>
>>> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
>>> ---
>>> drivers/video/da8xx-fb.c | 39 +++++++--------------------------------
>>> 1 files changed, 7 insertions(+), 32 deletions(-)
>>
>> There's something similar in Darren's da8xx-fb series. Can you check if
>> there are differences?
>>
> I don't see similar changes in his patch series.
[PATCH 14/23] video: da8xx-fb: use devres
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
next prev parent reply other threads:[~2013-06-26 12:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 7:10 [PATCH 0/2] video: da8xx-fb trival cleanup Lad Prabhakar
2013-05-16 7:22 ` Lad Prabhakar
2013-05-16 7:10 ` [PATCH 1/2] video: da8xx-fb: remove unwanted header inclusion and sort the alphabetically Lad Prabhakar
2013-05-16 7:22 ` Lad Prabhakar
2013-05-16 7:10 ` [PATCH 2/2] video:da8xx-fb: Convert to devm_* api Lad Prabhakar
2013-05-16 7:22 ` Lad Prabhakar
2013-06-26 11:20 ` Prabhakar Lad
2013-06-26 11:32 ` Prabhakar Lad
2013-06-26 11:39 ` Tomi Valkeinen
2013-06-26 11:39 ` Tomi Valkeinen
2013-06-26 11:56 ` Prabhakar Lad
2013-06-26 11:57 ` Prabhakar Lad
2013-06-26 12:00 ` Tomi Valkeinen [this message]
2013-06-26 12:00 ` Tomi Valkeinen
2013-06-26 12:06 ` Prabhakar Lad
2013-06-26 12:18 ` Prabhakar Lad
2013-06-26 12:11 ` Tomi Valkeinen
2013-06-26 12:11 ` Tomi Valkeinen
2013-07-02 9:15 ` Prabhakar Lad
2013-07-02 9:27 ` Prabhakar Lad
2013-07-02 22:31 ` Etheridge, Darren
2013-07-02 22:31 ` Etheridge, Darren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CAD7E4.2000403@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=FlorianSchandinat@gmx.de \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=detheridge@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prabhakar.csengg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.