From: Stephen Warren <swarren@wwwdotorg.org>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
linux@maxim.org.za, nicolas.ferre@atmel.com,
plagnioj@jcrosoft.com, nsekhar@ti.com,
khilman@deeprootsystems.com, kernel@pengutronix.de,
shawn.guo@linaro.org, tony@atomide.com, ben-linux@fluff.org,
kgene.kim@samsung.com, horms@verge.net.au, magnus.damm@gmail.com,
srinidhi.kasagar@stericsson.com, linus.walleij@linaro.org,
daniel.lezcano@linaro.org, rjw@sisk.pl,
kyungmin.park@samsung.com
Subject: Re: [PATCH 7/8] ARM: tegra: move cpuidle drivers to drivers/cpuidle/
Date: Wed, 26 Jun 2013 12:24:09 -0600 [thread overview]
Message-ID: <51CB31C9.7050505@wwwdotorg.org> (raw)
In-Reply-To: <1372241747-21083-8-git-send-email-b.zolnierkie@samsung.com>
On 06/26/2013 04:15 AM, Bartlomiej Zolnierkiewicz wrote:
> Compile tested only.
That's not a good patch description; it's more something that should be
below the --- line.
This would be a lot easier to review if "-M" had been passed to "git
format-patch" so that the move was actually represented as a move in the
patch.
This patch would need to move at least part of
arch/arm/mach-tegra/cpuidle.h to some common location, since core code
that's left in arch/arm/mach-tegra ends up calling functions in the
moved files to initialize the cpuidle driver.
You should probably move arch/arm/mach-tegra/cpuidle.c too.
Does it make sense to introduce a new Kconfig option into
drivers/cpuidle/Kconfig, so that cpuidle-tegra*.c isn't compiled if
ARCH_TEGRA is enabled, but rather if something more like CPU_IDLE_TEGRA
is enabled?
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/8] ARM: tegra: move cpuidle drivers to drivers/cpuidle/
Date: Wed, 26 Jun 2013 12:24:09 -0600 [thread overview]
Message-ID: <51CB31C9.7050505@wwwdotorg.org> (raw)
In-Reply-To: <1372241747-21083-8-git-send-email-b.zolnierkie@samsung.com>
On 06/26/2013 04:15 AM, Bartlomiej Zolnierkiewicz wrote:
> Compile tested only.
That's not a good patch description; it's more something that should be
below the --- line.
This would be a lot easier to review if "-M" had been passed to "git
format-patch" so that the move was actually represented as a move in the
patch.
This patch would need to move at least part of
arch/arm/mach-tegra/cpuidle.h to some common location, since core code
that's left in arch/arm/mach-tegra ends up calling functions in the
moved files to initialize the cpuidle driver.
You should probably move arch/arm/mach-tegra/cpuidle.c too.
Does it make sense to introduce a new Kconfig option into
drivers/cpuidle/Kconfig, so that cpuidle-tegra*.c isn't compiled if
ARCH_TEGRA is enabled, but rather if something more like CPU_IDLE_TEGRA
is enabled?
next prev parent reply other threads:[~2013-06-26 18:24 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 10:15 [PATCH 0/8] ARM: move cpuidle drivers to drivers/cpuidle/ Bartlomiej Zolnierkiewicz
2013-06-26 10:15 ` Bartlomiej Zolnierkiewicz
2013-06-26 10:15 ` [PATCH 1/8] ARM: at91: move cpuidle driver " Bartlomiej Zolnierkiewicz
2013-06-26 10:15 ` Bartlomiej Zolnierkiewicz
2013-06-26 10:15 ` [PATCH 2/8] ARM: davinci: " Bartlomiej Zolnierkiewicz
2013-06-26 10:15 ` Bartlomiej Zolnierkiewicz
2013-06-26 10:15 ` [PATCH 3/8] ARM: imx: move cpuidle drivers " Bartlomiej Zolnierkiewicz
2013-06-26 10:15 ` Bartlomiej Zolnierkiewicz
2013-06-26 10:15 ` [PATCH 4/8] ARM: OMAP: " Bartlomiej Zolnierkiewicz
2013-06-26 10:15 ` Bartlomiej Zolnierkiewicz
2013-06-27 8:06 ` Tony Lindgren
2013-06-27 8:06 ` Tony Lindgren
2013-06-27 17:25 ` Kevin Hilman
2013-06-27 17:25 ` Kevin Hilman
2013-06-27 15:36 ` Santosh Shilimkar
2013-06-27 15:36 ` Santosh Shilimkar
2013-06-26 10:15 ` [PATCH 5/8] ARM: S3C64XX: move cpuidle driver " Bartlomiej Zolnierkiewicz
2013-06-26 10:15 ` Bartlomiej Zolnierkiewicz
2013-07-22 3:33 ` Kukjin Kim
2013-07-22 3:33 ` Kukjin Kim
2013-06-26 10:15 ` [PATCH 6/8] ARM: shmobile: " Bartlomiej Zolnierkiewicz
2013-06-26 10:15 ` Bartlomiej Zolnierkiewicz
2013-06-26 10:15 ` [PATCH 7/8] ARM: tegra: move cpuidle drivers " Bartlomiej Zolnierkiewicz
2013-06-26 10:15 ` Bartlomiej Zolnierkiewicz
2013-06-26 18:24 ` Stephen Warren [this message]
2013-06-26 18:24 ` Stephen Warren
2013-06-26 10:15 ` [PATCH 8/8] ARM: ux500: " Bartlomiej Zolnierkiewicz
2013-06-26 10:15 ` Bartlomiej Zolnierkiewicz
2013-06-26 20:42 ` Linus Walleij
2013-06-26 20:42 ` Linus Walleij
2013-06-26 21:28 ` Arnd Bergmann
2013-06-26 21:28 ` Arnd Bergmann
2013-06-26 10:59 ` [PATCH 0/8] ARM: " Daniel Lezcano
2013-06-26 10:59 ` Daniel Lezcano
2013-06-26 12:22 ` Bartlomiej Zolnierkiewicz
2013-06-26 12:22 ` Bartlomiej Zolnierkiewicz
2013-06-26 13:05 ` Daniel Lezcano
2013-06-26 13:05 ` Daniel Lezcano
2013-06-26 14:40 ` Bartlomiej Zolnierkiewicz
2013-06-26 14:40 ` Bartlomiej Zolnierkiewicz
2013-06-26 16:57 ` Daniel Lezcano
2013-06-26 16:57 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CB31C9.7050505@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=b.zolnierkie@samsung.com \
--cc=ben-linux@fluff.org \
--cc=daniel.lezcano@linaro.org \
--cc=horms@verge.net.au \
--cc=kernel@pengutronix.de \
--cc=kgene.kim@samsung.com \
--cc=khilman@deeprootsystems.com \
--cc=kyungmin.park@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@maxim.org.za \
--cc=magnus.damm@gmail.com \
--cc=nicolas.ferre@atmel.com \
--cc=nsekhar@ti.com \
--cc=plagnioj@jcrosoft.com \
--cc=rjw@sisk.pl \
--cc=shawn.guo@linaro.org \
--cc=srinidhi.kasagar@stericsson.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.