All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] e2fsprogs: fix tests/f_extent_oobounds
@ 2013-06-26 19:31 Eric Sandeen
  2013-06-26 23:09 ` [PATCH V2] " Eric Sandeen
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Sandeen @ 2013-06-26 19:31 UTC (permalink / raw)
  To: ext4 development

tests/f_extent_oobounds runs debugfs from the system, not
from the source tree, and if the system's debugfs doesn't
have the extent_open command it fails silently.

Use $DEBUGFS to get the right executable.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

diff --git a/tests/f_extent_oobounds/script b/tests/f_extent_oobounds/script
index 31ac6c9..b1f0e1a 100644
--- a/tests/f_extent_oobounds/script
+++ b/tests/f_extent_oobounds/script
@@ -5,7 +5,7 @@ TEST_DATA="$test_name.tmp"
 
 dd if=/dev/zero of=$TMPFILE bs=1k count=256 > /dev/null 2>&1
 mke2fs -Ft ext4 $TMPFILE > /dev/null 2>&1
-debugfs -w $TMPFILE << EOF  > /dev/null 2>&1
+$DEBUGFS -w $TMPFILE << EOF  > /dev/null 2>&1
 write /dev/null testfile
 extent_open testfile
   insert_node 0 15 100


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH V2] e2fsprogs: fix tests/f_extent_oobounds
  2013-06-26 19:31 [PATCH] e2fsprogs: fix tests/f_extent_oobounds Eric Sandeen
@ 2013-06-26 23:09 ` Eric Sandeen
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Sandeen @ 2013-06-26 23:09 UTC (permalink / raw)
  To: ext4 development

Use $DEBUGFS and $MKE2FS to get the in-tree executables
for this test.

(Build machines which run make check shouldn't need to have
e2fsprogs installed, and we should be testing just-built versions
of the tools anyway)

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

V2: need to fix mke2fs as well as debugfs

diff --git a/tests/f_extent_oobounds/script b/tests/f_extent_oobounds/script
index 31ac6c9..b00b031 100644
--- a/tests/f_extent_oobounds/script
+++ b/tests/f_extent_oobounds/script
@@ -4,8 +4,8 @@ SKIP_GUNZIP="true"
 TEST_DATA="$test_name.tmp"
 
 dd if=/dev/zero of=$TMPFILE bs=1k count=256 > /dev/null 2>&1
-mke2fs -Ft ext4 $TMPFILE > /dev/null 2>&1
-debugfs -w $TMPFILE << EOF  > /dev/null 2>&1
+$MKE2FS -Ft ext4 $TMPFILE > /dev/null 2>&1
+$DEBUGFS -w $TMPFILE << EOF  > /dev/null 2>&1
 write /dev/null testfile
 extent_open testfile
   insert_node 0 15 100



^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-06-26 23:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-26 19:31 [PATCH] e2fsprogs: fix tests/f_extent_oobounds Eric Sandeen
2013-06-26 23:09 ` [PATCH V2] " Eric Sandeen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.