From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Joseph Lo <josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Mike Turquette
<mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 08/11] clk: tegra114: add suspend/resume function for tegar_cpu_car_ops
Date: Wed, 26 Jun 2013 13:38:22 -0600 [thread overview]
Message-ID: <51CB432E.9080006@wwwdotorg.org> (raw)
In-Reply-To: <1372152475-18617-9-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 06/25/2013 03:27 AM, Joseph Lo wrote:
> Adding suspend/resume function for tegra_cpu_car_ops. We only save and
> restore the setting of the clock of CoreSight. Other clocks still need
> to be taken care by clock driver.
Mike, can I get an ack to take this through the Tegra tree with the rest
of this series, for 3.12. Thanks.
(Nit: There's a typo in the patch subject here too.)
> diff --git a/drivers/clk/tegra/clk-tegra114.c b/drivers/clk/tegra/clk-tegra114.c
> +#ifdef CONFIG_PM_SLEEP
> +static void tegra114_cpu_clock_suspend(void)
> +{
> + /* switch coresite to clk_m, save off original source */
> + tegra114_cpu_clk_sctx.clk_csite_src =
> + readl(clk_base + CLK_SOURCE_CSITE);
> + writel(3<<30, clk_base + CLK_SOURCE_CSITE);
Don't you need spaces around the << to satisfy checkpatch/coding style?
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/11] clk: tegra114: add suspend/resume function for tegar_cpu_car_ops
Date: Wed, 26 Jun 2013 13:38:22 -0600 [thread overview]
Message-ID: <51CB432E.9080006@wwwdotorg.org> (raw)
In-Reply-To: <1372152475-18617-9-git-send-email-josephl@nvidia.com>
On 06/25/2013 03:27 AM, Joseph Lo wrote:
> Adding suspend/resume function for tegra_cpu_car_ops. We only save and
> restore the setting of the clock of CoreSight. Other clocks still need
> to be taken care by clock driver.
Mike, can I get an ack to take this through the Tegra tree with the rest
of this series, for 3.12. Thanks.
(Nit: There's a typo in the patch subject here too.)
> diff --git a/drivers/clk/tegra/clk-tegra114.c b/drivers/clk/tegra/clk-tegra114.c
> +#ifdef CONFIG_PM_SLEEP
> +static void tegra114_cpu_clock_suspend(void)
> +{
> + /* switch coresite to clk_m, save off original source */
> + tegra114_cpu_clk_sctx.clk_csite_src =
> + readl(clk_base + CLK_SOURCE_CSITE);
> + writel(3<<30, clk_base + CLK_SOURCE_CSITE);
Don't you need spaces around the << to satisfy checkpatch/coding style?
next prev parent reply other threads:[~2013-06-26 19:38 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 9:27 [PATCH 00/11] ARM: tegra114: add support for system suspend Joseph Lo
2013-06-25 9:27 ` Joseph Lo
[not found] ` <1372152475-18617-1-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-06-25 9:27 ` [PATCH 01/11] ARM: tegra: do v7_invalidate_l1 only when CPU is Cortex-A9 in tegra_resume Joseph Lo
2013-06-25 9:27 ` Joseph Lo
2013-06-25 9:27 ` [PATCH 02/11] ARM: tegra: add a flag for tegra_disable_clean_inv_dcache to do LoUIS or ALL Joseph Lo
2013-06-25 9:27 ` Joseph Lo
2013-06-26 19:31 ` Stephen Warren
2013-06-26 19:31 ` Stephen Warren
[not found] ` <51CB4174.1050700-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-06-27 10:07 ` Joseph Lo
2013-06-27 10:07 ` Joseph Lo
2013-06-25 9:27 ` [PATCH 03/11] ARM: tegra114: set up the correct L2 data RAM latency for Cortex-A15 Joseph Lo
2013-06-25 9:27 ` Joseph Lo
2013-06-25 9:27 ` [PATCH 04/11] ARM: tegra114: add low level support code for cluster power down Joseph Lo
2013-06-25 9:27 ` Joseph Lo
2013-06-25 9:27 ` [PATCH 05/11] ARM: tegra114: shut off the CPU rail when the last CPU in suspend Joseph Lo
2013-06-25 9:27 ` Joseph Lo
[not found] ` <1372152475-18617-6-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-06-26 19:36 ` Stephen Warren
2013-06-26 19:36 ` Stephen Warren
[not found] ` <51CB42A0.4070103-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-06-27 10:10 ` Joseph Lo
2013-06-27 10:10 ` Joseph Lo
2013-06-25 9:27 ` [PATCH 06/11] ARM: tegra114: hook tegra_tear_down_cpu function Joseph Lo
2013-06-25 9:27 ` Joseph Lo
[not found] ` <1372152475-18617-7-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-06-27 10:13 ` Thierry Reding
2013-06-27 10:13 ` Thierry Reding
2013-06-27 10:22 ` Joseph Lo
2013-06-27 10:22 ` Joseph Lo
2013-06-27 17:48 ` Stephen Warren
2013-06-27 17:48 ` Stephen Warren
[not found] ` <51CC7B01.30503-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-06-28 18:34 ` Thierry Reding
2013-06-28 18:34 ` Thierry Reding
2013-06-25 9:27 ` [PATCH 07/11] ARM: tegra114: flowctrl: add support for cpu_suspend_enter/exit Joseph Lo
2013-06-25 9:27 ` Joseph Lo
2013-06-25 9:27 ` [PATCH 08/11] clk: tegra114: add suspend/resume function for tegar_cpu_car_ops Joseph Lo
2013-06-25 9:27 ` Joseph Lo
[not found] ` <1372152475-18617-9-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-06-26 19:38 ` Stephen Warren [this message]
2013-06-26 19:38 ` Stephen Warren
[not found] ` <51CB432E.9080006-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-06-27 10:12 ` Joseph Lo
2013-06-27 10:12 ` Joseph Lo
2013-07-30 21:21 ` Mike Turquette
2013-07-30 21:21 ` Mike Turquette
2013-07-31 2:27 ` Joseph Lo
2013-07-31 2:27 ` Joseph Lo
[not found] ` <1375237637.1231.1.camel-yx3yKKdKkHfc7b1ADBJPm0n48jw8i0AO@public.gmane.org>
2013-07-31 3:37 ` Mike Turquette
2013-07-31 3:37 ` Mike Turquette
2013-06-25 9:27 ` [PATCH 09/11] ARM: tegar: remove the limitation that Tegra114 can't support suspend Joseph Lo
2013-06-25 9:27 ` Joseph Lo
[not found] ` <1372152475-18617-10-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-06-26 10:48 ` Thierry Reding
2013-06-26 10:48 ` Thierry Reding
2013-06-26 11:20 ` Joseph Lo
2013-06-26 11:20 ` Joseph Lo
2013-06-26 17:46 ` Stephen Warren
2013-06-26 17:46 ` Stephen Warren
2013-06-26 19:40 ` Stephen Warren
2013-06-26 19:40 ` Stephen Warren
[not found] ` <51CB4398.8050900-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-06-27 10:01 ` Joseph Lo
2013-06-27 10:01 ` Joseph Lo
2013-06-25 9:27 ` [PATCH 10/11] ARM: dts: tegra114: dalmore: add GPIO power key support Joseph Lo
2013-06-25 9:27 ` Joseph Lo
2013-06-25 9:27 ` [PATCH 11/11] ARM: dts: tegra114: dalmore: add PM configurations for PMC Joseph Lo
2013-06-25 9:27 ` Joseph Lo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CB432E.9080006@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.