* [Buildroot] [PATCH 1/1] pv: bump to version 1.4.6
@ 2013-06-26 19:50 Jerzy Grzegorek
2013-06-26 20:01 ` Arnout Vandecappelle
0 siblings, 1 reply; 4+ messages in thread
From: Jerzy Grzegorek @ 2013-06-26 19:50 UTC (permalink / raw)
To: buildroot
Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net>
---
.../{pv-1.2.0-fixld.patch => pv-0001-fixld.patch} | 9 ++++-----
package/pv/pv.mk | 4 ++--
2 files changed, 6 insertions(+), 7 deletions(-)
rename package/pv/{pv-1.2.0-fixld.patch => pv-0001-fixld.patch} (66%)
diff --git a/package/pv/pv-1.2.0-fixld.patch b/package/pv/pv-0001-fixld.patch
similarity index 66%
rename from package/pv/pv-1.2.0-fixld.patch
rename to package/pv/pv-0001-fixld.patch
index 9df279d..2598a9b 100644
--- a/package/pv/pv-1.2.0-fixld.patch
+++ b/package/pv/pv-0001-fixld.patch
@@ -6,15 +6,14 @@ a cross-compiler toolchain.
The fix takes the CC variable and changes the 'gcc' extension to 'ld'.
Signed-off-by: Roeland Van Praet <roelvp@mind.be>
+Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net>
---
-diff -ruN a/autoconf/make/vars.mk b/autoconf/make/vars.mk
---- a/autoconf/make/vars.mk 2010-03-11 00:43:19.000000000 +0100
-+++ b/autoconf/make/vars.mk 2011-10-06 15:47:18.000000000 +0200
-@@ -30,7 +30,7 @@
+--- a/autoconf/make/vars.mk 2012-06-05 23:55:23.000000000 +0200
++++ b/autoconf/make/vars.mk 2013-06-26 17:47:16.000000000 +0200
+@@ -30,6 +30,7 @@ INSTOBJEXT = @INSTOBJEXT@
@SET_MAKE@
SHELL = /bin/sh
CC = @CC@
--LD = ld
+LD = $(CC:gcc=ld)
DO_GZIP = @DO_GZIP@
INSTALL = @INSTALL@
diff --git a/package/pv/pv.mk b/package/pv/pv.mk
index 1aa95f6..3717977 100644
--- a/package/pv/pv.mk
+++ b/package/pv/pv.mk
@@ -4,8 +4,8 @@
#
################################################################################
-PV_VERSION = 1.2.0
+PV_VERSION = 1.4.6
PV_SOURCE = pv-$(PV_VERSION).tar.bz2
-PV_SITE = http://pipeviewer.googlecode.com/files
+PV_SITE = http://www.ivarch.com/programs/sources
$(eval $(autotools-package))
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] pv: bump to version 1.4.6
2013-06-26 19:50 [Buildroot] [PATCH 1/1] pv: bump to version 1.4.6 Jerzy Grzegorek
@ 2013-06-26 20:01 ` Arnout Vandecappelle
2013-06-26 20:22 ` Jerzy Grzegorek
0 siblings, 1 reply; 4+ messages in thread
From: Arnout Vandecappelle @ 2013-06-26 20:01 UTC (permalink / raw)
To: buildroot
On 26/06/13 21:50, Jerzy Grzegorek wrote:
> Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net>
> ---
> .../{pv-1.2.0-fixld.patch => pv-0001-fixld.patch} | 9 ++++-----
> package/pv/pv.mk | 4 ++--
> 2 files changed, 6 insertions(+), 7 deletions(-)
> rename package/pv/{pv-1.2.0-fixld.patch => pv-0001-fixld.patch} (66%)
>
> diff --git a/package/pv/pv-1.2.0-fixld.patch b/package/pv/pv-0001-fixld.patch
> similarity index 66%
> rename from package/pv/pv-1.2.0-fixld.patch
> rename to package/pv/pv-0001-fixld.patch
> index 9df279d..2598a9b 100644
> --- a/package/pv/pv-1.2.0-fixld.patch
> +++ b/package/pv/pv-0001-fixld.patch
> @@ -6,15 +6,14 @@ a cross-compiler toolchain.
> The fix takes the CC variable and changes the 'gcc' extension to 'ld'.
>
> Signed-off-by: Roeland Van Praet <roelvp@mind.be>
> +Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net>
> ---
> -diff -ruN a/autoconf/make/vars.mk b/autoconf/make/vars.mk
> ---- a/autoconf/make/vars.mk 2010-03-11 00:43:19.000000000 +0100
> -+++ b/autoconf/make/vars.mk 2011-10-06 15:47:18.000000000 +0200
> -@@ -30,7 +30,7 @@
> +--- a/autoconf/make/vars.mk 2012-06-05 23:55:23.000000000 +0200
> ++++ b/autoconf/make/vars.mk 2013-06-26 17:47:16.000000000 +0200
> +@@ -30,6 +30,7 @@ INSTOBJEXT = @INSTOBJEXT@
> @SET_MAKE@
> SHELL = /bin/sh
> CC = @CC@
> --LD = ld
If the new version's build system doesn't define the LD variable
anymore, then this patch is probably not needed anymore either.
Can you try to just remove the patch?
Regards,
Arnout
> +LD = $(CC:gcc=ld)
> DO_GZIP = @DO_GZIP@
> INSTALL = @INSTALL@
> diff --git a/package/pv/pv.mk b/package/pv/pv.mk
> index 1aa95f6..3717977 100644
> --- a/package/pv/pv.mk
> +++ b/package/pv/pv.mk
> @@ -4,8 +4,8 @@
> #
> ################################################################################
>
> -PV_VERSION = 1.2.0
> +PV_VERSION = 1.4.6
> PV_SOURCE = pv-$(PV_VERSION).tar.bz2
> -PV_SITE = http://pipeviewer.googlecode.com/files
> +PV_SITE = http://www.ivarch.com/programs/sources
>
> $(eval $(autotools-package))
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] pv: bump to version 1.4.6
2013-06-26 20:01 ` Arnout Vandecappelle
@ 2013-06-26 20:22 ` Jerzy Grzegorek
2013-06-27 9:25 ` Peter Korsgaard
0 siblings, 1 reply; 4+ messages in thread
From: Jerzy Grzegorek @ 2013-06-26 20:22 UTC (permalink / raw)
To: buildroot
Hi Arnout,
Thanks for your review.
> On 26/06/13 21:50, Jerzy Grzegorek wrote:
>> Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net>
>> ---
>> .../{pv-1.2.0-fixld.patch => pv-0001-fixld.patch} | 9 ++++-----
>> package/pv/pv.mk | 4 ++--
>> 2 files changed, 6 insertions(+), 7 deletions(-)
>> rename package/pv/{pv-1.2.0-fixld.patch => pv-0001-fixld.patch} (66%)
>>
>> diff --git a/package/pv/pv-1.2.0-fixld.patch
>> b/package/pv/pv-0001-fixld.patch
>> similarity index 66%
>> rename from package/pv/pv-1.2.0-fixld.patch
>> rename to package/pv/pv-0001-fixld.patch
>> index 9df279d..2598a9b 100644
>> --- a/package/pv/pv-1.2.0-fixld.patch
>> +++ b/package/pv/pv-0001-fixld.patch
>> @@ -6,15 +6,14 @@ a cross-compiler toolchain.
>> The fix takes the CC variable and changes the 'gcc' extension to 'ld'.
>>
>> Signed-off-by: Roeland Van Praet <roelvp@mind.be>
>> +Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net>
>> ---
>> -diff -ruN a/autoconf/make/vars.mk b/autoconf/make/vars.mk
>> ---- a/autoconf/make/vars.mk 2010-03-11 00:43:19.000000000 +0100
>> -+++ b/autoconf/make/vars.mk 2011-10-06 15:47:18.000000000 +0200
>> -@@ -30,7 +30,7 @@
>> +--- a/autoconf/make/vars.mk 2012-06-05 23:55:23.000000000 +0200
>> ++++ b/autoconf/make/vars.mk 2013-06-26 17:47:16.000000000 +0200
>> +@@ -30,6 +30,7 @@ INSTOBJEXT = @INSTOBJEXT@
>> @SET_MAKE@
>> SHELL = /bin/sh
>> CC = @CC@
>> --LD = ld
>
> If the new version's build system doesn't define the LD variable
> anymore, then this patch is probably not needed anymore either.
>
> Can you try to just remove the patch?
Without this patch build doesn't work.
Regards,
Jerzy
>
> Regards,
> Arnout
>
>
>> +LD = $(CC:gcc=ld)
>> DO_GZIP = @DO_GZIP@
>> INSTALL = @INSTALL@
>> diff --git a/package/pv/pv.mk b/package/pv/pv.mk
>> index 1aa95f6..3717977 100644
>> --- a/package/pv/pv.mk
>> +++ b/package/pv/pv.mk
>> @@ -4,8 +4,8 @@
>> #
>> ################################################################################
>>
>> -PV_VERSION = 1.2.0
>> +PV_VERSION = 1.4.6
>> PV_SOURCE = pv-$(PV_VERSION).tar.bz2
>> -PV_SITE = http://pipeviewer.googlecode.com/files
>> +PV_SITE = http://www.ivarch.com/programs/sources
>>
>> $(eval $(autotools-package))
>>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] pv: bump to version 1.4.6
2013-06-26 20:22 ` Jerzy Grzegorek
@ 2013-06-27 9:25 ` Peter Korsgaard
0 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2013-06-27 9:25 UTC (permalink / raw)
To: buildroot
>>>>> "Jerzy" == Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net> writes:
Hi,
>> If the new version's build system doesn't define the LD variable
>> anymore, then this patch is probably not needed anymore either.
>>
>> Can you try to just remove the patch?
Jerzy> Without this patch build doesn't work.
Ok, but atleast the patch description should change. Rather than doing
that, I simply dropped the patch and instead changed it to pass
LD=$(TARGET_LD) on the make cmdline.
Committed with that fixed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-06-27 9:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-26 19:50 [Buildroot] [PATCH 1/1] pv: bump to version 1.4.6 Jerzy Grzegorek
2013-06-26 20:01 ` Arnout Vandecappelle
2013-06-26 20:22 ` Jerzy Grzegorek
2013-06-27 9:25 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.