From: Stephen Warren <swarren@wwwdotorg.org>
To: David Herrmann <dh.herrmann@gmail.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Dave Airlie <airlied@gmail.com>,
linux-fbdev@vger.kernel.org, Stephen Warren <swarren@nvidia.com>,
Olof Johansson <olof@lixom.net>
Subject: Re: [RFC 4/6] drm: simpledrm: add fbdev fallback support
Date: Wed, 26 Jun 2013 20:59:28 +0000 [thread overview]
Message-ID: <51CB5630.6060000@wwwdotorg.org> (raw)
In-Reply-To: <1372112849-670-5-git-send-email-dh.herrmann@gmail.com>
On 06/24/2013 04:27 PM, David Herrmann wrote:
> Create a simple fbdev device during SimpleDRM setup so legacy user-space
> and fbcon can use it.
>
> fbdev deletion is quite buggy. A unregister_framebuffer() call followed by
> a printk() causes NULL-derefs in hide_cursor() and other places in the VT
> layer. Hence, we leak the fbdev device currently to make the VT layer
> happy. This needs to be fixed soon! Otherwise, we need a "depends !VT"
> line for SimpleDRM.
> diff --git a/drivers/gpu/drm/simpledrm/Makefile b/drivers/gpu/drm/simpledrm/Makefile
> simpledrm-y := simpledrm_drv.o simpledrm_main.o simpledrm_mem.o
>
> +ifdef CONFIG_DRM_SIMPLEDRM_FBDEV
> + simpledrm-y += simpledrm_fbdev.o
> +endif
I think that's:
+ simpledrm-$(CONFIG_DRM_SIMPLEDRM_FBDEV) += simpledrm_fbdev.o
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: David Herrmann <dh.herrmann@gmail.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Dave Airlie <airlied@gmail.com>,
linux-fbdev@vger.kernel.org, Stephen Warren <swarren@nvidia.com>,
Olof Johansson <olof@lixom.net>
Subject: Re: [RFC 4/6] drm: simpledrm: add fbdev fallback support
Date: Wed, 26 Jun 2013 14:59:28 -0600 [thread overview]
Message-ID: <51CB5630.6060000@wwwdotorg.org> (raw)
In-Reply-To: <1372112849-670-5-git-send-email-dh.herrmann@gmail.com>
On 06/24/2013 04:27 PM, David Herrmann wrote:
> Create a simple fbdev device during SimpleDRM setup so legacy user-space
> and fbcon can use it.
>
> fbdev deletion is quite buggy. A unregister_framebuffer() call followed by
> a printk() causes NULL-derefs in hide_cursor() and other places in the VT
> layer. Hence, we leak the fbdev device currently to make the VT layer
> happy. This needs to be fixed soon! Otherwise, we need a "depends !VT"
> line for SimpleDRM.
> diff --git a/drivers/gpu/drm/simpledrm/Makefile b/drivers/gpu/drm/simpledrm/Makefile
> simpledrm-y := simpledrm_drv.o simpledrm_main.o simpledrm_mem.o
>
> +ifdef CONFIG_DRM_SIMPLEDRM_FBDEV
> + simpledrm-y += simpledrm_fbdev.o
> +endif
I think that's:
+ simpledrm-$(CONFIG_DRM_SIMPLEDRM_FBDEV) += simpledrm_fbdev.o
next prev parent reply other threads:[~2013-06-26 20:59 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-24 22:27 [RFC 0/6] SimpleDRM Driver (was: dvbe driver) David Herrmann
2013-06-24 22:27 ` David Herrmann
2013-06-24 22:27 ` [RFC 1/6] fbdev: simplefb: add init through platform_data David Herrmann
2013-06-24 22:27 ` David Herrmann
2013-06-26 20:39 ` Stephen Warren
2013-06-26 20:39 ` Stephen Warren
2013-06-28 10:03 ` David Herrmann
2013-06-28 10:03 ` David Herrmann
2013-06-24 22:27 ` [RFC 2/6] x86: provide platform-devices for boot-framebuffers David Herrmann
2013-06-24 22:27 ` David Herrmann
2013-06-26 20:49 ` Stephen Warren
2013-06-26 20:49 ` Stephen Warren
2013-06-28 10:11 ` David Herrmann
2013-06-28 10:11 ` David Herrmann
2013-07-01 15:48 ` Stephen Warren
2013-07-01 15:48 ` Stephen Warren
2013-06-24 22:27 ` [RFC 3/6] drm: add SimpleDRM driver David Herrmann
2013-06-24 22:27 ` David Herrmann
2013-06-25 1:05 ` Andy Lutomirski
2013-06-25 1:05 ` Andy Lutomirski
2013-06-28 9:59 ` David Herrmann
2013-06-28 9:59 ` David Herrmann
2013-06-26 20:58 ` Stephen Warren
2013-06-26 20:58 ` Stephen Warren
2013-06-28 10:01 ` David Herrmann
2013-06-28 10:01 ` David Herrmann
2013-06-24 22:27 ` [RFC 4/6] drm: simpledrm: add fbdev fallback support David Herrmann
2013-06-24 22:27 ` David Herrmann
2013-06-26 20:59 ` Stephen Warren [this message]
2013-06-26 20:59 ` Stephen Warren
2013-06-28 10:14 ` David Herrmann
2013-06-28 10:14 ` David Herrmann
2013-06-24 22:27 ` [RFC 5/6] drm: add helpers to kick out firmware drivers David Herrmann
2013-06-24 22:27 ` David Herrmann
2013-06-24 22:27 ` [RFC 6/6] drm: nouveau: kick out firmware drivers during probe David Herrmann
2013-06-24 22:27 ` David Herrmann
2013-06-26 21:30 ` [RFC 0/6] SimpleDRM Driver (was: dvbe driver) Stephen Warren
2013-06-26 21:30 ` Stephen Warren
2013-06-28 10:43 ` David Herrmann
2013-06-28 10:43 ` David Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CB5630.6060000@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=airlied@gmail.com \
--cc=dh.herrmann@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.