All of lore.kernel.org
 help / color / mirror / Atom feed
From: gang.chen@asianux.com (Chen Gang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arch: arm64: include: asm: add pci.h to pass compiling
Date: Thu, 27 Jun 2013 08:30:40 +0800	[thread overview]
Message-ID: <51CB87B0.8030805@asianux.com> (raw)
In-Reply-To: <20130626140730.GB23309@arm.com>

On 06/26/2013 10:07 PM, Catalin Marinas wrote:
> On Wed, Jun 26, 2013 at 04:26:41AM +0100, Chen Gang wrote:
>> > Need add pci.h for compiling, the related error (with allmodconfig):
>> > 
>> >   drivers/media/usb/b2c2/flexcop-usb.c: In function ?flexcop_usb_transfer_exit?:
>> >   drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit declaration of function ?pci_free_consistent? [-Werror=implicit-function-declaration]
>> >   drivers/media/usb/b2c2/flexcop-usb.c: In function ?flexcop_usb_transfer_init?:
>> >   drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit declaration of function ?pci_alloc_consistent? [-Werror=implicit-function-declaration]
>> >   drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment makes pointer from integer without a cast [enabled by default]
>> >   cc1: some warnings being treated as errors
>> > 
>> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
>> > ---
>> >  arch/arm64/include/asm/pci.h |   11 +++++++++++
>> >  1 files changed, 11 insertions(+), 0 deletions(-)
>> >  create mode 100644 arch/arm64/include/asm/pci.h
>> > 
>> > diff --git a/arch/arm64/include/asm/pci.h b/arch/arm64/include/asm/pci.h
>> > new file mode 100644
>> > index 0000000..2ed467f
>> > --- /dev/null
>> > +++ b/arch/arm64/include/asm/pci.h
>> > @@ -0,0 +1,11 @@
>> > +#ifndef ASMARM64_PCI_H
>> > +#define ASMARM64_PCI_H
>> > +
>> > +#ifdef __KERNEL__
>> > +
>> > +#include <asm-generic/pci-dma-compat.h>
>> > +#include <asm-generic/pci.h>
>> > +
>> > +#endif /* __KERNEL__ */
>> > +
>> > +#endif
> I wonder whether it makes sense to include pci-dma-compat.h in
> asm-generic/pci.h, I don't see why one would want the generic pci.h but
> not the generic pci-dma-compat.h (cc'ing Arnd).

I think, it will let architecture guys easier to add their own
pci-dma-compat.h (although they still need generic pci_dma_compat.h, and
generic pci.h, too).

e.g. one architecture want include generic pci-dma-compat.h firstly,
then define its own features in its own pci-dma-compat.h.

Thanks.
-- 
Chen Gang

WARNING: multiple messages have this Message-ID (diff)
From: Chen Gang <gang.chen@asianux.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <Will.Deacon@arm.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] arch: arm64: include: asm: add pci.h to pass compiling
Date: Thu, 27 Jun 2013 08:30:40 +0800	[thread overview]
Message-ID: <51CB87B0.8030805@asianux.com> (raw)
In-Reply-To: <20130626140730.GB23309@arm.com>

On 06/26/2013 10:07 PM, Catalin Marinas wrote:
> On Wed, Jun 26, 2013 at 04:26:41AM +0100, Chen Gang wrote:
>> > Need add pci.h for compiling, the related error (with allmodconfig):
>> > 
>> >   drivers/media/usb/b2c2/flexcop-usb.c: In function ‘flexcop_usb_transfer_exit’:
>> >   drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit declaration of function ‘pci_free_consistent’ [-Werror=implicit-function-declaration]
>> >   drivers/media/usb/b2c2/flexcop-usb.c: In function ‘flexcop_usb_transfer_init’:
>> >   drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit declaration of function ‘pci_alloc_consistent’ [-Werror=implicit-function-declaration]
>> >   drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment makes pointer from integer without a cast [enabled by default]
>> >   cc1: some warnings being treated as errors
>> > 
>> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
>> > ---
>> >  arch/arm64/include/asm/pci.h |   11 +++++++++++
>> >  1 files changed, 11 insertions(+), 0 deletions(-)
>> >  create mode 100644 arch/arm64/include/asm/pci.h
>> > 
>> > diff --git a/arch/arm64/include/asm/pci.h b/arch/arm64/include/asm/pci.h
>> > new file mode 100644
>> > index 0000000..2ed467f
>> > --- /dev/null
>> > +++ b/arch/arm64/include/asm/pci.h
>> > @@ -0,0 +1,11 @@
>> > +#ifndef ASMARM64_PCI_H
>> > +#define ASMARM64_PCI_H
>> > +
>> > +#ifdef __KERNEL__
>> > +
>> > +#include <asm-generic/pci-dma-compat.h>
>> > +#include <asm-generic/pci.h>
>> > +
>> > +#endif /* __KERNEL__ */
>> > +
>> > +#endif
> I wonder whether it makes sense to include pci-dma-compat.h in
> asm-generic/pci.h, I don't see why one would want the generic pci.h but
> not the generic pci-dma-compat.h (cc'ing Arnd).

I think, it will let architecture guys easier to add their own
pci-dma-compat.h (although they still need generic pci_dma_compat.h, and
generic pci.h, too).

e.g. one architecture want include generic pci-dma-compat.h firstly,
then define its own features in its own pci-dma-compat.h.

Thanks.
-- 
Chen Gang

  reply	other threads:[~2013-06-27  0:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-26  3:26 [PATCH] arch: arm64: include: asm: add pci.h to pass compiling Chen Gang
2013-06-26  3:26 ` Chen Gang
2013-06-26 14:07 ` Catalin Marinas
2013-06-26 14:07   ` Catalin Marinas
2013-06-27  0:30   ` Chen Gang [this message]
2013-06-27  0:30     ` Chen Gang
2013-06-27  2:05     ` Chen Gang
2013-06-27  2:05       ` Chen Gang
2013-06-27  3:47       ` Chen Gang
2013-06-27  3:47         ` Chen Gang
2013-06-27  8:43     ` Arnd Bergmann
2013-06-27  8:43       ` Arnd Bergmann
2013-06-27 10:20       ` Chen Gang
2013-06-27 10:20         ` Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51CB87B0.8030805@asianux.com \
    --to=gang.chen@asianux.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.