All of lore.kernel.org
 help / color / mirror / Atom feed
From: hdegoede@redhat.com (Hans de Goede)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] [PATCH 0/8] clocksource: sunxi: Timer fixes and cleanup
Date: Thu, 27 Jun 2013 11:54:11 +0200	[thread overview]
Message-ID: <51CC0BC3.5090309@redhat.com> (raw)
In-Reply-To: <20130627094307.GC8437@lukather>

Hi,

On 06/27/2013 11:43 AM, Maxime Ripard wrote:
> On Thu, Jun 27, 2013 at 11:27:02AM +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 06/26/2013 11:16 PM, Maxime Ripard wrote:
>>> Hi everyone,
>>>
>>
>> <snip>
>>
>>> It also finally adds a clocksource from the free running counter found in the
>>> A10/A13 SoCs.
>>
>> Hmm, have you benchmarked this? There have been reports from linux-sunxi kernel
>> users (xbmc project) that the waiting for the latch is quite slow. Note we
>> don't have anything better yet in the linux-sunxi kernel.
>
> No. I didn't.
>
> Do you have any pointers to these discussions?
>

The original discussion should be somewhere here:
https://groups.google.com/forum/#!forum/linux-sunxi

But I could not find it (it is probably hidden under
an unlogical subject).

Looking at my own notes (a small TODO file), I've
written down that the reporter reports:

  -current clocksource can cause us to run with interrupts disabled for 17%
   of the time, see "perf top" output

This is with a workload which does a lot of gettimeofday
calls.

I notice that unlike the sunxi-3.4 code you don't do any locking,
so how do you stop 2 clocksource calls from racing (and thus
getting a possible wrong value because of things not
being properly latched) ?

Regards,

Hans

WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede@redhat.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: linux-sunxi@googlegroups.com,
	John Stultz <john.stultz@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Emilio Lopez <emilio@elopez.com.ar>,
	kevin@allwinnertech.com, sunny@allwinnertech.com,
	shuge@allwinnertech.com
Subject: Re: [linux-sunxi] [PATCH 0/8] clocksource: sunxi: Timer fixes and cleanup
Date: Thu, 27 Jun 2013 11:54:11 +0200	[thread overview]
Message-ID: <51CC0BC3.5090309@redhat.com> (raw)
In-Reply-To: <20130627094307.GC8437@lukather>

Hi,

On 06/27/2013 11:43 AM, Maxime Ripard wrote:
> On Thu, Jun 27, 2013 at 11:27:02AM +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 06/26/2013 11:16 PM, Maxime Ripard wrote:
>>> Hi everyone,
>>>
>>
>> <snip>
>>
>>> It also finally adds a clocksource from the free running counter found in the
>>> A10/A13 SoCs.
>>
>> Hmm, have you benchmarked this? There have been reports from linux-sunxi kernel
>> users (xbmc project) that the waiting for the latch is quite slow. Note we
>> don't have anything better yet in the linux-sunxi kernel.
>
> No. I didn't.
>
> Do you have any pointers to these discussions?
>

The original discussion should be somewhere here:
https://groups.google.com/forum/#!forum/linux-sunxi

But I could not find it (it is probably hidden under
an unlogical subject).

Looking at my own notes (a small TODO file), I've
written down that the reporter reports:

  -current clocksource can cause us to run with interrupts disabled for 17%
   of the time, see "perf top" output

This is with a workload which does a lot of gettimeofday
calls.

I notice that unlike the sunxi-3.4 code you don't do any locking,
so how do you stop 2 clocksource calls from racing (and thus
getting a possible wrong value because of things not
being properly latched) ?

Regards,

Hans

  reply	other threads:[~2013-06-27  9:54 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-26 21:16 [PATCH 0/8] clocksource: sunxi: Timer fixes and cleanup Maxime Ripard
2013-06-26 21:16 ` Maxime Ripard
2013-06-26 21:16 ` [PATCH 1/8] clocksource: sun4i: Use the BIT macros where possible Maxime Ripard
2013-06-26 21:16   ` Maxime Ripard
2013-06-26 21:16 ` [PATCH 2/8] clocksource: sun4i: Add clocksource and sched clock drivers Maxime Ripard
2013-06-26 21:16   ` Maxime Ripard
2013-06-26 21:27   ` Daniel Lezcano
2013-06-26 21:27     ` Daniel Lezcano
2013-06-27  9:31     ` Maxime Ripard
2013-06-27  9:31       ` Maxime Ripard
2013-06-27  6:02   ` Baruch Siach
2013-06-27  6:02     ` Baruch Siach
2013-06-27  9:35     ` Maxime Ripard
2013-06-27  9:35       ` Maxime Ripard
2013-06-27  9:46       ` Baruch Siach
2013-06-27  9:46         ` Baruch Siach
2013-06-27 17:21         ` Maxime Ripard
2013-06-27 17:21           ` Maxime Ripard
2013-06-27 17:36           ` Baruch Siach
2013-06-27 17:36             ` Baruch Siach
2013-06-27 19:16             ` Maxime Ripard
2013-06-27 19:16               ` Maxime Ripard
2013-06-27 10:17   ` [linux-sunxi] " Siarhei Siamashka
2013-06-27 10:17     ` Siarhei Siamashka
2013-06-27 17:02     ` Maxime Ripard
2013-06-27 17:02       ` Maxime Ripard
2013-06-27 19:51       ` Siarhei Siamashka
2013-06-27 19:51         ` Siarhei Siamashka
2013-06-28 10:19         ` Maxime Ripard
2013-06-28 10:19           ` Maxime Ripard
2013-06-26 21:16 ` [PATCH 3/8] clocksource: sun4i: Don't forget to enable the clock we use Maxime Ripard
2013-06-26 21:16   ` Maxime Ripard
2013-06-26 21:16 ` [PATCH 4/8] clocksource: sun4i: Fix the next event code Maxime Ripard
2013-06-26 21:16   ` Maxime Ripard
2013-06-26 21:16 ` [PATCH 5/8] clocksource: sun4i: Factor out some timer code Maxime Ripard
2013-06-26 21:16   ` Maxime Ripard
2013-06-26 21:16 ` [PATCH 6/8] clocksource: sun4i: Remove TIMER_SCAL variable Maxime Ripard
2013-06-26 21:16   ` Maxime Ripard
2013-06-26 21:17 ` [PATCH 7/8] clocksource: sun4i: Cleanup parent clock setup Maxime Ripard
2013-06-26 21:17   ` Maxime Ripard
2013-06-26 21:17 ` [PATCH 8/8] clocksource: sun4i: Fix bug when switching from periodic to oneshot modes Maxime Ripard
2013-06-26 21:17   ` Maxime Ripard
2013-06-27  9:27 ` [linux-sunxi] [PATCH 0/8] clocksource: sunxi: Timer fixes and cleanup Hans de Goede
2013-06-27  9:27   ` Hans de Goede
2013-06-27  9:43   ` Maxime Ripard
2013-06-27  9:43     ` Maxime Ripard
2013-06-27  9:54     ` Hans de Goede [this message]
2013-06-27  9:54       ` Hans de Goede
2013-06-27 16:54       ` Maxime Ripard
2013-06-27 16:54         ` Maxime Ripard
2013-06-27 18:13         ` Hans de Goede
2013-06-27 18:13           ` Hans de Goede
2013-06-28 10:41           ` Maxime Ripard
2013-06-28 10:41             ` Maxime Ripard
2013-06-27 20:26         ` Siarhei Siamashka
2013-06-27 20:26           ` Siarhei Siamashka
2013-06-28  8:17           ` Hans de Goede
2013-06-28  8:17             ` Hans de Goede
     [not found]           ` <2013062809433715678058@allwinnertech.com>
2013-06-28  9:48             ` Siarhei Siamashka
2013-06-28 10:26               ` Thomas Gleixner
2013-06-28 10:26                 ` Thomas Gleixner
2013-06-28 11:14                 ` Siarhei Siamashka
2013-06-28 11:14                   ` Siarhei Siamashka
2013-06-28 10:29             ` Siarhei Siamashka
2013-06-28 14:16               ` maxime.ripard
2013-06-28 14:16                 ` maxime.ripard
2013-06-28 14:02             ` Thomas Gleixner
2013-06-28 14:02               ` Thomas Gleixner
2013-06-28 17:03               ` maxime.ripard
2013-06-28 17:03                 ` maxime.ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51CC0BC3.5090309@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.