* [PATCH] include/asm-generic/pci.h: include generic "pci-dma-compat.h"
@ 2013-06-27 4:03 ` Chen Gang
0 siblings, 0 replies; 7+ messages in thread
From: Chen Gang @ 2013-06-27 4:03 UTC (permalink / raw)
To: Arnd Bergmann, Catalin Marinas, Will Deacon, Geert Uytterhoeven,
Hirokazu Takata
Cc: Linux-Arch, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-m32r-ja, linux-m32r
If an architecture need "generic pci.h", it also need generic "pci-dma-
compat.h", so recommend to include it in asm-generic directly.
And now, for arm64 and m32r, may cause compiling error about it.
The related error (with allmodconfig):
drivers/media/usb/b2c2/flexcop-usb.c: In function ‘flexcop_usb_transfer_exit’:
drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit declaration of function ‘pci_free_consistent’ [-Werror=implicit-function-declaration]
drivers/media/usb/b2c2/flexcop-usb.c: In function ‘flexcop_usb_transfer_init’:
drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit declaration of function ‘pci_alloc_consistent’ [-Werror=implicit-function-declaration]
drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment makes pointer from integer without a cast [enabled by default]
cc1: some warnings being treated as errors
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
include/asm-generic/pci.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/asm-generic/pci.h b/include/asm-generic/pci.h
index e80a049..64e2a15 100644
--- a/include/asm-generic/pci.h
+++ b/include/asm-generic/pci.h
@@ -6,6 +6,8 @@
#ifndef _ASM_GENERIC_PCI_H
#define _ASM_GENERIC_PCI_H
+#include <asm-generic/pci-dma-compat.h>
+
static inline struct resource *
pcibios_select_root(struct pci_dev *pdev, struct resource *res)
{
--
1.7.7.6
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] include/asm-generic/pci.h: include generic "pci-dma-compat.h"
@ 2013-06-27 4:03 ` Chen Gang
0 siblings, 0 replies; 7+ messages in thread
From: Chen Gang @ 2013-06-27 4:03 UTC (permalink / raw)
To: linux-arm-kernel
If an architecture need "generic pci.h", it also need generic "pci-dma-
compat.h", so recommend to include it in asm-generic directly.
And now, for arm64 and m32r, may cause compiling error about it.
The related error (with allmodconfig):
drivers/media/usb/b2c2/flexcop-usb.c: In function ?flexcop_usb_transfer_exit?:
drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit declaration of function ?pci_free_consistent? [-Werror=implicit-function-declaration]
drivers/media/usb/b2c2/flexcop-usb.c: In function ?flexcop_usb_transfer_init?:
drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit declaration of function ?pci_alloc_consistent? [-Werror=implicit-function-declaration]
drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment makes pointer from integer without a cast [enabled by default]
cc1: some warnings being treated as errors
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
include/asm-generic/pci.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/asm-generic/pci.h b/include/asm-generic/pci.h
index e80a049..64e2a15 100644
--- a/include/asm-generic/pci.h
+++ b/include/asm-generic/pci.h
@@ -6,6 +6,8 @@
#ifndef _ASM_GENERIC_PCI_H
#define _ASM_GENERIC_PCI_H
+#include <asm-generic/pci-dma-compat.h>
+
static inline struct resource *
pcibios_select_root(struct pci_dev *pdev, struct resource *res)
{
--
1.7.7.6
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] include/asm-generic/pci.h: include generic "pci-dma-compat.h"
2013-06-27 4:03 ` Chen Gang
(?)
@ 2013-06-27 8:29 ` Catalin Marinas
-1 siblings, 0 replies; 7+ messages in thread
From: Catalin Marinas @ 2013-06-27 8:29 UTC (permalink / raw)
To: Chen Gang
Cc: Arnd Bergmann, Will Deacon, Geert Uytterhoeven, Hirokazu Takata,
Linux-Arch, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-m32r-ja@ml.linux-m32r.org, linux-m32r@ml.linux-m32r.org
On Thu, Jun 27, 2013 at 05:03:25AM +0100, Chen Gang wrote:
> If an architecture need "generic pci.h", it also need generic "pci-dma-
> compat.h", so recommend to include it in asm-generic directly.
>
> And now, for arm64 and m32r, may cause compiling error about it.
>
> The related error (with allmodconfig):
>
> drivers/media/usb/b2c2/flexcop-usb.c: In function ‘flexcop_usb_transfer_exit’:
> drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit declaration of function ‘pci_free_consistent’ [-Werror=implicit-function-declaration]
> drivers/media/usb/b2c2/flexcop-usb.c: In function ‘flexcop_usb_transfer_init’:
> drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit declaration of function ‘pci_alloc_consistent’ [-Werror=implicit-function-declaration]
> drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment makes pointer from integer without a cast [enabled by default]
> cc1: some warnings being treated as errors
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
From the arm64 perspective:
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
(but make sure it doesn't break other archs)
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] include/asm-generic/pci.h: include generic "pci-dma-compat.h"
@ 2013-06-27 8:29 ` Catalin Marinas
0 siblings, 0 replies; 7+ messages in thread
From: Catalin Marinas @ 2013-06-27 8:29 UTC (permalink / raw)
To: Chen Gang
Cc: Arnd Bergmann, Will Deacon, Geert Uytterhoeven, Hirokazu Takata,
Linux-Arch, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-m32r-ja@ml.linux-m32r.org, linux-m32r@ml.linux-m32r.org
On Thu, Jun 27, 2013 at 05:03:25AM +0100, Chen Gang wrote:
> If an architecture need "generic pci.h", it also need generic "pci-dma-
> compat.h", so recommend to include it in asm-generic directly.
>
> And now, for arm64 and m32r, may cause compiling error about it.
>
> The related error (with allmodconfig):
>
> drivers/media/usb/b2c2/flexcop-usb.c: In function ‘flexcop_usb_transfer_exit’:
> drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit declaration of function ‘pci_free_consistent’ [-Werror=implicit-function-declaration]
> drivers/media/usb/b2c2/flexcop-usb.c: In function ‘flexcop_usb_transfer_init’:
> drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit declaration of function ‘pci_alloc_consistent’ [-Werror=implicit-function-declaration]
> drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment makes pointer from integer without a cast [enabled by default]
> cc1: some warnings being treated as errors
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>From the arm64 perspective:
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
(but make sure it doesn't break other archs)
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] include/asm-generic/pci.h: include generic "pci-dma-compat.h"
@ 2013-06-27 8:29 ` Catalin Marinas
0 siblings, 0 replies; 7+ messages in thread
From: Catalin Marinas @ 2013-06-27 8:29 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jun 27, 2013 at 05:03:25AM +0100, Chen Gang wrote:
> If an architecture need "generic pci.h", it also need generic "pci-dma-
> compat.h", so recommend to include it in asm-generic directly.
>
> And now, for arm64 and m32r, may cause compiling error about it.
>
> The related error (with allmodconfig):
>
> drivers/media/usb/b2c2/flexcop-usb.c: In function ?flexcop_usb_transfer_exit?:
> drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit declaration of function ?pci_free_consistent? [-Werror=implicit-function-declaration]
> drivers/media/usb/b2c2/flexcop-usb.c: In function ?flexcop_usb_transfer_init?:
> drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit declaration of function ?pci_alloc_consistent? [-Werror=implicit-function-declaration]
> drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment makes pointer from integer without a cast [enabled by default]
> cc1: some warnings being treated as errors
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>From the arm64 perspective:
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
(but make sure it doesn't break other archs)
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] include/asm-generic/pci.h: include generic "pci-dma-compat.h"
2013-06-27 8:29 ` Catalin Marinas
@ 2013-06-27 10:14 ` Chen Gang
-1 siblings, 0 replies; 7+ messages in thread
From: Chen Gang @ 2013-06-27 10:14 UTC (permalink / raw)
To: Catalin Marinas
Cc: Arnd Bergmann, Will Deacon, Geert Uytterhoeven, Hirokazu Takata,
Linux-Arch, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-m32r-ja@ml.linux-m32r.org, linux-m32r@ml.linux-m32r.org
On 06/27/2013 04:29 PM, Catalin Marinas wrote:
> On Thu, Jun 27, 2013 at 05:03:25AM +0100, Chen Gang wrote:
>> > If an architecture need "generic pci.h", it also need generic "pci-dma-
>> > compat.h", so recommend to include it in asm-generic directly.
>> >
>> > And now, for arm64 and m32r, may cause compiling error about it.
>> >
>> > The related error (with allmodconfig):
>> >
>> > drivers/media/usb/b2c2/flexcop-usb.c: In function ‘flexcop_usb_transfer_exit’:
>> > drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit declaration of function ‘pci_free_consistent’ [-Werror=implicit-function-declaration]
>> > drivers/media/usb/b2c2/flexcop-usb.c: In function ‘flexcop_usb_transfer_init’:
>> > drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit declaration of function ‘pci_alloc_consistent’ [-Werror=implicit-function-declaration]
>> > drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment makes pointer from integer without a cast [enabled by default]
>> > cc1: some warnings being treated as errors
>> >
>> >
>> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
> From the arm64 perspective:
>
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
>
Thanks.
> (but make sure it doesn't break other archs)
I will try to check all related archs with allmodconfig (which can also
find more another patches, and can let me familiar the compiler step by
step). ;-)
Thanks.
--
Chen Gang
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] include/asm-generic/pci.h: include generic "pci-dma-compat.h"
@ 2013-06-27 10:14 ` Chen Gang
0 siblings, 0 replies; 7+ messages in thread
From: Chen Gang @ 2013-06-27 10:14 UTC (permalink / raw)
To: linux-arm-kernel
On 06/27/2013 04:29 PM, Catalin Marinas wrote:
> On Thu, Jun 27, 2013 at 05:03:25AM +0100, Chen Gang wrote:
>> > If an architecture need "generic pci.h", it also need generic "pci-dma-
>> > compat.h", so recommend to include it in asm-generic directly.
>> >
>> > And now, for arm64 and m32r, may cause compiling error about it.
>> >
>> > The related error (with allmodconfig):
>> >
>> > drivers/media/usb/b2c2/flexcop-usb.c: In function ?flexcop_usb_transfer_exit?:
>> > drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit declaration of function ?pci_free_consistent? [-Werror=implicit-function-declaration]
>> > drivers/media/usb/b2c2/flexcop-usb.c: In function ?flexcop_usb_transfer_init?:
>> > drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit declaration of function ?pci_alloc_consistent? [-Werror=implicit-function-declaration]
>> > drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment makes pointer from integer without a cast [enabled by default]
>> > cc1: some warnings being treated as errors
>> >
>> >
>> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
> From the arm64 perspective:
>
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
>
Thanks.
> (but make sure it doesn't break other archs)
I will try to check all related archs with allmodconfig (which can also
find more another patches, and can let me familiar the compiler step by
step). ;-)
Thanks.
--
Chen Gang
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-06-27 10:14 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-27 4:03 [PATCH] include/asm-generic/pci.h: include generic "pci-dma-compat.h" Chen Gang
2013-06-27 4:03 ` Chen Gang
2013-06-27 8:29 ` Catalin Marinas
2013-06-27 8:29 ` Catalin Marinas
2013-06-27 8:29 ` Catalin Marinas
2013-06-27 10:14 ` Chen Gang
2013-06-27 10:14 ` Chen Gang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.