From: Nishanth Menon <nm@ti.com>
To: "Vincent Stehlé" <vincent.stehle@freescale.com>
Cc: linux-next@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
Robin Holt <holt@sgi.com>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Tony Lindgren <tony@atomide.com>,
trivial@kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH linux-next] ARM: OMAP2+: fix omap4-restart compilation
Date: Thu, 27 Jun 2013 08:18:06 -0500 [thread overview]
Message-ID: <51CC3B8E.8070702@ti.com> (raw)
In-Reply-To: <1372335961-31401-1-git-send-email-vincent.stehle@freescale.com>
On 06/27/2013 07:26 AM, Vincent Stehlé wrote:
> Fix following compilation error due to missing include file:
>
> arch/arm/mach-omap2/omap4-restart.c:21:28: warning: ‘enum reboot_mode’ declared inside parameter list [enabled by default]
> arch/arm/mach-omap2/omap4-restart.c:21:28: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
> arch/arm/mach-omap2/omap4-restart.c:21:40: error: parameter 1 (‘mode’) has incomplete type
> arch/arm/mach-omap2/omap4-restart.c:21:6: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
> make[1]: *** [arch/arm/mach-omap2/omap4-restart.o] Error 1
>
> Signed-off-by: Vincent Stehlé <vincent.stehle@freescale.com>
> Cc: Robin Holt <holt@sgi.com>
> Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: trivial@kernel.org
> ---
>
>
> Hi,
>
> This fixes the build of linux-next for arch ARM, config multi_v7_defconfig, tag
> next-20130627.
>
> Best regards,
>
> V.
>
>
> arch/arm/mach-omap2/omap4-restart.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-omap2/omap4-restart.c b/arch/arm/mach-omap2/omap4-restart.c
> index 652adde..41dfd7d 100644
> --- a/arch/arm/mach-omap2/omap4-restart.c
> +++ b/arch/arm/mach-omap2/omap4-restart.c
> @@ -8,6 +8,7 @@
> */
>
> #include <linux/types.h>
> +#include <linux/reboot.h>
> #include "prminst44xx.h"
>
> /**
>
Same was covered already?
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-June/178209.html
--
Regards,
Nishanth Menon
WARNING: multiple messages have this Message-ID (diff)
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH linux-next] ARM: OMAP2+: fix omap4-restart compilation
Date: Thu, 27 Jun 2013 08:18:06 -0500 [thread overview]
Message-ID: <51CC3B8E.8070702@ti.com> (raw)
In-Reply-To: <1372335961-31401-1-git-send-email-vincent.stehle@freescale.com>
On 06/27/2013 07:26 AM, Vincent Stehl? wrote:
> Fix following compilation error due to missing include file:
>
> arch/arm/mach-omap2/omap4-restart.c:21:28: warning: ?enum reboot_mode? declared inside parameter list [enabled by default]
> arch/arm/mach-omap2/omap4-restart.c:21:28: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
> arch/arm/mach-omap2/omap4-restart.c:21:40: error: parameter 1 (?mode?) has incomplete type
> arch/arm/mach-omap2/omap4-restart.c:21:6: warning: function declaration isn?t a prototype [-Wstrict-prototypes]
> make[1]: *** [arch/arm/mach-omap2/omap4-restart.o] Error 1
>
> Signed-off-by: Vincent Stehl? <vincent.stehle@freescale.com>
> Cc: Robin Holt <holt@sgi.com>
> Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: trivial at kernel.org
> ---
>
>
> Hi,
>
> This fixes the build of linux-next for arch ARM, config multi_v7_defconfig, tag
> next-20130627.
>
> Best regards,
>
> V.
>
>
> arch/arm/mach-omap2/omap4-restart.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-omap2/omap4-restart.c b/arch/arm/mach-omap2/omap4-restart.c
> index 652adde..41dfd7d 100644
> --- a/arch/arm/mach-omap2/omap4-restart.c
> +++ b/arch/arm/mach-omap2/omap4-restart.c
> @@ -8,6 +8,7 @@
> */
>
> #include <linux/types.h>
> +#include <linux/reboot.h>
> #include "prminst44xx.h"
>
> /**
>
Same was covered already?
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-June/178209.html
--
Regards,
Nishanth Menon
WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm@ti.com>
To: "Vincent Stehlé" <vincent.stehle@freescale.com>
Cc: <linux-next@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Robin Holt <holt@sgi.com>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Tony Lindgren <tony@atomide.com>, <trivial@kernel.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH linux-next] ARM: OMAP2+: fix omap4-restart compilation
Date: Thu, 27 Jun 2013 08:18:06 -0500 [thread overview]
Message-ID: <51CC3B8E.8070702@ti.com> (raw)
In-Reply-To: <1372335961-31401-1-git-send-email-vincent.stehle@freescale.com>
On 06/27/2013 07:26 AM, Vincent Stehlé wrote:
> Fix following compilation error due to missing include file:
>
> arch/arm/mach-omap2/omap4-restart.c:21:28: warning: ‘enum reboot_mode’ declared inside parameter list [enabled by default]
> arch/arm/mach-omap2/omap4-restart.c:21:28: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
> arch/arm/mach-omap2/omap4-restart.c:21:40: error: parameter 1 (‘mode’) has incomplete type
> arch/arm/mach-omap2/omap4-restart.c:21:6: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
> make[1]: *** [arch/arm/mach-omap2/omap4-restart.o] Error 1
>
> Signed-off-by: Vincent Stehlé <vincent.stehle@freescale.com>
> Cc: Robin Holt <holt@sgi.com>
> Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: trivial@kernel.org
> ---
>
>
> Hi,
>
> This fixes the build of linux-next for arch ARM, config multi_v7_defconfig, tag
> next-20130627.
>
> Best regards,
>
> V.
>
>
> arch/arm/mach-omap2/omap4-restart.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-omap2/omap4-restart.c b/arch/arm/mach-omap2/omap4-restart.c
> index 652adde..41dfd7d 100644
> --- a/arch/arm/mach-omap2/omap4-restart.c
> +++ b/arch/arm/mach-omap2/omap4-restart.c
> @@ -8,6 +8,7 @@
> */
>
> #include <linux/types.h>
> +#include <linux/reboot.h>
> #include "prminst44xx.h"
>
> /**
>
Same was covered already?
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-June/178209.html
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2013-06-27 13:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 12:26 [PATCH linux-next] ARM: OMAP2+: fix omap4-restart compilation Vincent Stehlé
2013-06-27 12:26 ` Vincent Stehlé
2013-06-27 12:26 ` Vincent Stehlé
2013-06-27 13:18 ` Nishanth Menon [this message]
2013-06-27 13:18 ` Nishanth Menon
2013-06-27 13:18 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CC3B8E.8070702@ti.com \
--to=nm@ti.com \
--cc=arnd@arndb.de \
--cc=holt@sgi.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=tony@atomide.com \
--cc=trivial@kernel.org \
--cc=vincent.stehle@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.