Re: [Qemu-devel] [PATCH v12 04/15] rdma: export throughput w/ MigrationStats QMP

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1183 bytes --]

On 06/25/2013 07:35 PM, mrhines@linux.vnet.ibm.com wrote:
> From: "Michael R. Hines" <mrhines@us.ibm.com>
> 
> This exposes throughput (in megabits/sec) through QMP.
> 
> Reviewed-by: Juan Quintela <quintela@redhat.com>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> Reviewed-by: Chegu Vinod <chegu_vinod@hp.com>
> Tested-by: Chegu Vinod <chegu_vinod@hp.com>
> Tested-by: Michael R. Hines <mrhines@us.ibm.com>
> Signed-off-by: Michael R. Hines <mrhines@us.ibm.com>

S-o-b should generally be first (signatures are typically appended
chronologically, and it's hard for anyone else to review or test a patch
that hasn't been posted, whereas you should always be signing patches
even on first posting :)

> ---
>  hmp.c                         |    2 ++
>  include/migration/migration.h |    1 +
>  migration.c                   |    6 ++++++
>  qapi-schema.json              |    5 ++++-
>  4 files changed, 13 insertions(+), 1 deletion(-)

But as long as we are listing names, feel free to add:

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]