From: "Michael R. Hines" <mrhines@linux.vnet.ibm.com>
To: Eric Blake <eblake@redhat.com>
Cc: aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org,
owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com,
gokul@us.ibm.com, pbonzini@redhat.com, chegu_vinod@hp.com,
knoel@redhat.com
Subject: Re: [Qemu-devel] [PATCH v12 04/15] rdma: export throughput w/ MigrationStats QMP
Date: Fri, 28 Jun 2013 09:13:24 -0400 [thread overview]
Message-ID: <51CD8BF4.8080302@linux.vnet.ibm.com> (raw)
In-Reply-To: <51CCC48C.3000403@redhat.com>
On 06/27/2013 07:02 PM, Eric Blake wrote:
> On 06/25/2013 07:35 PM, mrhines@linux.vnet.ibm.com wrote:
>> From: "Michael R. Hines" <mrhines@us.ibm.com>
>>
>> This exposes throughput (in megabits/sec) through QMP.
>>
>> Reviewed-by: Juan Quintela <quintela@redhat.com>
>> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
>> Reviewed-by: Chegu Vinod <chegu_vinod@hp.com>
>> Tested-by: Chegu Vinod <chegu_vinod@hp.com>
>> Tested-by: Michael R. Hines <mrhines@us.ibm.com>
>> Signed-off-by: Michael R. Hines <mrhines@us.ibm.com>
> S-o-b should generally be first (signatures are typically appended
> chronologically, and it's hard for anyone else to review or test a patch
> that hasn't been posted, whereas you should always be signing patches
> even on first posting :)
Understood, thank you. =)
>> ---
>> hmp.c | 2 ++
>> include/migration/migration.h | 1 +
>> migration.c | 6 ++++++
>> qapi-schema.json | 5 ++++-
>> 4 files changed, 13 insertions(+), 1 deletion(-)
> But as long as we are listing names, feel free to add:
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
next prev parent reply other threads:[~2013-06-28 13:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 1:35 [Qemu-devel] [PATCH v12 00/15] rdma: migration support mrhines
2013-06-26 1:35 ` [Qemu-devel] [PATCH v12 01/15] rdma: add documentation mrhines
2013-06-26 1:48 ` [Qemu-devel] [PATCH v12 00/15] rdma: migration support Michael R. Hines
2013-06-27 22:41 ` [Qemu-devel] [PATCH v12 01/15] rdma: add documentation Eric Blake
2013-06-27 22:48 ` Michael R. Hines
2013-06-26 1:35 ` [Qemu-devel] [PATCH v12 02/15] rdma: introduce qemu_update_position() mrhines
2013-06-26 1:35 ` [Qemu-devel] [PATCH v12 03/15] rdma: export yield_until_fd_readable() mrhines
2013-06-26 1:35 ` [Qemu-devel] [PATCH v12 04/15] rdma: export throughput w/ MigrationStats QMP mrhines
2013-06-27 23:02 ` Eric Blake
2013-06-28 13:13 ` Michael R. Hines [this message]
2013-06-26 1:35 ` [Qemu-devel] [PATCH v12 05/15] rdma: introduce qemu_file_mode_is_not_valid() mrhines
2013-06-26 1:35 ` [Qemu-devel] [PATCH v12 06/15] rdma: export qemu_fflush() mrhines
2013-06-26 1:35 ` [Qemu-devel] [PATCH v12 08/15] rdma: introduce qemu_ram_foreach_block() mrhines
2013-06-27 19:24 ` Peter Maydell
2013-06-27 19:56 ` Michael R. Hines
2013-06-26 1:35 ` [Qemu-devel] [PATCH v12 09/15] rdma: new QEMUFileOps hooks mrhines
2013-06-26 1:35 ` [Qemu-devel] [PATCH v12 10/15] rdma: introduce capability x-rdma-pin-all mrhines
2013-06-26 1:35 ` [Qemu-devel] [PATCH v12 11/15] rdma: core logic mrhines
2013-06-26 1:35 ` [Qemu-devel] [PATCH v12 12/15] rdma: send pc.ram mrhines
2013-06-26 1:35 ` [Qemu-devel] [PATCH v12 13/15] rdma: allow state transitions between other states besides ACTIVE mrhines
2013-06-26 1:35 ` [Qemu-devel] [PATCH v12 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition mrhines
2013-06-26 1:35 ` [Qemu-devel] [PATCH v12 15/15] rdma: account for the time spent in MIG_STATE_SETUP through QMP mrhines
2013-06-27 22:58 ` Eric Blake
2013-06-28 7:15 ` Paolo Bonzini
2013-06-28 13:15 ` Michael R. Hines
2013-06-28 13:32 ` Eric Blake
2013-06-28 14:45 ` Michael R. Hines
2013-06-28 13:14 ` Michael R. Hines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CD8BF4.8080302@linux.vnet.ibm.com \
--to=mrhines@linux.vnet.ibm.com \
--cc=abali@us.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=chegu_vinod@hp.com \
--cc=eblake@redhat.com \
--cc=gokul@us.ibm.com \
--cc=knoel@redhat.com \
--cc=mrhines@us.ibm.com \
--cc=owasserm@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.