Re: [PATCH] fs: generic_file_llseek_size() should recognize invalid whence values

[Richard Yao <ryao-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]

Please disregard this patch. This was in my outgoing folder from
something that I had previously written, but it had no place being sent
to the list (again).

On 06/27/2013 10:22 PM, Richard Yao wrote:
> generic_file_llseek_size() handles whence values in a switch statement,
> but it lacks cases for both SEEK_SET and invalid values. This causes it
> to treat all invalid whence values as SEEK_SET, which is wrong.
> 
> We fix that by adding a case for SEEK_SET and a default case.
> 
> Signed-off-by: Richard Yao <ryao-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
> ---
>  fs/read_write.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/fs/read_write.c b/fs/read_write.c
> index 0343000..54b8808 100644
> --- a/fs/read_write.c
> +++ b/fs/read_write.c
> @@ -81,6 +81,7 @@ generic_file_llseek_size(struct file *file, loff_t offset, int whence,
>  	switch (whence) {
>  	case SEEK_END:
>  		offset += eof;
> +	case SEEK_SET:
>  		break;
>  	case SEEK_CUR:
>  		/*
> @@ -118,6 +119,8 @@ generic_file_llseek_size(struct file *file, loff_t offset, int whence,
>  			return -ENXIO;
>  		offset = eof;
>  		break;
> +	default:
> +		return -EINVAL;
>  	}
>  
>  	return lseek_execute(file, inode, offset, maxsize);
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]