Re: [Qemu-devel] [PULL 2/3] virtio-ccw: Wire up ioeventfd.

[Paolo Bonzini <pbonzini@redhat.com>]

Il 27/06/2013 20:28, Stefan Weil ha scritto:
> Am 25.06.2013 18:25, schrieb Cornelia Huck:
>> On hosts that support ioeventfd, make use of it for host-to-guest
>> notifications via diagnose 500.
>>
>> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>> ---
>>  hw/s390x/css.c        |    2 +-
>>  hw/s390x/css.h        |    1 +
>>  hw/s390x/virtio-ccw.c |  117 +++++++++++++++++++++++++++++++++++++++++++++++++
>>  hw/s390x/virtio-ccw.h |    7 +++
>>  target-s390x/cpu.h    |   16 +++++++
>>  target-s390x/kvm.c    |   19 ++++++++
>>  6 files changed, 161 insertions(+), 1 deletion(-)
> 
> This patch was recently committed to git master and breaks builds:
> 
> It uses event_notifier_get_fd which is only available for POSIX hosts.
> W32/W64 uses event_notifier_get_handle.
> 
> Output from broken build:
> 
>    LINK  s390x-softmmu/qemu-system-s390xw.exe
> hw/s390x/virtio-ccw.o: In function `virtio_ccw_set_guest2host_notifier':
> hw/s390x/virtio-ccw.c:92: undefined reference to `event_notifier_get_fd'
> hw/s390x/virtio-ccw.c:82: undefined reference to `event_notifier_get_fd'

The solution is simply to pass the EventNotifier to
s390_assign_subch_ioeventfd (as we do for the MemoryListener
eventfd_{add,del} callbacks, for example).

Paolo