From: Stefan Weil <sw@weilnetz.de>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: "Blue Swirl" <blauwirbel@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Anthony Liguori" <aliguori@us.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>,
"Aurélien Jarno" <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PULL 2/3] virtio-ccw: Wire up ioeventfd.
Date: Thu, 27 Jun 2013 20:28:28 +0200 [thread overview]
Message-ID: <51CC844C.5090405@weilnetz.de> (raw)
In-Reply-To: <1372177538-9812-3-git-send-email-cornelia.huck@de.ibm.com>
Am 25.06.2013 18:25, schrieb Cornelia Huck:
> On hosts that support ioeventfd, make use of it for host-to-guest
> notifications via diagnose 500.
>
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> ---
> hw/s390x/css.c | 2 +-
> hw/s390x/css.h | 1 +
> hw/s390x/virtio-ccw.c | 117 +++++++++++++++++++++++++++++++++++++++++++++++++
> hw/s390x/virtio-ccw.h | 7 +++
> target-s390x/cpu.h | 16 +++++++
> target-s390x/kvm.c | 19 ++++++++
> 6 files changed, 161 insertions(+), 1 deletion(-)
This patch was recently committed to git master and breaks builds:
It uses event_notifier_get_fd which is only available for POSIX hosts.
W32/W64 uses event_notifier_get_handle.
Output from broken build:
LINK s390x-softmmu/qemu-system-s390xw.exe
hw/s390x/virtio-ccw.o: In function `virtio_ccw_set_guest2host_notifier':
hw/s390x/virtio-ccw.c:92: undefined reference to `event_notifier_get_fd'
hw/s390x/virtio-ccw.c:82: undefined reference to `event_notifier_get_fd'
Regards
Stefan Weil
next prev parent reply other threads:[~2013-06-27 18:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 16:25 [Qemu-devel] [PULL 0/3] virtio-ccw: fix + notifiers Cornelia Huck
2013-06-25 16:25 ` [Qemu-devel] [PULL 1/3] s390/virtio-ccw: Fix virtio reset Cornelia Huck
2013-06-25 16:25 ` [Qemu-devel] [PULL 2/3] virtio-ccw: Wire up ioeventfd Cornelia Huck
2013-06-27 18:28 ` Stefan Weil [this message]
2013-06-28 6:54 ` Paolo Bonzini
2013-06-28 7:47 ` [Qemu-devel] [PATCH] virtio-ccw: fix build breakage on windows Cornelia Huck
2013-06-28 7:55 ` Paolo Bonzini
2013-06-25 16:25 ` [Qemu-devel] [PULL 3/3] virtio-ccw: Wire up guest and host notifies Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CC844C.5090405@weilnetz.de \
--to=sw@weilnetz.de \
--cc=aliguori@us.ibm.com \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=cornelia.huck@de.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.