* Re: [PATCH 19/19] rt2x00: rt2800usb: add USB device ID for Linksys AE3000
@ 2013-06-28 22:26 Xose Vazquez Perez
2013-06-29 11:38 ` Gabor Juhos
0 siblings, 1 reply; 3+ messages in thread
From: Xose Vazquez Perez @ 2013-06-28 22:26 UTC (permalink / raw)
To: Gabor Juhos, users@rt2x00.serialmonkey.com, linux-wireless
Gabor Juhos wrote:
> diff --git a/drivers/net/wireless/rt2x00/rt2800usb.c b/drivers/net/wireless/rt2x00/rt2800usb.c
> index c24c1fd..6136871 100644
> --- a/drivers/net/wireless/rt2x00/rt2800usb.c
> +++ b/drivers/net/wireless/rt2x00/rt2800usb.c
> @@ -1183,6 +1183,7 @@ static struct usb_device_id rt2800usb_device_table[] = {
> { USB_DEVICE(0x04bb, 0x0944) },
> /* Linksys */
> { USB_DEVICE(0x13b1, 0x002f) },
> + { USB_DEVICE(0x13b1, 0x003b) },
> { USB_DEVICE(0x1737, 0x0079) },
> /* Ralink */
> { USB_DEVICE(0x148f, 0x3572) },
> --
You should separate RT3573 and RT3572 devices.
Rename CONFIG_RT2800USB_RT35XX to CONFIG_RT2800USB_RT3572
and do a new CONFIG_RT2800USB_RT3573 section.
And also you can add safely this usb-ids. All of them
are RT3573 devices:
0x1b75, 0x7733 AirLive 450Mbps Wireless-N Dual Band USB Adapter
0x0b05, 0x17bc ASUS USB-N66 450Mbps Dual Band USB Adapter
0x0b05, 0x17ad ASUS USB-N66 Dual Band N Network Adapter
0x050d, 0x1103 Belkin Wireless Adapter
0x148f, 0xf301 Cameo Ralink3573 3x3 single band USB dongle
0x7392, 0x7733 Edimax
0x0e66, 0x0020 Hawking HD45U Dual Band USB Wireless-N Adapter
0x0e66, 0x0021 Hawking HD45U Dual Band Wls-450N Adapter
0x04bb, 0x094e I-O DATA WN-AG450U Wireless LAN Adapter
0x0789, 0x016b Logitec LAN-W450AN/U2
0x0846, 0x9012 NETGEAR WNDA4100 N900 Wireless Dual Band USB Adapter
0x0846, 0x9019 NETGEAR WNDA4200D Wireless Dual Band USB Adapter
0x2019, 0xed19 Planex GW-USDual450
0x148f, 0x3573 Ralink 802.11n USB Wireless LAN Card
0x0df6, 0x0067 Sitecom Wireless Dualband Network Adapter N750 X6
0x0df6, 0x006a Sitecom Wireless Dualband Network Adapter N900 X7
0x0586, 0x3421 ZyXEL Dual-Band Wireless N450 USB Adapter
-thank you-
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 19/19] rt2x00: rt2800usb: add USB device ID for Linksys AE3000
2013-06-28 22:26 [PATCH 19/19] rt2x00: rt2800usb: add USB device ID for Linksys AE3000 Xose Vazquez Perez
@ 2013-06-29 11:38 ` Gabor Juhos
0 siblings, 0 replies; 3+ messages in thread
From: Gabor Juhos @ 2013-06-29 11:38 UTC (permalink / raw)
To: Xose Vazquez Perez; +Cc: users@rt2x00.serialmonkey.com, linux-wireless
2013.06.29. 0:26 keltezéssel, Xose Vazquez Perez írta:
> Gabor Juhos wrote:
>
>> diff --git a/drivers/net/wireless/rt2x00/rt2800usb.c b/drivers/net/wireless/rt2x00/rt2800usb.c
>> index c24c1fd..6136871 100644
>> --- a/drivers/net/wireless/rt2x00/rt2800usb.c
>> +++ b/drivers/net/wireless/rt2x00/rt2800usb.c
>> @@ -1183,6 +1183,7 @@ static struct usb_device_id rt2800usb_device_table[] = {
>> { USB_DEVICE(0x04bb, 0x0944) },
>> /* Linksys */
>> { USB_DEVICE(0x13b1, 0x002f) },
>> + { USB_DEVICE(0x13b1, 0x003b) },
>> { USB_DEVICE(0x1737, 0x0079) },
>> /* Ralink */
>> { USB_DEVICE(0x148f, 0x3572) },
>> --
>
> You should separate RT3573 and RT3572 devices.
> Rename CONFIG_RT2800USB_RT35XX to CONFIG_RT2800USB_RT3572
> and do a new CONFIG_RT2800USB_RT3573 section.
Renaming a config option is not a good idea IMO. I would simply add a
CONFIG_RT2800USB_RT3573 symbol which depends on CONFIG_RT2800USB_RT35XX instead.
> And also you can add safely this usb-ids. All of them
> are RT3573 devices:
>
> 0x1b75, 0x7733 AirLive 450Mbps Wireless-N Dual Band USB Adapter
> 0x0b05, 0x17bc ASUS USB-N66 450Mbps Dual Band USB Adapter
> 0x0b05, 0x17ad ASUS USB-N66 Dual Band N Network Adapter
> 0x050d, 0x1103 Belkin Wireless Adapter
> 0x148f, 0xf301 Cameo Ralink3573 3x3 single band USB dongle
> 0x7392, 0x7733 Edimax
> 0x0e66, 0x0020 Hawking HD45U Dual Band USB Wireless-N Adapter
> 0x0e66, 0x0021 Hawking HD45U Dual Band Wls-450N Adapter
> 0x04bb, 0x094e I-O DATA WN-AG450U Wireless LAN Adapter
> 0x0789, 0x016b Logitec LAN-W450AN/U2
> 0x0846, 0x9012 NETGEAR WNDA4100 N900 Wireless Dual Band USB Adapter
> 0x0846, 0x9019 NETGEAR WNDA4200D Wireless Dual Band USB Adapter
> 0x2019, 0xed19 Planex GW-USDual450
> 0x148f, 0x3573 Ralink 802.11n USB Wireless LAN Card
> 0x0df6, 0x0067 Sitecom Wireless Dualband Network Adapter N750 X6
> 0x0df6, 0x006a Sitecom Wireless Dualband Network Adapter N900 X7
> 0x0586, 0x3421 ZyXEL Dual-Band Wireless N450 USB Adapter
I did not test any of these devices and I don't even know from where did you get
these IDs. Only a subset of these IDs is present in the Ralink driver.
If you feel that all of these can be added safely, you can send a follow-up patch.
-Gabor
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 00/19] rt2x00: add experimental support for RT3593
@ 2013-06-28 19:12 Gabor Juhos
2013-06-28 19:12 ` [PATCH 19/19] rt2x00: rt2800usb: add USB device ID for Linksys AE3000 Gabor Juhos
0 siblings, 1 reply; 3+ messages in thread
From: Gabor Juhos @ 2013-06-28 19:12 UTC (permalink / raw)
To: John Linville; +Cc: linux-wireless, users, Gabor Juhos
This patch-set implements experiemental support for the
RT3593 chipset. The patches are tested on the Linksys
AE3000 USB device only, however other USB devices which
are using the RT3573 chips might work as well.
The patch-set depends on the following series:
'rt2x00: rt2800lib: add support for extended EEPROM of three-cain devices'
Gabor Juhos (19):
rt2x00: rt2800lib: add BBP register initialization for RT3593
rt2x00: rt2800lib: add RFCSR register initialization for RT3593
rt2x00: rt2800lib: add BBP post initialization for RT3593
rt2x00: rt2800lib: add TX power configuration for RT3593
rt2x00: rt2800lib: fix BBP1_TX_ANTENNA field configuration for 3T
devices
rt2x00: rt2800lib: fix antenna configuration for RT3593
rt2x00: rt2800lib: add rt2800_txpower_to_dev helper
rt2x00: rt2800lib: fix default TX power values for RT3593
rt2x00: rt2800lib: introduce rt2800_get_txmixer_gain_{24,5}g helpers
rt2x00: rt2800lib: hardcode TX mixer gain values for RT3593
rt2x00: rt2x00lib: fix LNA_A[12] gain values for RT3593
rt2x00: rt2800lib: add default_power3 field for three-chain devices
rt2x00: rt2800lib: add rf_vals for RF3053
rt2x00: rt2800lib: add channel configuration for RF3053
rt2x00: rt2800lib: enable VCO recalibration for RF3053
rt2x00: rt2800lib: enable RF3053 support
rt2x00: rt2800lib: enable RT3593 support
rt2x00: rt2800usb: use correct [RT]XWI size for RT3593
rt2x00: rt2800usb: add USB device ID for Linksys AE3000
drivers/net/wireless/rt2x00/rt2800.h | 186 ++++-
drivers/net/wireless/rt2x00/rt2800lib.c | 1210 ++++++++++++++++++++++++++++++-
drivers/net/wireless/rt2x00/rt2800usb.c | 6 +-
drivers/net/wireless/rt2x00/rt2x00.h | 1 +
4 files changed, 1358 insertions(+), 45 deletions(-)
--
1.7.10
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH 19/19] rt2x00: rt2800usb: add USB device ID for Linksys AE3000
2013-06-28 19:12 [PATCH 00/19] rt2x00: add experimental support for RT3593 Gabor Juhos
@ 2013-06-28 19:12 ` Gabor Juhos
0 siblings, 0 replies; 3+ messages in thread
From: Gabor Juhos @ 2013-06-28 19:12 UTC (permalink / raw)
To: John Linville; +Cc: linux-wireless, users, Gabor Juhos
The Linksys AE3000 device is based on the RT3573
chipset. The support for this chipset is available
already, and the AE3000 device works with the driver.
Only managed mode works correctly at the moment,
for AP mode additional changes are needed in the
driver.
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
---
drivers/net/wireless/rt2x00/rt2800usb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/rt2x00/rt2800usb.c b/drivers/net/wireless/rt2x00/rt2800usb.c
index c24c1fd..6136871 100644
--- a/drivers/net/wireless/rt2x00/rt2800usb.c
+++ b/drivers/net/wireless/rt2x00/rt2800usb.c
@@ -1183,6 +1183,7 @@ static struct usb_device_id rt2800usb_device_table[] = {
{ USB_DEVICE(0x04bb, 0x0944) },
/* Linksys */
{ USB_DEVICE(0x13b1, 0x002f) },
+ { USB_DEVICE(0x13b1, 0x003b) },
{ USB_DEVICE(0x1737, 0x0079) },
/* Ralink */
{ USB_DEVICE(0x148f, 0x3572) },
--
1.7.10
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-29 11:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-28 22:26 [PATCH 19/19] rt2x00: rt2800usb: add USB device ID for Linksys AE3000 Xose Vazquez Perez
2013-06-29 11:38 ` Gabor Juhos
-- strict thread matches above, loose matches on Subject: below --
2013-06-28 19:12 [PATCH 00/19] rt2x00: add experimental support for RT3593 Gabor Juhos
2013-06-28 19:12 ` [PATCH 19/19] rt2x00: rt2800usb: add USB device ID for Linksys AE3000 Gabor Juhos
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.