Re: [PATCH 2/2] strace: add configure options libaio and acl

[Kang Kai <Kai.Kang@windriver.com>]

On 2013年06月29日 01:16, Paul Eggleton wrote:
> On Friday 21 June 2013 16:12:21 Kai Kang wrote:
>> Add strace configure options libaio and acl to enable or disable build
>> with them. Then PACKAGECONFIG can be used to handle dependency.
>>
>> Set "libaio" as a default feature of PACKAGECONFIG.
>> ...
>>
>> +PACKAGECONFIG_class-target ?= "libaio"
>> +PACKAGECONFIG_class-target += "${@base_contains('DISTRO_FEATURES', 'acl',
>> 'acl', '', d)}"

Hi Paul,

> I realise this has already been merged, but I think there are a couple of issues
> with the above. Firstly, for consistency, I think the first option should be
> called "aio" and not "libaio". 
OK, I'll update it.

> Secondly, although this seems to work the use
> of overrides, += and ?= together is a little bit confusing. Perhaps the following
> would be a bit clearer:
>
> PACKAGECONFIG_class-target ?= "aio \
>                                ${@base_contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}"
I considered this way.
When 'acl' in distro feature, I want strace enable acl support. But
PACKAGECONFIG could be overwritten that even 'acl' in distro feature but
not in 'PACKAGECONFIG'.

Thanks,
Kai

>
> Cheers,
> Paul
>


-- 
Regards,
Neil | Kai Kang