From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Kai Kang <kai.kang@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/2] strace: add configure options libaio and acl
Date: Fri, 28 Jun 2013 18:16:29 +0100 [thread overview]
Message-ID: <5322253.NAOJVtts1F@helios> (raw)
In-Reply-To: <7a0305f34aa1f986856e699b69242e353986b6dc.1371802236.git.kai.kang@windriver.com>
On Friday 21 June 2013 16:12:21 Kai Kang wrote:
> Add strace configure options libaio and acl to enable or disable build
> with them. Then PACKAGECONFIG can be used to handle dependency.
>
> Set "libaio" as a default feature of PACKAGECONFIG.
>...
>
> +PACKAGECONFIG_class-target ?= "libaio"
> +PACKAGECONFIG_class-target += "${@base_contains('DISTRO_FEATURES', 'acl',
> 'acl', '', d)}"
I realise this has already been merged, but I think there are a couple of issues
with the above. Firstly, for consistency, I think the first option should be
called "aio" and not "libaio". Secondly, although this seems to work the use
of overrides, += and ?= together is a little bit confusing. Perhaps the following
would be a bit clearer:
PACKAGECONFIG_class-target ?= "aio \
${@base_contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}"
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2013-06-28 17:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 8:12 [PATCH 0/2] V3: Update strace to 4.8 Kai Kang
2013-06-21 8:12 ` [PATCH 1/2] strace: update " Kai Kang
2013-06-21 12:25 ` Richard Purdie
2013-06-21 8:12 ` [PATCH 2/2] strace: add configure options libaio and acl Kai Kang
2013-06-28 17:16 ` Paul Eggleton [this message]
2013-07-01 1:52 ` Kang Kai
2013-07-01 9:45 ` Paul Eggleton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5322253.NAOJVtts1F@helios \
--to=paul.eggleton@linux.intel.com \
--cc=kai.kang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.