From: Dave Hansen <dave@sr71.net>
To: Zheng Liu <gnehzuil.liu@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] mm: madvise: MADV_POPULATE for quick pre-faulting
Date: Mon, 01 Jul 2013 09:16:46 -0700 [thread overview]
Message-ID: <51D1AB6E.9030905@sr71.net> (raw)
In-Reply-To: <51CE4451.4060708@gmail.com>
On 06/28/2013 07:20 PM, Zheng Liu wrote:
>> > IOW, a process needing to do a bunch of MAP_POPULATEs isn't
>> > parallelizable, but one using this mechanism would be.
> I look at the code, and it seems that we will handle MAP_POPULATE flag
> after we release mmap_sem locking in vm_mmap_pgoff():
>
> down_write(&mm->mmap_sem);
> ret = do_mmap_pgoff(file, addr, len, prot, flag, pgoff,
> &populate);
> up_write(&mm->mmap_sem);
> if (populate)
> mm_populate(ret, populate);
>
> Am I missing something?
I went and did my same test using mmap(MAP_POPULATE)/munmap() pair
versus using MADV_POPULATE in 160 threads in parallel.
MADV_POPULATE was about 10x faster in the threaded configuration.
With MADV_POPULATE, the biggest cost is shipping the mmap_sem cacheline
around so that we can write the reader count update in to it. With
mmap(), there is a lot of _contention_ on that lock which is much, much
more expensive than simply bouncing a cacheline around.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@sr71.net>
To: Zheng Liu <gnehzuil.liu@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] mm: madvise: MADV_POPULATE for quick pre-faulting
Date: Mon, 01 Jul 2013 09:16:46 -0700 [thread overview]
Message-ID: <51D1AB6E.9030905@sr71.net> (raw)
In-Reply-To: <51CE4451.4060708@gmail.com>
On 06/28/2013 07:20 PM, Zheng Liu wrote:
>> > IOW, a process needing to do a bunch of MAP_POPULATEs isn't
>> > parallelizable, but one using this mechanism would be.
> I look at the code, and it seems that we will handle MAP_POPULATE flag
> after we release mmap_sem locking in vm_mmap_pgoff():
>
> down_write(&mm->mmap_sem);
> ret = do_mmap_pgoff(file, addr, len, prot, flag, pgoff,
> &populate);
> up_write(&mm->mmap_sem);
> if (populate)
> mm_populate(ret, populate);
>
> Am I missing something?
I went and did my same test using mmap(MAP_POPULATE)/munmap() pair
versus using MADV_POPULATE in 160 threads in parallel.
MADV_POPULATE was about 10x faster in the threaded configuration.
With MADV_POPULATE, the biggest cost is shipping the mmap_sem cacheline
around so that we can write the reader count update in to it. With
mmap(), there is a lot of _contention_ on that lock which is much, much
more expensive than simply bouncing a cacheline around.
next prev parent reply other threads:[~2013-07-01 16:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 23:16 [RFC][PATCH] mm: madvise: MADV_POPULATE for quick pre-faulting Dave Hansen
2013-06-27 23:16 ` Dave Hansen
2013-06-28 5:47 ` Zheng Liu
2013-06-28 5:47 ` Zheng Liu
2013-06-28 15:48 ` Dave Hansen
2013-06-28 15:48 ` Dave Hansen
2013-06-29 2:20 ` Zheng Liu
2013-06-29 2:20 ` Zheng Liu
2013-07-01 16:16 ` Dave Hansen [this message]
2013-07-01 16:16 ` Dave Hansen
2013-07-02 2:37 ` Zheng Liu
2013-07-02 2:37 ` Zheng Liu
2013-07-02 4:43 ` Dave Hansen
2013-07-02 4:43 ` Dave Hansen
2013-07-02 6:06 ` Zheng Liu
2013-07-02 6:06 ` Zheng Liu
2013-07-14 3:12 ` Sam Ben
2013-07-14 3:12 ` Sam Ben
2013-07-15 0:22 ` Zheng Liu
2013-07-15 0:22 ` Zheng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D1AB6E.9030905@sr71.net \
--to=dave@sr71.net \
--cc=gnehzuil.liu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.