* [PATCH] sunvnet: vnet_port_remove must call unregister_netdev
@ 2013-07-01 21:49 Dave Kleikamp
2013-07-10 20:42 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Dave Kleikamp @ 2013-07-01 21:49 UTC (permalink / raw)
To: sparclinux
The missing call to unregister_netdev() leaves the interface active
after the driver is unloaded by rmmod.
Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
---
drivers/net/ethernet/sun/sunvnet.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/sun/sunvnet.c b/drivers/net/ethernet/sun/sunvnet.c
index 1df0ff3..3df5684 100644
--- a/drivers/net/ethernet/sun/sunvnet.c
+++ b/drivers/net/ethernet/sun/sunvnet.c
@@ -1239,6 +1239,8 @@ static int vnet_port_remove(struct vio_dev *vdev)
dev_set_drvdata(&vdev->dev, NULL);
kfree(port);
+
+ unregister_netdev(vp->dev);
}
return 0;
}
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sunvnet: vnet_port_remove must call unregister_netdev
2013-07-01 21:49 [PATCH] sunvnet: vnet_port_remove must call unregister_netdev Dave Kleikamp
@ 2013-07-10 20:42 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-07-10 20:42 UTC (permalink / raw)
To: sparclinux
From: Dave Kleikamp <dave.kleikamp@oracle.com>
Date: Mon, 01 Jul 2013 16:49:22 -0500
> The missing call to unregister_netdev() leaves the interface active
> after the driver is unloaded by rmmod.
>
> Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-10 20:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-01 21:49 [PATCH] sunvnet: vnet_port_remove must call unregister_netdev Dave Kleikamp
2013-07-10 20:42 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.