All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 4/6] vt6655/trivial: replace numeric with standard PM state macros
@ 2013-06-27 12:57 Yijing Wang
  2013-07-02  1:14 ` Yijing Wang
  0 siblings, 1 reply; 4+ messages in thread
From: Yijing Wang @ 2013-06-27 12:57 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Forest Bond, Jiri Kosina
  Cc: linux-kernel, Hanjun Guo, Yijing Wang, Devendra Naga,
	Marcos Paulo de Souza, Bill Pemberton, devel

Use standard PM state macros PCI_Dx instead of numeric 0/1/2..

Signed-off-by: Yijing Wang <wangyijing@huawei.com>
Cc: Forest Bond <forest@alittletooquiet.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Kosina <trivial@kernel.org>
Cc: Devendra Naga <devendra.aaru@gmail.com>
Cc :Joe Perches <joe@perches.com>
Cc: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Cc: Bill Pemberton <wfp5p@virginia.edu>
Cc: devel@driverdev.osuosl.org
Cc: linux-kernel@vger.kernel.org
---
 drivers/staging/vt6655/device_main.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index 08b250f..7f36a71 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -3370,8 +3370,8 @@ viawget_resume(struct pci_dev *pcid)
 	PSMgmtObject  pMgmt = pDevice->pMgmt;
 	int power_status;   // to silence the compiler
 
-	power_status = pci_set_power_state(pcid, 0);
-	power_status = pci_enable_wake(pcid, 0, 0);
+	power_status = pci_set_power_state(pcid, PCI_D0);
+	power_status = pci_enable_wake(pcid, PCI_D0, 0);
 	pci_restore_state(pcid);
 	if (netif_running(pDevice->dev)) {
 		spin_lock_irq(&pDevice->lock);
-- 
1.7.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 4/6] vt6655/trivial: replace numeric with standard PM state macros
  2013-06-27 12:57 [PATCH 4/6] vt6655/trivial: replace numeric with standard PM state macros Yijing Wang
@ 2013-07-02  1:14 ` Yijing Wang
  2013-07-02  1:23   ` Greg Kroah-Hartman
  0 siblings, 1 reply; 4+ messages in thread
From: Yijing Wang @ 2013-07-02  1:14 UTC (permalink / raw)
  To: Yijing Wang
  Cc: Greg Kroah-Hartman, Forest Bond, Jiri Kosina, linux-kernel,
	Hanjun Guo, Devendra Naga, Marcos Paulo de Souza, Bill Pemberton,
	LKML, Devendra Naga, Joe Perches, Marcos Paulo de Souza

ping...?

On 2013/6/27 20:57, Yijing Wang wrote:
> Use standard PM state macros PCI_Dx instead of numeric 0/1/2..
> 
> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
> Cc: Forest Bond <forest@alittletooquiet.net>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Kosina <trivial@kernel.org>
> Cc: Devendra Naga <devendra.aaru@gmail.com>
> Cc :Joe Perches <joe@perches.com>
> Cc: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> Cc: Bill Pemberton <wfp5p@virginia.edu>
> Cc: devel@driverdev.osuosl.org
> Cc: linux-kernel@vger.kernel.org
> ---
>  drivers/staging/vt6655/device_main.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
> index 08b250f..7f36a71 100644
> --- a/drivers/staging/vt6655/device_main.c
> +++ b/drivers/staging/vt6655/device_main.c
> @@ -3370,8 +3370,8 @@ viawget_resume(struct pci_dev *pcid)
>  	PSMgmtObject  pMgmt = pDevice->pMgmt;
>  	int power_status;   // to silence the compiler
>  
> -	power_status = pci_set_power_state(pcid, 0);
> -	power_status = pci_enable_wake(pcid, 0, 0);
> +	power_status = pci_set_power_state(pcid, PCI_D0);
> +	power_status = pci_enable_wake(pcid, PCI_D0, 0);
>  	pci_restore_state(pcid);
>  	if (netif_running(pDevice->dev)) {
>  		spin_lock_irq(&pDevice->lock);
> 


-- 
Thanks!
Yijing


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 4/6] vt6655/trivial: replace numeric with standard PM state macros
  2013-07-02  1:14 ` Yijing Wang
@ 2013-07-02  1:23   ` Greg Kroah-Hartman
  2013-07-02  1:35     ` Yijing Wang
  0 siblings, 1 reply; 4+ messages in thread
From: Greg Kroah-Hartman @ 2013-07-02  1:23 UTC (permalink / raw)
  To: Yijing Wang
  Cc: Forest Bond, Jiri Kosina, linux-kernel, Hanjun Guo, Devendra Naga,
	Marcos Paulo de Souza, Bill Pemberton, Joe Perches

On Tue, Jul 02, 2013 at 09:14:06AM +0800, Yijing Wang wrote:
> ping...?

You are asking yourself the status of a patch?  Interesting...

> On 2013/6/27 20:57, Yijing Wang wrote:

You sent this after I closed my staging tree, so it will be applied
after 3.11-rc1 is out, don't worry, it's not lost.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 4/6] vt6655/trivial: replace numeric with standard PM state macros
  2013-07-02  1:23   ` Greg Kroah-Hartman
@ 2013-07-02  1:35     ` Yijing Wang
  0 siblings, 0 replies; 4+ messages in thread
From: Yijing Wang @ 2013-07-02  1:35 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Forest Bond, Jiri Kosina, linux-kernel, Hanjun Guo, Devendra Naga,
	Marcos Paulo de Souza, Bill Pemberton, Joe Perches

On 2013/7/2 9:23, Greg Kroah-Hartman wrote:
> On Tue, Jul 02, 2013 at 09:14:06AM +0800, Yijing Wang wrote:
>> ping...?
> 
> You are asking yourself the status of a patch?  Interesting...
> 
>> On 2013/6/27 20:57, Yijing Wang wrote:
> 
> You sent this after I closed my staging tree, so it will be applied
> after 3.11-rc1 is out, don't worry, it's not lost.

Hi Greg,
   I get it, thanks for your reply.

Thanks!
Yijing.

> .
> 


-- 
Thanks!
Yijing


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-07-02  1:36 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-27 12:57 [PATCH 4/6] vt6655/trivial: replace numeric with standard PM state macros Yijing Wang
2013-07-02  1:14 ` Yijing Wang
2013-07-02  1:23   ` Greg Kroah-Hartman
2013-07-02  1:35     ` Yijing Wang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.