* [PATCH -next] net: ethernet: davinci_emac: remove redundant dev_err call in davinci_emac_probe()
@ 2013-07-02 0:57 Wei Yongjun
2013-07-02 4:44 ` Prabhakar Lad
2013-07-02 5:20 ` Mugunthan V N
0 siblings, 2 replies; 5+ messages in thread
From: Wei Yongjun @ 2013-07-02 0:57 UTC (permalink / raw)
To: grant.likely, rob.herring, davem, mugunthanvnm, prabhakar.csengg,
jiri, nsekhar
Cc: yongjun_wei, netdev, devicetree-discuss
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/net/ethernet/ti/davinci_emac.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c
index f118d71..07b176b 100644
--- a/drivers/net/ethernet/ti/davinci_emac.c
+++ b/drivers/net/ethernet/ti/davinci_emac.c
@@ -1870,7 +1870,6 @@ static int davinci_emac_probe(struct platform_device *pdev)
priv->emac_base_phys = res->start + pdata->ctrl_reg_offset;
priv->remap_addr = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(priv->remap_addr)) {
- dev_err(&pdev->dev, "unable to map IO\n");
rc = PTR_ERR(priv->remap_addr);
goto no_pdata;
}
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH -next] net: ethernet: davinci_emac: remove redundant dev_err call in davinci_emac_probe()
2013-07-02 0:57 [PATCH -next] net: ethernet: davinci_emac: remove redundant dev_err call in davinci_emac_probe() Wei Yongjun
@ 2013-07-02 4:44 ` Prabhakar Lad
2013-07-02 5:20 ` Mugunthan V N
1 sibling, 0 replies; 5+ messages in thread
From: Prabhakar Lad @ 2013-07-02 4:44 UTC (permalink / raw)
To: Wei Yongjun
Cc: grant.likely, rob.herring, davem, mugunthanvnm, jiri, nsekhar,
yongjun_wei, netdev, devicetree-discuss
On Tue, Jul 2, 2013 at 6:27 AM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Regards,
--Prabhakar Lad
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] net: ethernet: davinci_emac: remove redundant dev_err call in davinci_emac_probe()
2013-07-02 0:57 [PATCH -next] net: ethernet: davinci_emac: remove redundant dev_err call in davinci_emac_probe() Wei Yongjun
@ 2013-07-02 5:20 ` Mugunthan V N
2013-07-02 5:20 ` Mugunthan V N
1 sibling, 0 replies; 5+ messages in thread
From: Mugunthan V N @ 2013-07-02 5:20 UTC (permalink / raw)
To: Wei Yongjun
Cc: grant.likely, rob.herring, davem, prabhakar.csengg, jiri, nsekhar,
yongjun_wei, netdev, devicetree-discuss
On Tuesday 02 July 2013 06:27 AM, Wei Yongjun wrote:
> From: Wei Yongjun<yongjun_wei@trendmicro.com.cn>
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun<yongjun_wei@trendmicro.com.cn>
Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
Regards
Mugunthan V N
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] net: ethernet: davinci_emac: remove redundant dev_err call in davinci_emac_probe()
@ 2013-07-02 5:20 ` Mugunthan V N
0 siblings, 0 replies; 5+ messages in thread
From: Mugunthan V N @ 2013-07-02 5:20 UTC (permalink / raw)
To: Wei Yongjun
Cc: grant.likely, rob.herring, davem, prabhakar.csengg, jiri, nsekhar,
yongjun_wei, netdev, devicetree-discuss
On Tuesday 02 July 2013 06:27 AM, Wei Yongjun wrote:
> From: Wei Yongjun<yongjun_wei@trendmicro.com.cn>
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun<yongjun_wei@trendmicro.com.cn>
Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
Regards
Mugunthan V N
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] net: ethernet: davinci_emac: remove redundant dev_err call in davinci_emac_probe()
2013-07-02 5:20 ` Mugunthan V N
(?)
@ 2013-07-02 8:10 ` David Miller
-1 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2013-07-02 8:10 UTC (permalink / raw)
To: mugunthanvnm
Cc: weiyj.lk, grant.likely, rob.herring, prabhakar.csengg, jiri,
nsekhar, yongjun_wei, netdev, devicetree-discuss
From: Mugunthan V N <mugunthanvnm@ti.com>
Date: Tue, 2 Jul 2013 10:50:11 +0530
> On Tuesday 02 July 2013 06:27 AM, Wei Yongjun wrote:
>> From: Wei Yongjun<yongjun_wei@trendmicro.com.cn>
>>
>> There is a error message within devm_ioremap_resource
>> already, so remove the dev_err call to avoid redundant
>> error message.
>>
>> Signed-off-by: Wei Yongjun<yongjun_wei@trendmicro.com.cn>
>
> Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
Applied, thanks everyone.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-07-02 8:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-02 0:57 [PATCH -next] net: ethernet: davinci_emac: remove redundant dev_err call in davinci_emac_probe() Wei Yongjun
2013-07-02 4:44 ` Prabhakar Lad
2013-07-02 5:20 ` Mugunthan V N
2013-07-02 5:20 ` Mugunthan V N
2013-07-02 8:10 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.