From: Jan Kiszka <jan.kiszka@siemens.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Liu Ping Fan <pingfank@linux.vnet.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH] qom: Use atomics for object refcounting
Date: Tue, 02 Jul 2013 11:36:39 +0200 [thread overview]
Message-ID: <51D29F27.9040706@siemens.com> (raw)
Objects can soon be referenced/dereference outside the BQL. So we need
to use atomics in object_ref/unref.
Based on patch by Liu Ping Fan.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
qom/object.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/qom/object.c b/qom/object.c
index 803b94b..a76a30b 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -683,16 +683,15 @@ GSList *object_class_get_list(const char *implements_type,
void object_ref(Object *obj)
{
- obj->ref++;
+ __sync_fetch_and_add(&obj->ref, 1);
}
void object_unref(Object *obj)
{
g_assert(obj->ref > 0);
- obj->ref--;
/* parent always holds a reference to its children */
- if (obj->ref == 0) {
+ if (__sync_sub_and_fetch(&obj->ref, 1) == 0) {
object_finalize(obj);
}
}
--
1.7.3.4
next reply other threads:[~2013-07-02 9:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-02 9:36 Jan Kiszka [this message]
2013-07-02 11:15 ` [Qemu-devel] [PATCH] qom: Use atomics for object refcounting Andreas Färber
2013-07-02 11:28 ` Paolo Bonzini
2013-07-02 11:44 ` Jan Kiszka
2013-07-02 11:49 ` Paolo Bonzini
2013-07-02 11:52 ` Jan Kiszka
2013-07-02 12:00 ` Paolo Bonzini
2013-07-02 14:47 ` Anthony Liguori
2013-07-02 15:33 ` Paolo Bonzini
2013-07-02 16:36 ` Anthony Liguori
2013-07-03 1:23 ` liu ping fan
2013-07-03 16:36 ` Andreas Färber
2013-07-04 4:46 ` liu ping fan
2013-07-04 5:43 ` Andreas Färber
2013-07-04 7:21 ` liu ping fan
2013-07-04 7:59 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D29F27.9040706@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=pbonzini@redhat.com \
--cc=pingfank@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.