From: Huang Shijie <b32955@freescale.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"shawn.guo@linaro.org" <shawn.guo@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>
Subject: Re: [PATCH 3/5] ARM: dts: imx6: rename the uart's compatible property
Date: Tue, 2 Jul 2013 18:43:13 +0800 [thread overview]
Message-ID: <51D2AEC1.6030004@freescale.com> (raw)
In-Reply-To: <20130702095645.GD31358@e106331-lin.cambridge.arm.com>
于 2013年07月02日 17:56, Mark Rutland 写道:
> On Tue, Jul 02, 2013 at 07:30:26AM +0100, Huang Shijie wrote:
>> > The imx6 uart can supports the DMA, imx uart driver has added a new
>> > compatible property for the imx6 uart.
>> >
>> > In order to enable the DMA for some uart port in imx6, we rename the
>> > uart's compatible property to "fsl,imx6-uart".
> Doesn't this change break using these dts with an older kernel? You
is it reasonable to use a new dts with an old kernel?
> remove the "fsl,imx21-uart" string older kernels understand.
>
> Given you already had "fsl,imx6q-uart" and "fsl,imx6sl-uart" strings,
> would it not have made more sense to just add these to the driver?
I think it's not a good idea.
Shawn, what's your opinion about this?
thanks
Huang Shijie
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: b32955@freescale.com (Huang Shijie)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] ARM: dts: imx6: rename the uart's compatible property
Date: Tue, 2 Jul 2013 18:43:13 +0800 [thread overview]
Message-ID: <51D2AEC1.6030004@freescale.com> (raw)
In-Reply-To: <20130702095645.GD31358@e106331-lin.cambridge.arm.com>
? 2013?07?02? 17:56, Mark Rutland ??:
> On Tue, Jul 02, 2013 at 07:30:26AM +0100, Huang Shijie wrote:
>> > The imx6 uart can supports the DMA, imx uart driver has added a new
>> > compatible property for the imx6 uart.
>> >
>> > In order to enable the DMA for some uart port in imx6, we rename the
>> > uart's compatible property to "fsl,imx6-uart".
> Doesn't this change break using these dts with an older kernel? You
is it reasonable to use a new dts with an old kernel?
> remove the "fsl,imx21-uart" string older kernels understand.
>
> Given you already had "fsl,imx6q-uart" and "fsl,imx6sl-uart" strings,
> would it not have made more sense to just add these to the driver?
I think it's not a good idea.
Shawn, what's your opinion about this?
thanks
Huang Shijie
next prev parent reply other threads:[~2013-07-02 10:39 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-02 6:30 [PATCH 0/5] serial: imx: add DMA support for imx6 Huang Shijie
2013-07-02 6:30 ` Huang Shijie
2013-07-02 6:30 ` [PATCH 1/5] serial: imx: distinguish the imx6 uart from the others Huang Shijie
2013-07-02 6:30 ` Huang Shijie
2013-07-03 1:48 ` Shawn Guo
2013-07-03 1:48 ` Shawn Guo
2013-07-03 1:52 ` Shawn Guo
2013-07-03 1:52 ` Shawn Guo
2013-07-03 2:17 ` Huang Shijie
2013-07-03 2:17 ` Huang Shijie
2013-07-02 6:30 ` [PATCH 2/5] serial: imx: add DMA support for imx6 Huang Shijie
2013-07-02 6:30 ` Huang Shijie
2013-07-03 3:38 ` Shawn Guo
2013-07-03 3:38 ` Shawn Guo
2013-07-03 5:20 ` Huang Shijie
2013-07-03 5:20 ` Huang Shijie
2013-07-02 6:30 ` [PATCH 3/5] ARM: dts: imx6: rename the uart's compatible property Huang Shijie
2013-07-02 6:30 ` Huang Shijie
2013-07-02 9:56 ` Mark Rutland
2013-07-02 9:56 ` Mark Rutland
2013-07-02 10:43 ` Huang Shijie [this message]
2013-07-02 10:43 ` Huang Shijie
2013-07-02 11:11 ` Mark Rutland
2013-07-02 11:11 ` Mark Rutland
2013-07-03 2:15 ` Huang Shijie
2013-07-03 2:15 ` Huang Shijie
2013-07-03 1:46 ` Shawn Guo
2013-07-03 1:46 ` Shawn Guo
2013-07-02 6:30 ` [PATCH 4/5] ARM: dts: imx6: add dte pinctrl for uart2 Huang Shijie
2013-07-02 6:30 ` Huang Shijie
2013-07-02 6:30 ` [PATCH 5/5] ARM: dts: enable the uart2 for imx6q-arm2 Huang Shijie
2013-07-02 6:30 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D2AEC1.6030004@freescale.com \
--to=b32955@freescale.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.