All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: Stefan Weil <sw@weilnetz.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH v2] spapr: Fix compiler warnings for some versions of gcc
Date: Tue, 02 Jul 2013 14:42:56 +0200	[thread overview]
Message-ID: <51D2CAD0.7090309@suse.de> (raw)
In-Reply-To: <1372513646-6053-1-git-send-email-sw@weilnetz.de>

On 06/29/2013 03:47 PM, Stefan Weil wrote:
> i686-w64-mingw32-gcc (GCC) 4.6.3 from Debian wheezy reports these warnings:
>
> hw/ppc/spapr_hcall.c:188:1: warning:
>   control reaches end of non-void function [-Wreturn-type]
>
> hw/ppc/spapr_pci.c:454:1: warning:
>   control reaches end of non-void function [-Wreturn-type]
>
> Both warnings are fixed by using g_assert_not_reached instead of assert.
> A second line with assert(0) in spapr_pci.c which did not raise a compiler
> warning was modified, too, because g_assert_not_reached documents the
> purpose of that statement and is not removed in release builds.
>
> Signed-off-by: Stefan Weil<sw@weilnetz.de>

Thanks, applied to ppc-next.


Alex

      parent reply	other threads:[~2013-07-02 12:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-29 13:47 [Qemu-devel] [PATCH v2] spapr: Fix compiler warnings for some versions of gcc Stefan Weil
2013-06-29 14:28 ` David Gibson
2013-07-01 10:50 ` Paolo Bonzini
2013-07-02 12:42 ` Alexander Graf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51D2CAD0.7090309@suse.de \
    --to=agraf@suse.de \
    --cc=david@gibson.dropbear.id.au \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.