All of lore.kernel.org
 help / color / mirror / Atom feed
From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 5/7] ARM: kirkwood: convert to DT irqchip and clocksource
Date: Tue, 02 Jul 2013 14:51:16 +0200	[thread overview]
Message-ID: <51D2CCC4.30109@gmail.com> (raw)
In-Reply-To: <20130702115311.GG19937@titan.lakedaemon.net>

On 07/02/13 13:53, Jason Cooper wrote:
> On Tue, Jul 02, 2013 at 01:03:41PM +0200, Sebastian Hesselbarth wrote:
>> With recent support for true irqchip and clocksource drivers for Orion
>> SoCs, now make use of it on DT enabled Kirkwood boards.
>>
>> This also introduces a new Kconfig option for legacy (non-DT) Kirkwood
>> where old code is moved out to and polishes DT board file a little bit.
>>
>> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
>> ---
[...]
>> diff --git a/arch/arm/mach-kirkwood/board-dt.c b/arch/arm/mach-kirkwood/board-dt.c
>> index 881f37e..385244c 100644
>> --- a/arch/arm/mach-kirkwood/board-dt.c
>> +++ b/arch/arm/mach-kirkwood/board-dt.c
>> @@ -15,6 +15,9 @@
>>   #include <linux/of.h>
>>   #include <linux/of_platform.h>
>>   #include <linux/clk-provider.h>
>> +#include <linux/clocksource.h>
>> +#include <linux/dma-mapping.h>
>> +#include <linux/irqchip.h>
>>   #include <linux/kexec.h>
>>   #include <asm/mach/arch.h>
>>   #include <asm/mach/map.h>
>> @@ -67,10 +70,18 @@ static void __init kirkwood_legacy_clk_init(void)
>>   	clk_prepare_enable(clk);
>>   }
>>
>> -static void __init kirkwood_of_clk_init(void)
>> +static void __init kirkwood_dt_time_init(void)
>>   {
>>   	of_clk_init(NULL);
>> -	kirkwood_legacy_clk_init();
>> +	clocksource_of_init();
>> +}
>> +
>> +static void __init kirkwood_dt_init_early(void)
>> +{
>
>
>> +	init_dma_coherent_pool_size(SZ_1M);
>
> This shouldn't be needed any more.  Is there a reason you're adding it
> back in?

Jason, thanks for catching this. The last patch I had was before removal
of init_dma_coherent_pool_size. I slipped back in because I missed the
removal patches.

Can you remove it prior merge, should I prepare a fixup patch, or respin
this patch?

Sebastian

WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Jason Cooper <jason@lakedaemon.net>
Cc: Russell King <linux@arm.linux.org.uk>,
	Andrew Lunn <andrew@lunn.ch>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Gregory CLEMENT <gregory.clement@free-electrons.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 5/7] ARM: kirkwood: convert to DT irqchip and clocksource
Date: Tue, 02 Jul 2013 14:51:16 +0200	[thread overview]
Message-ID: <51D2CCC4.30109@gmail.com> (raw)
In-Reply-To: <20130702115311.GG19937@titan.lakedaemon.net>

On 07/02/13 13:53, Jason Cooper wrote:
> On Tue, Jul 02, 2013 at 01:03:41PM +0200, Sebastian Hesselbarth wrote:
>> With recent support for true irqchip and clocksource drivers for Orion
>> SoCs, now make use of it on DT enabled Kirkwood boards.
>>
>> This also introduces a new Kconfig option for legacy (non-DT) Kirkwood
>> where old code is moved out to and polishes DT board file a little bit.
>>
>> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
>> ---
[...]
>> diff --git a/arch/arm/mach-kirkwood/board-dt.c b/arch/arm/mach-kirkwood/board-dt.c
>> index 881f37e..385244c 100644
>> --- a/arch/arm/mach-kirkwood/board-dt.c
>> +++ b/arch/arm/mach-kirkwood/board-dt.c
>> @@ -15,6 +15,9 @@
>>   #include <linux/of.h>
>>   #include <linux/of_platform.h>
>>   #include <linux/clk-provider.h>
>> +#include <linux/clocksource.h>
>> +#include <linux/dma-mapping.h>
>> +#include <linux/irqchip.h>
>>   #include <linux/kexec.h>
>>   #include <asm/mach/arch.h>
>>   #include <asm/mach/map.h>
>> @@ -67,10 +70,18 @@ static void __init kirkwood_legacy_clk_init(void)
>>   	clk_prepare_enable(clk);
>>   }
>>
>> -static void __init kirkwood_of_clk_init(void)
>> +static void __init kirkwood_dt_time_init(void)
>>   {
>>   	of_clk_init(NULL);
>> -	kirkwood_legacy_clk_init();
>> +	clocksource_of_init();
>> +}
>> +
>> +static void __init kirkwood_dt_init_early(void)
>> +{
>
>
>> +	init_dma_coherent_pool_size(SZ_1M);
>
> This shouldn't be needed any more.  Is there a reason you're adding it
> back in?

Jason, thanks for catching this. The last patch I had was before removal
of init_dma_coherent_pool_size. I slipped back in because I missed the
removal patches.

Can you remove it prior merge, should I prepare a fixup patch, or respin
this patch?

Sebastian


  reply	other threads:[~2013-07-02 12:51 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-02 11:03 [PATCH v4 0/7] ARM: mvebu: switch to DT probed irqchip and clocksource Sebastian Hesselbarth
2013-07-02 11:03 ` Sebastian Hesselbarth
2013-07-02 11:03 ` [PATCH v4 1/7] ARM: dove: move device tree nodes to DT " Sebastian Hesselbarth
2013-07-02 11:03   ` Sebastian Hesselbarth
2013-07-02 11:03 ` [PATCH v4 2/7] ARM: kirkwood: " Sebastian Hesselbarth
2013-07-02 11:03   ` Sebastian Hesselbarth
2013-07-02 11:03 ` [PATCH v4 3/7] ARM: orion5x: update intc device tree node to new reg layout Sebastian Hesselbarth
2013-07-02 11:03   ` Sebastian Hesselbarth
2013-07-02 11:03 ` [PATCH v4 4/7] ARM: dove: convert to DT irqchip and clocksource Sebastian Hesselbarth
2013-07-02 11:03   ` Sebastian Hesselbarth
2013-07-02 11:03 ` [PATCH v4 5/7] ARM: kirkwood: " Sebastian Hesselbarth
2013-07-02 11:03   ` Sebastian Hesselbarth
2013-07-02 11:53   ` Jason Cooper
2013-07-02 11:53     ` Jason Cooper
2013-07-02 12:51     ` Sebastian Hesselbarth [this message]
2013-07-02 12:51       ` Sebastian Hesselbarth
2013-07-02 13:00       ` Jason Cooper
2013-07-02 13:00         ` Jason Cooper
2013-07-02 13:15   ` [PATCH v5 " Sebastian Hesselbarth
2013-07-02 13:15     ` Sebastian Hesselbarth
2013-07-02 13:36     ` Jason Cooper
2013-07-02 13:36       ` Jason Cooper
2013-07-02 11:03 ` [PATCH v4 6/7] ARM: kirkwood: remove obsolete SDIO clock gate workaround Sebastian Hesselbarth
2013-07-02 11:03   ` Sebastian Hesselbarth
2013-07-02 11:03 ` [PATCH v4 7/7] ARM: plat-orion: add reg offset to DT irq driver stub Sebastian Hesselbarth
2013-07-02 11:03   ` Sebastian Hesselbarth
2013-07-25 18:19 ` [PATCH v4 0/7] ARM: mvebu: switch to DT probed irqchip and clocksource Jason Cooper
2013-07-25 18:19   ` Jason Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51D2CCC4.30109@gmail.com \
    --to=sebastian.hesselbarth@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.