Re: [Qemu-devel] [PATCH v2 3/9] tcg-ppc: Don't implement rem

["Andreas Färber" <afaerber@suse.de>]

Am 26.06.2013 22:52, schrieb Richard Henderson:
> Signed-off-by: Richard Henderson <rth@twiddle.net>

Reviewed-by: Andreas Färber <afaerber@suse.de>

Andreas

> ---
>  tcg/ppc/tcg-target.c | 14 --------------
>  tcg/ppc/tcg-target.h |  2 +-
>  2 files changed, 1 insertion(+), 15 deletions(-)
> 
> diff --git a/tcg/ppc/tcg-target.c b/tcg/ppc/tcg-target.c
> index 29ca934..453ab6b 100644
> --- a/tcg/ppc/tcg-target.c
> +++ b/tcg/ppc/tcg-target.c
> @@ -1671,18 +1671,6 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc, const TCGArg *args,
>          tcg_out32 (s, DIVWU | TAB (args[0], args[1], args[2]));
>          break;
>  
> -    case INDEX_op_rem_i32:
> -        tcg_out32 (s, DIVW | TAB (0, args[1], args[2]));
> -        tcg_out32 (s, MULLW | TAB (0, 0, args[2]));
> -        tcg_out32 (s, SUBF | TAB (args[0], 0, args[1]));
> -        break;
> -
> -    case INDEX_op_remu_i32:
> -        tcg_out32 (s, DIVWU | TAB (0, args[1], args[2]));
> -        tcg_out32 (s, MULLW | TAB (0, 0, args[2]));
> -        tcg_out32 (s, SUBF | TAB (args[0], 0, args[1]));
> -        break;
> -
>      case INDEX_op_mulu2_i32:
>          if (args[0] == args[2] || args[0] == args[3]) {
>              tcg_out32 (s, MULLW | TAB (0, args[2], args[3]));
> @@ -1992,8 +1980,6 @@ static const TCGTargetOpDef ppc_op_defs[] = {
>      { INDEX_op_mul_i32, { "r", "r", "ri" } },
>      { INDEX_op_div_i32, { "r", "r", "r" } },
>      { INDEX_op_divu_i32, { "r", "r", "r" } },
> -    { INDEX_op_rem_i32, { "r", "r", "r" } },
> -    { INDEX_op_remu_i32, { "r", "r", "r" } },
>      { INDEX_op_mulu2_i32, { "r", "r", "r", "r" } },
>      { INDEX_op_sub_i32, { "r", "r", "ri" } },
>      { INDEX_op_and_i32, { "r", "r", "ri" } },
> diff --git a/tcg/ppc/tcg-target.h b/tcg/ppc/tcg-target.h
> index 01b880e..b42d97c 100644
> --- a/tcg/ppc/tcg-target.h
> +++ b/tcg/ppc/tcg-target.h
> @@ -78,7 +78,7 @@ typedef enum {
>  
>  /* optional instructions */
>  #define TCG_TARGET_HAS_div_i32          1
> -#define TCG_TARGET_HAS_rem_i32          1
> +#define TCG_TARGET_HAS_rem_i32          0
>  #define TCG_TARGET_HAS_rot_i32          1
>  #define TCG_TARGET_HAS_ext8s_i32        1
>  #define TCG_TARGET_HAS_ext16s_i32       1
> 


-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg