From: Paolo Bonzini <pbonzini@redhat.com>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>,
Gleb Natapov <gleb@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
KVM <kvm@vger.kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>
Subject: Re: [PATCH 1/2] KVM: kvm-io: support cookies
Date: Wed, 03 Jul 2013 11:21:23 +0200 [thread overview]
Message-ID: <51D3ED13.2020408@redhat.com> (raw)
In-Reply-To: <51D3E96E.5080405@redhat.com>
Il 03/07/2013 11:05, Paolo Bonzini ha scritto:
> Nice idea, though I don't really like the duplication between
> kvm_io_bus_write and kvm_io_bus_write_cookie.
>
> Can you make kvm_io_bus_write, and perhaps kvm_io_bus_read too, return
> the cookie, and return -EINVAL here if the cookie is garbage?
On second though---no need to return -EINVAL, you can just pass the
cookie by value and tail-call kvm_io_bus_write. Whatever makes the s390
code look nicer.
Paolo
> (Unfortunately, most callers of kvm_io_bus_read/write expect them to
> never return a value that is >= 0, but there aren't many so it's easily
> solved).
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>,
Gleb Natapov <gleb@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
KVM <kvm@vger.kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>
Subject: Re: [PATCH 1/2] KVM: kvm-io: support cookies
Date: Wed, 03 Jul 2013 11:21:23 +0200 [thread overview]
Message-ID: <51D3ED13.2020408@redhat.com> (raw)
In-Reply-To: <51D3E96E.5080405@redhat.com>
Il 03/07/2013 11:05, Paolo Bonzini ha scritto:
> Nice idea, though I don't really like the duplication between
> kvm_io_bus_write and kvm_io_bus_write_cookie.
>
> Can you make kvm_io_bus_write, and perhaps kvm_io_bus_read too, return
> the cookie, and return -EINVAL here if the cookie is garbage?
On second though---no need to return -EINVAL, you can just pass the
cookie by value and tail-call kvm_io_bus_write. Whatever makes the s390
code look nicer.
Paolo
> (Unfortunately, most callers of kvm_io_bus_read/write expect them to
> never return a value that is >= 0, but there aren't many so it's easily
> solved).
next prev parent reply other threads:[~2013-07-03 9:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-03 8:56 [PATCH 0/2] KVM: enable ioeventfd cookies Cornelia Huck
2013-07-03 8:56 ` [PATCH 1/2] KVM: kvm-io: support cookies Cornelia Huck
2013-07-03 9:05 ` Paolo Bonzini
2013-07-03 9:21 ` Paolo Bonzini [this message]
2013-07-03 9:21 ` Paolo Bonzini
2013-07-03 10:51 ` Cornelia Huck
2013-07-03 10:51 ` Cornelia Huck
2013-07-03 10:58 ` Paolo Bonzini
2013-07-03 11:45 ` Cornelia Huck
2013-07-03 11:45 ` Cornelia Huck
2013-07-03 11:46 ` Paolo Bonzini
2013-07-03 8:56 ` [PATCH 2/2] KVM: s390: use cookies for ioeventfd Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D3ED13.2020408@redhat.com \
--to=pbonzini@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=gleb@redhat.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.