Re: [PATCH v2 4/5] ARM: dts: imx6q: add dte pinctrl for uart2

[Huang Shijie <b32955@freescale.com>]

于 2013年07月04日 16:56, Shawn Guo 写道:
> On Thu, Jul 04, 2013 at 04:42:39PM +0800, Huang Shijie wrote:
>> But this pinctrl is only used in imx6q-arm2 board which uses a big
>> armdillo board,
>> so i did not add the same label to imx6dl.
>>
>> Do we have a imx6dl-arm2 board? if we have , i can add it.
> It does not matter whether or not the pin group is used on an imx6dl
> board.  We have to add it for both SoCs, because it's the only way to
> keep use same label for same pin group on two SoCs.
>
>>>> diff --git a/arch/arm/boot/dts/imx6q.dtsi b/arch/arm/boot/dts/imx6q.dtsi
>>>> index 9a69891..8a518c6 100644
>>>> --- a/arch/arm/boot/dts/imx6q.dtsi
>>>> +++ b/arch/arm/boot/dts/imx6q.dtsi
>>>> @@ -266,6 +266,15 @@
>>>>   							MX6Q_PAD_EIM_D27__UART2_RX_DATA 0x1b0b1
>>>>   						>;
>>>>   					};
>>>> +
>>>> +					pinctrl_uart2_dte: uart2grp-2 {
> Forgot mentioning that in imx dts we generally do not encode function
> name like "dte" in the label but just number.
>
>>>> +						fsl,pins =<
>>>> +							MX6Q_PAD_EIM_D26__UART2_RX_DATA 0x1b0b1
>>>> +							MX6Q_PAD_EIM_D27__UART2_TX_DATA 0x1b0b1
>>>> +							MX6Q_PAD_EIM_D28__UART2_CTS_B	0x1b0b1
>>>> +							MX6Q_PAD_EIM_D29__UART2_CTS_B	0x1b0b1
>>> Why do you have two pads mux-ed on one function?
>> I think the name of the PAD is wrong.
> Fix the name first, then.
ok.

i will fix them in the next version.


thanks
Huang Shijie

--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html