From: Lars-Peter Clausen <lars@metafoo.de>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Shawn Guo <shawn.guo@linaro.org>,
Jonathan Cameron <jic23@cam.ac.uk>,
jimwall@q.com, brian@crystalfontz.com,
Maxime Ripard <maxime.ripard@free-electrons.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree-discuss@lists.ozlabs.org,
Rob Landley <rob@landley.net>,
Rob Herring <rob.herring@calxeda.com>,
Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [PATCHv3 1/3] iio: Add Nuvoton NAU7802 ADC driver
Date: Thu, 04 Jul 2013 11:08:02 +0200 [thread overview]
Message-ID: <51D53B72.6020309@metafoo.de> (raw)
In-Reply-To: <1372094699-3832-2-git-send-email-alexandre.belloni@free-electrons.com>
On 06/24/2013 07:24 PM, Alexandre Belloni wrote:
> The Nuvoton NAU7802 ADC is a 24-bit 2-channels I2C ADC, with adjustable
> gain and sampling rates.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
One remark though. Multiline comments should be like
/*
* foo
* bar
*/
not
/* foo
* bar
*/
But not need to resend the patch just for this
- Lars
WARNING: multiple messages have this Message-ID (diff)
From: lars@metafoo.de (Lars-Peter Clausen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 1/3] iio: Add Nuvoton NAU7802 ADC driver
Date: Thu, 04 Jul 2013 11:08:02 +0200 [thread overview]
Message-ID: <51D53B72.6020309@metafoo.de> (raw)
In-Reply-To: <1372094699-3832-2-git-send-email-alexandre.belloni@free-electrons.com>
On 06/24/2013 07:24 PM, Alexandre Belloni wrote:
> The Nuvoton NAU7802 ADC is a 24-bit 2-channels I2C ADC, with adjustable
> gain and sampling rates.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
One remark though. Multiline comments should be like
/*
* foo
* bar
*/
not
/* foo
* bar
*/
But not need to resend the patch just for this
- Lars
next prev parent reply other threads:[~2013-07-04 9:08 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-24 17:24 [PATCHv3 0/3] Add support for the Nuvoton NAU7802 ADC to the cfa10049 Alexandre Belloni
2013-06-24 17:24 ` Alexandre Belloni
2013-06-24 17:24 ` Alexandre Belloni
2013-06-24 17:24 ` [PATCHv3 1/3] iio: Add Nuvoton NAU7802 ADC driver Alexandre Belloni
2013-06-24 17:24 ` Alexandre Belloni
2013-07-04 9:08 ` Lars-Peter Clausen [this message]
2013-07-04 9:08 ` Lars-Peter Clausen
2013-07-06 10:24 ` Jonathan Cameron
2013-07-06 10:24 ` Jonathan Cameron
2013-07-06 10:24 ` Jonathan Cameron
2013-07-09 14:04 ` Alexandre Belloni
2013-07-09 14:04 ` Alexandre Belloni
2013-07-09 17:43 ` Jonathan Cameron
2013-07-09 17:43 ` Jonathan Cameron
2013-06-24 17:24 ` [PATCHv3 2/3] ARM: mxs: cfa10049: Switch bus i2c1 to bitbanging Alexandre Belloni
2013-06-24 17:24 ` Alexandre Belloni
2013-07-02 2:45 ` Fabio Estevam
2013-07-02 2:45 ` Fabio Estevam
2013-07-02 11:35 ` Alexandre Belloni
2013-07-02 11:35 ` Alexandre Belloni
2013-07-02 11:45 ` Fabio Estevam
2013-07-02 11:45 ` Fabio Estevam
2013-07-02 11:50 ` Alexandre Belloni
2013-07-02 11:50 ` Alexandre Belloni
2013-07-02 14:06 ` Alexandre Belloni
2013-07-02 14:06 ` Alexandre Belloni
2013-07-02 16:33 ` Marek Vasut
2013-07-02 16:33 ` Marek Vasut
2013-07-02 17:15 ` Alexandre Belloni
2013-07-02 17:15 ` Alexandre Belloni
2013-07-02 17:15 ` Alexandre Belloni
2013-07-06 10:26 ` Jonathan Cameron
2013-07-06 10:26 ` Jonathan Cameron
2013-07-06 10:26 ` Jonathan Cameron
2013-07-07 8:47 ` Alexandre Belloni
2013-07-07 8:47 ` Alexandre Belloni
2013-07-07 8:47 ` Alexandre Belloni
2013-06-24 17:24 ` [PATCHv3 3/3] ARM: mxs: cfa10049: Add NAU7802 ADCs to the device tree Alexandre Belloni
2013-06-24 17:24 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D53B72.6020309@metafoo.de \
--to=lars@metafoo.de \
--cc=alexandre.belloni@free-electrons.com \
--cc=brian@crystalfontz.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=jic23@cam.ac.uk \
--cc=jimwall@q.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.