All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
	Marek Marczykowski <marmarek@invisiblethingslab.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] libxl: ignore run_hotplug_scripts setting when backend_domid!=0
Date: Thu, 4 Jul 2013 13:39:51 +0200	[thread overview]
Message-ID: <51D55F07.3010102@citrix.com> (raw)
In-Reply-To: <CAFLBxZYzgDgOQT6fTWScMwDQ9uLt6wScY-whBu3ja_uARtLbpg@mail.gmail.com>

On 04/07/13 12:42, George Dunlap wrote:
> On Tue, Apr 9, 2013 at 9:49 AM, Marek Marczykowski
> <marmarek@invisiblethingslab.com> wrote:
>> Instead of forcing the user to change run_hotplug_scripts setting
>> globally, just ignore it for backends outside of dom0.
>>
>> Signed-off-by: Marek Marczykowski <marmarek@invisiblethingslab.com>
> 
> This seems like a good idea -- Roger / Ian, any thoughts?

We already have this behaviour in libxl (see libxl_device.c:device_hotplug):

/*
 * If device is attached from a driver domain don't try to execute
 * hotplug scripts
 */
if (aodev->dev->backend_domid != LIBXL_TOOLSTACK_DOMID)
    goto out;

This was introduced by commit 05bfd984dfe7014f1f5ea1133608b9bab589c120

  reply	other threads:[~2013-07-04 11:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-09  8:49 [PATCH] libxl: ignore run_hotplug_scripts setting when backend_domid!=0 Marek Marczykowski
2013-07-04 10:42 ` George Dunlap
2013-07-04 11:39   ` Roger Pau Monné [this message]
2013-07-04 12:40     ` George Dunlap
2013-07-04 13:23       ` Roger Pau Monné
2013-07-04 13:51         ` Wei Liu
2013-07-04 14:05           ` George Dunlap
2013-07-04 14:10             ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51D55F07.3010102@citrix.com \
    --to=roger.pau@citrix.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=marmarek@invisiblethingslab.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.