From: Richard Weinberger <richard@nod.at>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>, Jeff Dike <jdike@addtoit.com>
Subject: Re: [PATCH 1/3] arch/um/Makefile: remove dead code
Date: Thu, 04 Jul 2013 23:14:58 +0200 [thread overview]
Message-ID: <51D5E5D2.8020202@nod.at> (raw)
In-Reply-To: <1372971797-23518-2-git-send-email-artagnon@gmail.com>
Am 04.07.2013 23:03, schrieb Ramkumar Ramachandra:
> arch/um/Makefile is included in the toplevel Makefile:495. Well before
> that, it unconditionally sets $SUBARCH (in Makefile:168) as follows:
>
> SUBARCH := $(shell uname -m | sed -e s/i.86/x86/ -e s/x86_64/x86/ \
> -e s/sun4u/sparc64/ \
> -e s/arm.*/arm/ -e s/sa110/arm/ \
> -e s/s390x/s390/ -e s/parisc64/parisc/ \
> -e s/ppc.*/powerpc/ -e s/mips.*/mips/ \
> -e s/sh[234].*/sh/ -e s/aarch64.*/arm64/ )
>
> It is clearly impossible for $SUBARCH to be set as i386 or x86_64.
> Therefore, any code that checks $SUBARCH against these values is dead
> code.
No.
If you build UML for x86_64 you override SUBARCH.
i.e. make linux ARCH=um SUBARCH=x86_64
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Jeff Dike <jdike@addtoit.com>
> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
NAK.
Thanks,
//richard
next prev parent reply other threads:[~2013-07-04 21:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-04 21:03 [PATCH 0/3] Get defconfig to work with ARCH=um Ramkumar Ramachandra
2013-07-04 21:03 ` [PATCH 1/3] arch/um/Makefile: remove dead code Ramkumar Ramachandra
2013-07-04 21:14 ` Richard Weinberger [this message]
2013-07-04 23:53 ` Al Viro
2013-07-05 10:42 ` Ramkumar Ramachandra
2013-07-05 12:23 ` Al Viro
2013-07-04 21:03 ` [PATCH 2/3] arch/um/configs: add defconfig for i386, x86_64 Ramkumar Ramachandra
2013-07-04 21:03 ` [PATCH 3/3] arch/um: migrate to using defconfig in configs/ Ramkumar Ramachandra
2013-07-04 21:27 ` [PATCH 0/3] Get defconfig to work with ARCH=um richard -rw- weinberger
2013-07-04 22:21 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D5E5D2.8020202@nod.at \
--to=richard@nod.at \
--cc=artagnon@gmail.com \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.