From: Hector Palacios <hector.palacios@digi.com>
To: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Cc: Otavio Salvador <otavio@ossystems.com.br>,
Marek Vasut <marex@denx.de>, Jonathan Cameron <jic23@kernel.org>,
"fabio.estevam@freescale.com" <fabio.estevam@freescale.com>
Subject: Re: [PATCH V2] iio: mxs-lradc: Remove useless check in read_raw
Date: Fri, 5 Jul 2013 10:36:02 +0200 [thread overview]
Message-ID: <51D68572.3050705@digi.com> (raw)
In-Reply-To: <CAP9ODKq2y6Ttm2gQc+LxJZi1hrYh2E8dQRW2_zsi4dd=xzsi1g@mail.gmail.com>
On 07/04/2013 10:22 PM, Otavio Salvador wrote:
> On Wed, Jul 3, 2013 at 6:25 PM, Marek Vasut <marex-ynQEQJNshbs@public.gmane.org> wrote:
>> The removed check in the read_raw implementation was always true,
>> therefore remove it. This also fixes a bug, by closely inspecting
>> the code, one can notice the iio_validate_scan_mask_onehot() will
>> always return 1 and therefore the subsequent condition will always
>> succeed, therefore making the mxs_lradc_read_raw() function always
>> return -EINVAL; .
>>
>> Signed-off-by: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
>> Cc: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>> Cc: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
>
> Tested-by: Otavio Salvador <otavio-fKevB0iiKLMBZ+LybsDmbA@public.gmane.org>
Acked-by: Hector Palacios <hector.palacios@digi.com>
Best regards,
--
Hector Palacios
next prev parent reply other threads:[~2013-07-05 8:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-03 21:25 [PATCH V2] iio: mxs-lradc: Remove useless check in read_raw Marek Vasut
2013-07-04 20:22 ` Otavio Salvador
2013-07-05 8:36 ` Hector Palacios [this message]
2013-07-06 9:36 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D68572.3050705@digi.com \
--to=hector.palacios@digi.com \
--cc=fabio.estevam@freescale.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=marex@denx.de \
--cc=otavio@ossystems.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.