From: Sourav Poddar <sourav.poddar@ti.com>
To: yuhang wang <wangyuhang2014@gmail.com>
Cc: linux-mtd <linux-mtd-bounces@lists.infradead.org>,
Johannes Stezenbach <js@sig21.net>,
Grant Likely <grant.likely@secretlab.ca>,
Mark Brown <broonie@kernel.org>,
linux-mtd@lists.infradead.org, Thomas.Betker@rohde-schwarz.com,
spi-devel-general@lists.sourceforge.net,
linux-arm-kernel@lists.infradead.org
Subject: Re: SPI: DUAL/QUAD support
Date: Fri, 5 Jul 2013 14:57:51 +0530 [thread overview]
Message-ID: <51D69197.7060802@ti.com> (raw)
In-Reply-To: <CAHSAbzMfvfdDtTh=3zeBni4fNMAHEMdTJLJU-Oc13HJUqCUj0A@mail.gmail.com>
On Friday 05 July 2013 02:47 PM, yuhang wang wrote:
> 2013/7/5 Sourav Poddar<sourav.poddar@ti.com>:
>> On Friday 05 July 2013 02:37 PM, yuhang wang wrote:
>>>> if (!quad_mode)
>>>> dra7xxx_writel(qspi, qspi->cmd |
>>>> QSPI_RD_SNGL,
>>>> QSPI_SPI_CMD_REG);
>>>> else
>>>> dra7xxx_writel(qspi, qspi->cmd |
>>>> QSPI_RD_QUAD,
>>>> QSPI_SPI_CMD_REG);
>>>> .......
>>>> }
>>> So what do you based on to set variable quad_mode.
>> Best way should be to check for flash device id and manufacture data. Based
>> on which you
>> can decide whether your flash supports quad bits or not.
> Perhaps I did not said it clearly. Your flash supports quad and you
> set it into quad
> mode. But how can your controller driver notice that. In other word,
> In which way
> provide this information from flash to spi controller.
Perhaps, I understood you initial patch wrong. :(
Yes, this is little confusing, and I am trying to figure out that.
As of now, I have tested it with some extern variable, though
we need to see how it can be done cleanly.
I am trying to see if your patch can be used in some way now.
WARNING: multiple messages have this Message-ID (diff)
From: Sourav Poddar <sourav.poddar-l0cyMroinI0@public.gmane.org>
To: yuhang wang <wangyuhang2014-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-mtd
<linux-mtd-bounces-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
Johannes Stezenbach <js-FF7aIK3TAVNeoWH0uzbU5w@public.gmane.org>,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Thomas.Betker-Bf/A/FSCP0w3s4ca2cGeAgC/G2K4zDHf@public.gmane.org,
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: SPI: DUAL/QUAD support
Date: Fri, 5 Jul 2013 14:57:51 +0530 [thread overview]
Message-ID: <51D69197.7060802@ti.com> (raw)
In-Reply-To: <CAHSAbzMfvfdDtTh=3zeBni4fNMAHEMdTJLJU-Oc13HJUqCUj0A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Friday 05 July 2013 02:47 PM, yuhang wang wrote:
> 2013/7/5 Sourav Poddar<sourav.poddar-l0cyMroinI0@public.gmane.org>:
>> On Friday 05 July 2013 02:37 PM, yuhang wang wrote:
>>>> if (!quad_mode)
>>>> dra7xxx_writel(qspi, qspi->cmd |
>>>> QSPI_RD_SNGL,
>>>> QSPI_SPI_CMD_REG);
>>>> else
>>>> dra7xxx_writel(qspi, qspi->cmd |
>>>> QSPI_RD_QUAD,
>>>> QSPI_SPI_CMD_REG);
>>>> .......
>>>> }
>>> So what do you based on to set variable quad_mode.
>> Best way should be to check for flash device id and manufacture data. Based
>> on which you
>> can decide whether your flash supports quad bits or not.
> Perhaps I did not said it clearly. Your flash supports quad and you
> set it into quad
> mode. But how can your controller driver notice that. In other word,
> In which way
> provide this information from flash to spi controller.
Perhaps, I understood you initial patch wrong. :(
Yes, this is little confusing, and I am trying to figure out that.
As of now, I have tested it with some extern variable, though
we need to see how it can be done cleanly.
I am trying to see if your patch can be used in some way now.
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
WARNING: multiple messages have this Message-ID (diff)
From: sourav.poddar@ti.com (Sourav Poddar)
To: linux-arm-kernel@lists.infradead.org
Subject: SPI: DUAL/QUAD support
Date: Fri, 5 Jul 2013 14:57:51 +0530 [thread overview]
Message-ID: <51D69197.7060802@ti.com> (raw)
In-Reply-To: <CAHSAbzMfvfdDtTh=3zeBni4fNMAHEMdTJLJU-Oc13HJUqCUj0A@mail.gmail.com>
On Friday 05 July 2013 02:47 PM, yuhang wang wrote:
> 2013/7/5 Sourav Poddar<sourav.poddar@ti.com>:
>> On Friday 05 July 2013 02:37 PM, yuhang wang wrote:
>>>> if (!quad_mode)
>>>> dra7xxx_writel(qspi, qspi->cmd |
>>>> QSPI_RD_SNGL,
>>>> QSPI_SPI_CMD_REG);
>>>> else
>>>> dra7xxx_writel(qspi, qspi->cmd |
>>>> QSPI_RD_QUAD,
>>>> QSPI_SPI_CMD_REG);
>>>> .......
>>>> }
>>> So what do you based on to set variable quad_mode.
>> Best way should be to check for flash device id and manufacture data. Based
>> on which you
>> can decide whether your flash supports quad bits or not.
> Perhaps I did not said it clearly. Your flash supports quad and you
> set it into quad
> mode. But how can your controller driver notice that. In other word,
> In which way
> provide this information from flash to spi controller.
Perhaps, I understood you initial patch wrong. :(
Yes, this is little confusing, and I am trying to figure out that.
As of now, I have tested it with some extern variable, though
we need to see how it can be done cleanly.
I am trying to see if your patch can be used in some way now.
next prev parent reply other threads:[~2013-07-05 9:27 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-04 11:36 SPI: DUAL/QUAD support yuhang wang
2013-07-04 11:36 ` yuhang wang
2013-07-04 11:36 ` yuhang wang
2013-07-04 13:00 ` Johannes Stezenbach
2013-07-04 13:00 ` Johannes Stezenbach
2013-07-04 13:00 ` Johannes Stezenbach
2013-07-04 14:58 ` Thomas.Betker
2013-07-04 14:58 ` Thomas.Betker at rohde-schwarz.com
2013-07-04 14:58 ` Thomas.Betker-Bf/A/FSCP0w3s4ca2cGeAgC/G2K4zDHf
2013-07-04 15:49 ` Mark Brown
2013-07-04 15:49 ` Mark Brown
2013-07-04 15:49 ` Mark Brown
2013-07-04 16:04 ` Thomas.Betker
2013-07-04 16:04 ` Thomas.Betker at rohde-schwarz.com
2013-07-04 16:04 ` Thomas.Betker-Bf/A/FSCP0w3s4ca2cGeAgC/G2K4zDHf
2013-07-05 6:25 ` yuhang wang
2013-07-05 6:25 ` yuhang wang
2013-07-05 6:25 ` yuhang wang
2013-07-05 6:45 ` Gupta, Pekon
2013-07-05 6:45 ` Gupta, Pekon
2013-07-05 6:45 ` Gupta, Pekon
2013-07-05 7:35 ` Johannes Stezenbach
2013-07-05 7:35 ` Johannes Stezenbach
2013-07-05 7:35 ` Johannes Stezenbach
2013-07-05 7:41 ` Sourav Poddar
2013-07-05 7:41 ` Sourav Poddar
2013-07-05 7:41 ` Sourav Poddar
2013-07-05 8:04 ` Gupta, Pekon
2013-07-05 8:04 ` Gupta, Pekon
2013-07-05 8:04 ` Gupta, Pekon
2013-07-05 7:40 ` Sourav Poddar
2013-07-05 7:40 ` Sourav Poddar
2013-07-05 7:40 ` Sourav Poddar
2013-07-05 8:48 ` yuhang wang
2013-07-05 8:48 ` yuhang wang
2013-07-05 8:48 ` yuhang wang
2013-07-05 8:55 ` Sourav Poddar
2013-07-05 8:55 ` Sourav Poddar
2013-07-05 9:07 ` yuhang wang
2013-07-05 9:07 ` yuhang wang
2013-07-05 9:07 ` yuhang wang
2013-07-05 9:08 ` Sourav Poddar
2013-07-05 9:08 ` Sourav Poddar
2013-07-05 9:08 ` Sourav Poddar
2013-07-05 9:17 ` yuhang wang
2013-07-05 9:17 ` yuhang wang
2013-07-05 9:17 ` yuhang wang
2013-07-05 9:27 ` Sourav Poddar [this message]
2013-07-05 9:27 ` Sourav Poddar
2013-07-05 9:27 ` Sourav Poddar
2013-07-05 10:24 ` yuhang wang
2013-07-05 10:24 ` yuhang wang
2013-07-05 10:24 ` yuhang wang
2013-07-05 14:34 ` Johannes Stezenbach
2013-07-05 14:34 ` Johannes Stezenbach
2013-07-05 14:34 ` Johannes Stezenbach
2013-07-05 15:41 ` yuhang wang
2013-07-05 15:41 ` yuhang wang
2013-07-05 15:41 ` yuhang wang
2013-07-04 14:36 ` Mark Brown
2013-07-04 14:36 ` Mark Brown
2013-07-04 14:36 ` Mark Brown
2013-07-04 18:06 ` Johannes Stezenbach
2013-07-04 18:06 ` Johannes Stezenbach
2013-07-04 18:06 ` Johannes Stezenbach
2013-07-04 19:12 ` Mark Brown
2013-07-04 19:12 ` Mark Brown
2013-07-04 19:12 ` Mark Brown
2013-07-05 9:41 ` yuhang wang
2013-07-05 9:41 ` yuhang wang
2013-07-05 9:41 ` yuhang wang
2013-07-05 10:12 ` Mark Brown
2013-07-05 10:12 ` Mark Brown
2013-07-05 10:12 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2013-07-04 7:07 SPI : " 王宇航
2013-07-04 7:07 ` 王宇航
2013-07-04 7:07 ` 王宇航
2013-07-04 9:00 ` Mark Brown
2013-07-04 9:00 ` Mark Brown
2013-07-04 9:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D69197.7060802@ti.com \
--to=sourav.poddar@ti.com \
--cc=Thomas.Betker@rohde-schwarz.com \
--cc=broonie@kernel.org \
--cc=grant.likely@secretlab.ca \
--cc=js@sig21.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd-bounces@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=wangyuhang2014@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.