From: shinya.kuribayashi.px@renesas.com (Shinya Kuribayashi)
To: linux-arm-kernel@lists.infradead.org
Subject: hrtimer: one more expiry time overflow check in hrtimer_interrupt
Date: Fri, 05 Jul 2013 20:50:24 +0900 [thread overview]
Message-ID: <51D6B300.20804@renesas.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1306281416080.4013@ionos.tec.linutronix.de>
On 6/28/2013 9:22 PM, Thomas Gleixner wrote:
>> On the other hand, we have another call site of tick_program_event() at
>> the bottom of hrtimer_interrupt(). The warning this time is triggered
>> there, so we need to apply the same fix to it.
>
> Well, the problem is that you are just papering over the underlying
> issue of 32bit systems not being prepared for the year 2038 issue.
>
> Just blindly silencing the warning is not going to make the system
> survive 2038 in any sane way. All timespec/val related time functions
> dealing with the clock realtime domain are simply broken in 2038 on
> 32bit, so it does not matter whether a warning triggers or not.
You're right. With this patch applied, the hrtimer_interrupt /looks/
back to normal, but /proc/timer_list still show that "expires at [in
negative range]":
active timers:
#0: tick_cpu_sched, tick_sched_timer, S:01
# expires at 50812500000-50812500000 nsecs [in -165398341280 to -165398341280 nsecs]
This shouldn't happen and something weird is still going on.
> We really need to tackle the underlying problem and not bandaiding a
> known to be broken system.
Agreed, but a little bit hard task for me. This is 100% reproducible,
so I can help debug / verification. Please let me know, if necessary.
Thanks for your comments,
--
Shinya Kuribayashi
Renesas Electronics
WARNING: multiple messages have this Message-ID (diff)
From: Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>
To: tglx@linutronix.de
Cc: prarit@redhat.com, john.stultz@linaro.org,
hiroyuki.yokoyama.vx@renesas.com, takashi.yoshii.zj@renesas.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: hrtimer: one more expiry time overflow check in hrtimer_interrupt
Date: Fri, 05 Jul 2013 20:50:24 +0900 [thread overview]
Message-ID: <51D6B300.20804@renesas.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1306281416080.4013@ionos.tec.linutronix.de>
On 6/28/2013 9:22 PM, Thomas Gleixner wrote:
>> On the other hand, we have another call site of tick_program_event() at
>> the bottom of hrtimer_interrupt(). The warning this time is triggered
>> there, so we need to apply the same fix to it.
>
> Well, the problem is that you are just papering over the underlying
> issue of 32bit systems not being prepared for the year 2038 issue.
>
> Just blindly silencing the warning is not going to make the system
> survive 2038 in any sane way. All timespec/val related time functions
> dealing with the clock realtime domain are simply broken in 2038 on
> 32bit, so it does not matter whether a warning triggers or not.
You're right. With this patch applied, the hrtimer_interrupt /looks/
back to normal, but /proc/timer_list still show that "expires at [in
negative range]":
active timers:
#0: tick_cpu_sched, tick_sched_timer, S:01
# expires at 50812500000-50812500000 nsecs [in -165398341280 to -165398341280 nsecs]
This shouldn't happen and something weird is still going on.
> We really need to tackle the underlying problem and not bandaiding a
> known to be broken system.
Agreed, but a little bit hard task for me. This is 100% reproducible,
so I can help debug / verification. Please let me know, if necessary.
Thanks for your comments,
--
Shinya Kuribayashi
Renesas Electronics
next prev parent reply other threads:[~2013-07-05 11:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 7:41 hrtimer: one more expiry time overflow check in hrtimer_interrupt Shinya Kuribayashi
2013-06-11 7:41 ` Shinya Kuribayashi
2013-06-12 12:21 ` Prarit Bhargava
2013-06-12 12:21 ` Prarit Bhargava
2013-06-14 6:18 ` Shinya Kuribayashi
2013-06-14 6:18 ` Shinya Kuribayashi
2013-06-28 12:22 ` Thomas Gleixner
2013-06-28 12:22 ` Thomas Gleixner
2013-07-05 11:50 ` Shinya Kuribayashi [this message]
2013-07-05 11:50 ` Shinya Kuribayashi
2013-07-05 13:19 ` Thomas Gleixner
2013-07-05 13:19 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D6B300.20804@renesas.com \
--to=shinya.kuribayashi.px@renesas.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.