From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] ARM: tegra: enable gpio-keys on dalmore
Date: Fri, 05 Jul 2013 12:43:05 -0600 [thread overview]
Message-ID: <51D713B9.40205@wwwdotorg.org> (raw)
In-Reply-To: <1373028111-24246-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 07/05/2013 06:41 AM, Laxman Dewangan wrote:
> Dalmore have the keys mounted on board which are connected
> to different pins of Tegra.
>
> Add the keys entry in DTS file to enable key functionality.
> This will enable KEY_POWER, KEY_HOME, KEY_VOLUMEUP and
> KEY_VOLUMEDOWN.
> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
> <&tegra_car TEGRA114_CLK_EXTERN1>;
> clock-names = "pll_a", "pll_a_out0", "mclk";
> };
> +
> + gpio-keys {
The node above is "sound". This node should be before that node so
they're alphabetically sorted.
> + compatible = "gpio-keys";
> +
> + power {
> + label = "Power";
> + gpios = <&gpio TEGRA_GPIO(Q, 0) GPIO_ACTIVE_LOW>;
> + linux,code = <116>; /* KEY_POWER */
> + gpio-key,wakeup;
> + };
> +
> + home {
Similarly, the nodes inside gpio-keys should also be sorted alphabetically.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: tegra: enable gpio-keys on dalmore
Date: Fri, 05 Jul 2013 12:43:05 -0600 [thread overview]
Message-ID: <51D713B9.40205@wwwdotorg.org> (raw)
In-Reply-To: <1373028111-24246-1-git-send-email-ldewangan@nvidia.com>
On 07/05/2013 06:41 AM, Laxman Dewangan wrote:
> Dalmore have the keys mounted on board which are connected
> to different pins of Tegra.
>
> Add the keys entry in DTS file to enable key functionality.
> This will enable KEY_POWER, KEY_HOME, KEY_VOLUMEUP and
> KEY_VOLUMEDOWN.
> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
> <&tegra_car TEGRA114_CLK_EXTERN1>;
> clock-names = "pll_a", "pll_a_out0", "mclk";
> };
> +
> + gpio-keys {
The node above is "sound". This node should be before that node so
they're alphabetically sorted.
> + compatible = "gpio-keys";
> +
> + power {
> + label = "Power";
> + gpios = <&gpio TEGRA_GPIO(Q, 0) GPIO_ACTIVE_LOW>;
> + linux,code = <116>; /* KEY_POWER */
> + gpio-key,wakeup;
> + };
> +
> + home {
Similarly, the nodes inside gpio-keys should also be sorted alphabetically.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: tegra: enable gpio-keys on dalmore
Date: Fri, 05 Jul 2013 12:43:05 -0600 [thread overview]
Message-ID: <51D713B9.40205@wwwdotorg.org> (raw)
In-Reply-To: <1373028111-24246-1-git-send-email-ldewangan@nvidia.com>
On 07/05/2013 06:41 AM, Laxman Dewangan wrote:
> Dalmore have the keys mounted on board which are connected
> to different pins of Tegra.
>
> Add the keys entry in DTS file to enable key functionality.
> This will enable KEY_POWER, KEY_HOME, KEY_VOLUMEUP and
> KEY_VOLUMEDOWN.
> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
> <&tegra_car TEGRA114_CLK_EXTERN1>;
> clock-names = "pll_a", "pll_a_out0", "mclk";
> };
> +
> + gpio-keys {
The node above is "sound". This node should be before that node so
they're alphabetically sorted.
> + compatible = "gpio-keys";
> +
> + power {
> + label = "Power";
> + gpios = <&gpio TEGRA_GPIO(Q, 0) GPIO_ACTIVE_LOW>;
> + linux,code = <116>; /* KEY_POWER */
> + gpio-key,wakeup;
> + };
> +
> + home {
Similarly, the nodes inside gpio-keys should also be sorted alphabetically.
next prev parent reply other threads:[~2013-07-05 18:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-05 12:41 [PATCH] ARM: tegra: enable gpio-keys on dalmore Laxman Dewangan
2013-07-05 12:41 ` Laxman Dewangan
2013-07-05 12:41 ` Laxman Dewangan
[not found] ` <1373028111-24246-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-05 18:43 ` Stephen Warren [this message]
2013-07-05 18:43 ` Stephen Warren
2013-07-05 18:43 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D713B9.40205@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.