All of lore.kernel.org
 help / color / mirror / Atom feed
From: lauraa@codeaurora.org (Laura Abbott)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3] of: Set the DMA mask to 64 bits when dma_addr_t is 64-bits
Date: Mon, 08 Jul 2013 19:38:58 -0700	[thread overview]
Message-ID: <51DB77C2.4060705@codeaurora.org> (raw)
In-Reply-To: <20130708104254.GS24642@n2100.arm.linux.org.uk>

On 7/8/2013 3:42 AM, Russell King - ARM Linux wrote:
>>
>> The problem is the way the arm_dma_limit is set up, all dma allocations
>> are currently broken regardless of if the actual device supports 64-bit
>> addresses or not.
>
> Please explain this statement.
>

The statement was a bit shortsighted given recent discussions. My point 
was that on LPAE systems right now without ZONE_DMA, the allocation 
fails by default (i.e. no call to set_mask) even if the device could 
support 64-bit physical memory. Based on this thread though, drivers 
should stop assuming the dma_mask will be set up properly and always set 
the mask appropriately.

The conclusion also seems to be that if devices on an LPAE system can't 
handle > 32-bit addresses and want to limit via mask, ZONE_DMA must be 
set up.

Please correct me if I misunderstood anything.

Thanks,
Laura

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

WARNING: multiple messages have this Message-ID (diff)
From: Laura Abbott <lauraa-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: Russell King - ARM Linux <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
Cc: Ming Lei <tom.leiming-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>
Subject: Re: [PATCH V3] of: Set the DMA mask to 64 bits when dma_addr_t is 64-bits
Date: Mon, 08 Jul 2013 19:38:58 -0700	[thread overview]
Message-ID: <51DB77C2.4060705@codeaurora.org> (raw)
In-Reply-To: <20130708104254.GS24642-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>

On 7/8/2013 3:42 AM, Russell King - ARM Linux wrote:
>>
>> The problem is the way the arm_dma_limit is set up, all dma allocations
>> are currently broken regardless of if the actual device supports 64-bit
>> addresses or not.
>
> Please explain this statement.
>

The statement was a bit shortsighted given recent discussions. My point 
was that on LPAE systems right now without ZONE_DMA, the allocation 
fails by default (i.e. no call to set_mask) even if the device could 
support 64-bit physical memory. Based on this thread though, drivers 
should stop assuming the dma_mask will be set up properly and always set 
the mask appropriately.

The conclusion also seems to be that if devices on an LPAE system can't 
handle > 32-bit addresses and want to limit via mask, ZONE_DMA must be 
set up.

Please correct me if I misunderstood anything.

Thanks,
Laura

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

  reply	other threads:[~2013-07-09  2:38 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-26 20:31 [PATCH V3] of: Set the DMA mask to 64 bits when dma_addr_t is 64-bits Laura Abbott
2013-04-26 20:31 ` Laura Abbott
2013-04-26 20:52 ` Catalin Marinas
2013-04-26 20:52   ` Catalin Marinas
2013-04-26 21:32 ` Rob Herring
2013-04-26 21:32   ` Rob Herring
2013-07-03 14:15   ` Ming Lei
2013-07-03 14:15     ` Ming Lei
2013-07-05 19:33     ` Laura Abbott
2013-07-05 19:33       ` Laura Abbott
2013-07-06  2:21       ` Ming Lei
2013-07-06  2:21         ` Ming Lei
2013-07-06  9:15         ` Russell King - ARM Linux
2013-07-06  9:15           ` Russell King - ARM Linux
2013-07-08 10:03           ` Ming Lei
2013-07-08 10:03             ` Ming Lei
2013-07-08 10:44             ` Russell King - ARM Linux
2013-07-08 10:44               ` Russell King - ARM Linux
2013-07-08 10:42       ` Russell King - ARM Linux
2013-07-08 10:42         ` Russell King - ARM Linux
2013-07-09  2:38         ` Laura Abbott [this message]
2013-07-09  2:38           ` Laura Abbott
2013-07-05 22:19     ` Russell King - ARM Linux
2013-07-05 22:19       ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51DB77C2.4060705@codeaurora.org \
    --to=lauraa@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.