From: Pekka Enberg <penberg@kernel.org>
To: Will Deacon <will.deacon@arm.com>
Cc: Sasha Levin <sasha.levin@oracle.com>,
KVM General <kvm@vger.kernel.org>,
Michael Tokarev <mjt@tls.msk.ru>,
Michael Ellerman <michael@ellerman.id.au>,
Asias He <asias.hejun@gmail.com>,
jonathan.austin@arm.com
Subject: Re: [PATCH v2] kvm tools: fix boot of guests with more than 4gb of ram
Date: Tue, 09 Jul 2013 09:29:51 +0300 [thread overview]
Message-ID: <51DBADDF.3010103@kernel.org> (raw)
In-Reply-To: <20130708105841.GC22057@mudshark.cambridge.arm.com>
On 07/08/2013 01:58 PM, Will Deacon wrote:
> Hi guys,
>
> On Mon, Jul 08, 2013 at 09:12:26AM +0100, Pekka Enberg wrote:
>> On Sun, Jul 7, 2013 at 7:00 PM, Sasha Levin <sasha.levin@oracle.com> wrote:
>>> Commit "kvm tools: virtio: remove hardcoded assumptions
>>> about guest page size" has introduced a bug that prevented
>>> guests with more than 4gb of ram from booting.
>>>
>>> The issue is that 'pfn' is a 32bit integer, so when multiplying
>>> it by page size to get the actual page will cause an overflow if
>>> the pfn referred to a memory area above 4gb.
>>>
>>> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
>>
>> Will, Michael, Asias, good to merge?
>
> I'm at a conference at the moment, so unable to test this patch, but it
> looks simple and correct enough to me:
>
> Acked-by: Will Deacon <will.deacon@arm.com>
Applied, thanks a lot!
Pekka
prev parent reply other threads:[~2013-07-09 6:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-07 16:00 [PATCH v2] kvm tools: fix boot of guests with more than 4gb of ram Sasha Levin
2013-07-08 8:12 ` Pekka Enberg
2013-07-08 10:58 ` Will Deacon
2013-07-09 6:29 ` Pekka Enberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DBADDF.3010103@kernel.org \
--to=penberg@kernel.org \
--cc=asias.hejun@gmail.com \
--cc=jonathan.austin@arm.com \
--cc=kvm@vger.kernel.org \
--cc=michael@ellerman.id.au \
--cc=mjt@tls.msk.ru \
--cc=sasha.levin@oracle.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.