* [Cocci] [PATCH] invoke arguments the right way in coccinelle script
@ 2013-07-09 15:21 ` Cristian Bercaru
0 siblings, 0 replies; 6+ messages in thread
From: Cristian Bercaru @ 2013-07-09 15:21 UTC (permalink / raw)
To: cocci
Because the command line arguments were invoked incorrectly
'make coccicheck' failed to run 'irqf_oneshot.cocci' and all tests that
followed. Fixed that.
Signed-off-by: Cristian Bercaru <cristian.bercaru@freescale.com>
---
scripts/coccinelle/misc/irqf_oneshot.cocci | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/coccinelle/misc/irqf_oneshot.cocci b/scripts/coccinelle/misc/irqf_oneshot.cocci
index 6cfde94..5cca680 100644
--- a/scripts/coccinelle/misc/irqf_oneshot.cocci
+++ b/scripts/coccinelle/misc/irqf_oneshot.cocci
@@ -4,7 +4,7 @@
//
// Confidence: Good
// Comments:
-// Options: --no-includes
+// Options: -no_includes
virtual patch
virtual context
--
1.7.11.7
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] invoke arguments the right way in coccinelle script
@ 2013-07-09 15:21 ` Cristian Bercaru
0 siblings, 0 replies; 6+ messages in thread
From: Cristian Bercaru @ 2013-07-09 15:21 UTC (permalink / raw)
To: linux-kernel; +Cc: Cristian Bercaru, cocci
Because the command line arguments were invoked incorrectly
'make coccicheck' failed to run 'irqf_oneshot.cocci' and all tests that
followed. Fixed that.
Signed-off-by: Cristian Bercaru <cristian.bercaru@freescale.com>
---
scripts/coccinelle/misc/irqf_oneshot.cocci | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/coccinelle/misc/irqf_oneshot.cocci b/scripts/coccinelle/misc/irqf_oneshot.cocci
index 6cfde94..5cca680 100644
--- a/scripts/coccinelle/misc/irqf_oneshot.cocci
+++ b/scripts/coccinelle/misc/irqf_oneshot.cocci
@@ -4,7 +4,7 @@
//
// Confidence: Good
// Comments:
-// Options: --no-includes
+// Options: -no_includes
virtual patch
virtual context
--
1.7.11.7
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Cocci] [PATCH] invoke arguments the right way in coccinelle script
2013-07-09 15:21 ` Cristian Bercaru
@ 2013-07-09 16:12 ` Lars-Peter Clausen
-1 siblings, 0 replies; 6+ messages in thread
From: Lars-Peter Clausen @ 2013-07-09 16:12 UTC (permalink / raw)
To: cocci
On 07/09/2013 05:21 PM, Cristian Bercaru wrote:
> Because the command line arguments were invoked incorrectly
> 'make coccicheck' failed to run 'irqf_oneshot.cocci' and all tests that
> followed. Fixed that.
>
> Signed-off-by: Cristian Bercaru <cristian.bercaru@freescale.com>
Time to update your coccinelle installation ;)
--no-include is support in new versions and is prefered over -no_includes
> ---
> scripts/coccinelle/misc/irqf_oneshot.cocci | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/coccinelle/misc/irqf_oneshot.cocci b/scripts/coccinelle/misc/irqf_oneshot.cocci
> index 6cfde94..5cca680 100644
> --- a/scripts/coccinelle/misc/irqf_oneshot.cocci
> +++ b/scripts/coccinelle/misc/irqf_oneshot.cocci
> @@ -4,7 +4,7 @@
> //
> // Confidence: Good
> // Comments:
> -// Options: --no-includes
> +// Options: -no_includes
>
> virtual patch
> virtual context
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Cocci] [PATCH] invoke arguments the right way in coccinelle script
@ 2013-07-09 16:12 ` Lars-Peter Clausen
0 siblings, 0 replies; 6+ messages in thread
From: Lars-Peter Clausen @ 2013-07-09 16:12 UTC (permalink / raw)
To: Cristian Bercaru; +Cc: linux-kernel, cocci
On 07/09/2013 05:21 PM, Cristian Bercaru wrote:
> Because the command line arguments were invoked incorrectly
> 'make coccicheck' failed to run 'irqf_oneshot.cocci' and all tests that
> followed. Fixed that.
>
> Signed-off-by: Cristian Bercaru <cristian.bercaru@freescale.com>
Time to update your coccinelle installation ;)
--no-include is support in new versions and is prefered over -no_includes
> ---
> scripts/coccinelle/misc/irqf_oneshot.cocci | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/coccinelle/misc/irqf_oneshot.cocci b/scripts/coccinelle/misc/irqf_oneshot.cocci
> index 6cfde94..5cca680 100644
> --- a/scripts/coccinelle/misc/irqf_oneshot.cocci
> +++ b/scripts/coccinelle/misc/irqf_oneshot.cocci
> @@ -4,7 +4,7 @@
> //
> // Confidence: Good
> // Comments:
> -// Options: --no-includes
> +// Options: -no_includes
>
> virtual patch
> virtual context
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Cocci] [PATCH] invoke arguments the right way in coccinelle script
2013-07-09 16:12 ` Lars-Peter Clausen
@ 2013-07-10 5:53 ` Nicolas Palix
-1 siblings, 0 replies; 6+ messages in thread
From: Nicolas Palix @ 2013-07-10 5:53 UTC (permalink / raw)
To: cocci
Hi Cristian,
You need Coccinelle version 1.0.0-rc11 or above. I think the minimal
required version
is about one year old.
For more information see Documentation/coccinelle.txt which have been updated.
If you prefer to stick to your current version, the commits to revert
are the following ones
ec97946ed038f4b3faa587bc76152b198805b0c4
93f14468491747d6d3efd0b3a42785b1d51a127a
Regards,
On Tue, Jul 9, 2013 at 6:12 PM, Lars-Peter Clausen <lars@metafoo.de> wrote:
> On 07/09/2013 05:21 PM, Cristian Bercaru wrote:
>> Because the command line arguments were invoked incorrectly
>> 'make coccicheck' failed to run 'irqf_oneshot.cocci' and all tests that
>> followed. Fixed that.
>>
>> Signed-off-by: Cristian Bercaru <cristian.bercaru@freescale.com>
>
> Time to update your coccinelle installation ;)
>
> --no-include is support in new versions and is prefered over -no_includes
>
>> ---
>> scripts/coccinelle/misc/irqf_oneshot.cocci | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/coccinelle/misc/irqf_oneshot.cocci b/scripts/coccinelle/misc/irqf_oneshot.cocci
>> index 6cfde94..5cca680 100644
>> --- a/scripts/coccinelle/misc/irqf_oneshot.cocci
>> +++ b/scripts/coccinelle/misc/irqf_oneshot.cocci
>> @@ -4,7 +4,7 @@
>> //
>> // Confidence: Good
>> // Comments:
>> -// Options: --no-includes
>> +// Options: -no_includes
>>
>> virtual patch
>> virtual context
>
> _______________________________________________
> Cocci mailing list
> Cocci at systeme.lip6.fr
> https://systeme.lip6.fr/mailman/listinfo/cocci
--
Nicolas Palix
Tel: +33 4 76 51 46 27
http://membres-liglab.imag.fr/palix/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Cocci] [PATCH] invoke arguments the right way in coccinelle script
@ 2013-07-10 5:53 ` Nicolas Palix
0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Palix @ 2013-07-10 5:53 UTC (permalink / raw)
To: Lars-Peter Clausen; +Cc: Cristian Bercaru, LKML, Coccinelle
Hi Cristian,
You need Coccinelle version 1.0.0-rc11 or above. I think the minimal
required version
is about one year old.
For more information see Documentation/coccinelle.txt which have been updated.
If you prefer to stick to your current version, the commits to revert
are the following ones
ec97946ed038f4b3faa587bc76152b198805b0c4
93f14468491747d6d3efd0b3a42785b1d51a127a
Regards,
On Tue, Jul 9, 2013 at 6:12 PM, Lars-Peter Clausen <lars@metafoo.de> wrote:
> On 07/09/2013 05:21 PM, Cristian Bercaru wrote:
>> Because the command line arguments were invoked incorrectly
>> 'make coccicheck' failed to run 'irqf_oneshot.cocci' and all tests that
>> followed. Fixed that.
>>
>> Signed-off-by: Cristian Bercaru <cristian.bercaru@freescale.com>
>
> Time to update your coccinelle installation ;)
>
> --no-include is support in new versions and is prefered over -no_includes
>
>> ---
>> scripts/coccinelle/misc/irqf_oneshot.cocci | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/coccinelle/misc/irqf_oneshot.cocci b/scripts/coccinelle/misc/irqf_oneshot.cocci
>> index 6cfde94..5cca680 100644
>> --- a/scripts/coccinelle/misc/irqf_oneshot.cocci
>> +++ b/scripts/coccinelle/misc/irqf_oneshot.cocci
>> @@ -4,7 +4,7 @@
>> //
>> // Confidence: Good
>> // Comments:
>> -// Options: --no-includes
>> +// Options: -no_includes
>>
>> virtual patch
>> virtual context
>
> _______________________________________________
> Cocci mailing list
> Cocci@systeme.lip6.fr
> https://systeme.lip6.fr/mailman/listinfo/cocci
--
Nicolas Palix
Tel: +33 4 76 51 46 27
http://membres-liglab.imag.fr/palix/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-07-10 5:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-09 15:21 [Cocci] [PATCH] invoke arguments the right way in coccinelle script Cristian Bercaru
2013-07-09 15:21 ` Cristian Bercaru
2013-07-09 16:12 ` [Cocci] " Lars-Peter Clausen
2013-07-09 16:12 ` Lars-Peter Clausen
2013-07-10 5:53 ` Nicolas Palix
2013-07-10 5:53 ` Nicolas Palix
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.