From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] ARM: tegra: enable palmas device for dalmore
Date: Tue, 09 Jul 2013 10:57:36 -0600 [thread overview]
Message-ID: <51DC4100.4050309@wwwdotorg.org> (raw)
In-Reply-To: <1373290688-2257-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 07/08/2013 07:38 AM, Laxman Dewangan wrote:
> Make the entry of Dalmore Power Management Unit device TPS65913
> in dalmore DTS file. The Palma driver support this device.
>
> Enable following submodule of the TPS65913:
> - GPIO driver
> - RTC driver.
> - Power regulator driver.
> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
> + palmas: tps65913@58 {
I assume there's only one TPS65913 in the system, so that node name
doesn't need to contain the unit address to make it unique; the node can
simply be named "tps65913".
> + palmas_gpio: palmas_gpio {
> + palmas_rtc {
> + palmas_pmic {
I don't think those node names need "palmas" in them; they can simply be
"gpio", "rtc", "pmic".
> + ldousb-in-supply = <&tps65090_dcdc1_reg>;
> + regulators {
You'd usually leave a blank line between properties and nodes.
> + vdd_cam_1v8_reg: regulator@6 {
...
> + gpio = <&palmas_gpio 6 0>; /* Palmas GPIO6 */
That comment probably isn't worthwhile; I only insisted on them for
Tegra GPIOs so that the GPIO name could be included somewhere, whereas
for devices with just a small handful of GPIOs without any other names,
there's no point putting a comment, since it's obvious from the cell
content.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: tegra: enable palmas device for dalmore
Date: Tue, 09 Jul 2013 10:57:36 -0600 [thread overview]
Message-ID: <51DC4100.4050309@wwwdotorg.org> (raw)
In-Reply-To: <1373290688-2257-1-git-send-email-ldewangan@nvidia.com>
On 07/08/2013 07:38 AM, Laxman Dewangan wrote:
> Make the entry of Dalmore Power Management Unit device TPS65913
> in dalmore DTS file. The Palma driver support this device.
>
> Enable following submodule of the TPS65913:
> - GPIO driver
> - RTC driver.
> - Power regulator driver.
> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
> + palmas: tps65913 at 58 {
I assume there's only one TPS65913 in the system, so that node name
doesn't need to contain the unit address to make it unique; the node can
simply be named "tps65913".
> + palmas_gpio: palmas_gpio {
> + palmas_rtc {
> + palmas_pmic {
I don't think those node names need "palmas" in them; they can simply be
"gpio", "rtc", "pmic".
> + ldousb-in-supply = <&tps65090_dcdc1_reg>;
> + regulators {
You'd usually leave a blank line between properties and nodes.
> + vdd_cam_1v8_reg: regulator at 6 {
...
> + gpio = <&palmas_gpio 6 0>; /* Palmas GPIO6 */
That comment probably isn't worthwhile; I only insisted on them for
Tegra GPIOs so that the GPIO name could be included somewhere, whereas
for devices with just a small handful of GPIOs without any other names,
there's no point putting a comment, since it's obvious from the cell
content.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: tegra: enable palmas device for dalmore
Date: Tue, 09 Jul 2013 10:57:36 -0600 [thread overview]
Message-ID: <51DC4100.4050309@wwwdotorg.org> (raw)
In-Reply-To: <1373290688-2257-1-git-send-email-ldewangan@nvidia.com>
On 07/08/2013 07:38 AM, Laxman Dewangan wrote:
> Make the entry of Dalmore Power Management Unit device TPS65913
> in dalmore DTS file. The Palma driver support this device.
>
> Enable following submodule of the TPS65913:
> - GPIO driver
> - RTC driver.
> - Power regulator driver.
> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
> + palmas: tps65913@58 {
I assume there's only one TPS65913 in the system, so that node name
doesn't need to contain the unit address to make it unique; the node can
simply be named "tps65913".
> + palmas_gpio: palmas_gpio {
> + palmas_rtc {
> + palmas_pmic {
I don't think those node names need "palmas" in them; they can simply be
"gpio", "rtc", "pmic".
> + ldousb-in-supply = <&tps65090_dcdc1_reg>;
> + regulators {
You'd usually leave a blank line between properties and nodes.
> + vdd_cam_1v8_reg: regulator@6 {
...
> + gpio = <&palmas_gpio 6 0>; /* Palmas GPIO6 */
That comment probably isn't worthwhile; I only insisted on them for
Tegra GPIOs so that the GPIO name could be included somewhere, whereas
for devices with just a small handful of GPIOs without any other names,
there's no point putting a comment, since it's obvious from the cell
content.
next prev parent reply other threads:[~2013-07-09 16:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 13:38 [PATCH] ARM: tegra: enable palmas device for dalmore Laxman Dewangan
2013-07-08 13:38 ` Laxman Dewangan
2013-07-08 13:38 ` Laxman Dewangan
[not found] ` <1373290688-2257-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-09 16:57 ` Stephen Warren [this message]
2013-07-09 16:57 ` Stephen Warren
2013-07-09 16:57 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DC4100.4050309@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.