* [PATCH] ifb: fix rcu_sched self-detected stalls
@ 2013-07-10 4:04 Ding Tianhong
2013-07-11 1:44 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Ding Tianhong @ 2013-07-10 4:04 UTC (permalink / raw)
To: Eric Dumazet, David S. Miller, Patrick McHardy, Netdev
According to the commit 16b0dc29c1af9df341428f4c49ada4f626258082
(dummy: fix rcu_sched self-detected stalls)
Eric Dumazet fix the problem in dummy, but the ifb will occur the
same problem like the dummy modules.
Trying to "modprobe ifb numifbs=30000" triggers :
INFO: rcu_sched self-detected stall on CPU
After this splat, RTNL is locked and reboot is needed.
We must call cond_resched() to avoid this, even holding RTNL.
Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
---
drivers/net/ifb.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ifb.c b/drivers/net/ifb.c
index dc9f6a4..a11f7a4 100644
--- a/drivers/net/ifb.c
+++ b/drivers/net/ifb.c
@@ -292,8 +292,10 @@ static int __init ifb_init_module(void)
rtnl_lock();
err = __rtnl_link_register(&ifb_link_ops);
- for (i = 0; i < numifbs && !err; i++)
+ for (i = 0; i < numifbs && !err; i++) {
err = ifb_init_one(i);
+ cond_resched();
+ }
if (err)
__rtnl_link_unregister(&ifb_link_ops);
rtnl_unlock();
--
1.8.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ifb: fix rcu_sched self-detected stalls
2013-07-10 4:04 [PATCH] ifb: fix rcu_sched self-detected stalls Ding Tianhong
@ 2013-07-11 1:44 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-07-11 1:44 UTC (permalink / raw)
To: dingtianhong; +Cc: edumazet, kaber, netdev
From: Ding Tianhong <dingtianhong@huawei.com>
Date: Wed, 10 Jul 2013 12:04:02 +0800
> According to the commit 16b0dc29c1af9df341428f4c49ada4f626258082
> (dummy: fix rcu_sched self-detected stalls)
>
> Eric Dumazet fix the problem in dummy, but the ifb will occur the
> same problem like the dummy modules.
>
> Trying to "modprobe ifb numifbs=30000" triggers :
>
> INFO: rcu_sched self-detected stall on CPU
>
> After this splat, RTNL is locked and reboot is needed.
>
> We must call cond_resched() to avoid this, even holding RTNL.
>
> Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-11 1:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-10 4:04 [PATCH] ifb: fix rcu_sched self-detected stalls Ding Tianhong
2013-07-11 1:44 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.