From: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org"
<swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH V2] ARM: tegra: enable gpio-keys on dalmore
Date: Wed, 10 Jul 2013 12:33:51 +0530 [thread overview]
Message-ID: <51DD0757.8060406@nvidia.com> (raw)
In-Reply-To: <20130709060447.GA17499@mithrandir>
On Tuesday 09 July 2013 11:34 AM, Thierry Reding wrote:
> * PGP Signed by an unknown key
>
> On Sat, Jul 06, 2013 at 02:44:29PM +0530, Laxman Dewangan wrote:
>> D
>> +
>> + home {
>> + label = "Home";
>> + gpios = <&gpio TEGRA_GPIO(I, 5) GPIO_ACTIVE_LOW>;
>> + linux,code = <102>; /* KEY_HOME */
> I wonder if these should maybe go into a header file as well so that
> symbolic names can be used. That'll make the value self-descriptive and
> allow the comment to be dropped.
>
Currently there is no header for input.h in dt-binding include. We need
to add them first and then use it.
Probably it can be done along with all cleanups on dts file atleast for
Tegra.
I can start this if no one faster than me for this activity but for this
patch, I like to go on legacy way.
WARNING: multiple messages have this Message-ID (diff)
From: ldewangan@nvidia.com (Laxman Dewangan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] ARM: tegra: enable gpio-keys on dalmore
Date: Wed, 10 Jul 2013 12:33:51 +0530 [thread overview]
Message-ID: <51DD0757.8060406@nvidia.com> (raw)
In-Reply-To: <20130709060447.GA17499@mithrandir>
On Tuesday 09 July 2013 11:34 AM, Thierry Reding wrote:
> * PGP Signed by an unknown key
>
> On Sat, Jul 06, 2013 at 02:44:29PM +0530, Laxman Dewangan wrote:
>> D
>> +
>> + home {
>> + label = "Home";
>> + gpios = <&gpio TEGRA_GPIO(I, 5) GPIO_ACTIVE_LOW>;
>> + linux,code = <102>; /* KEY_HOME */
> I wonder if these should maybe go into a header file as well so that
> symbolic names can be used. That'll make the value self-descriptive and
> allow the comment to be dropped.
>
Currently there is no header for input.h in dt-binding include. We need
to add them first and then use it.
Probably it can be done along with all cleanups on dts file atleast for
Tegra.
I can start this if no one faster than me for this activity but for this
patch, I like to go on legacy way.
WARNING: multiple messages have this Message-ID (diff)
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: "swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] ARM: tegra: enable gpio-keys on dalmore
Date: Wed, 10 Jul 2013 12:33:51 +0530 [thread overview]
Message-ID: <51DD0757.8060406@nvidia.com> (raw)
In-Reply-To: <20130709060447.GA17499@mithrandir>
On Tuesday 09 July 2013 11:34 AM, Thierry Reding wrote:
> * PGP Signed by an unknown key
>
> On Sat, Jul 06, 2013 at 02:44:29PM +0530, Laxman Dewangan wrote:
>> D
>> +
>> + home {
>> + label = "Home";
>> + gpios = <&gpio TEGRA_GPIO(I, 5) GPIO_ACTIVE_LOW>;
>> + linux,code = <102>; /* KEY_HOME */
> I wonder if these should maybe go into a header file as well so that
> symbolic names can be used. That'll make the value self-descriptive and
> allow the comment to be dropped.
>
Currently there is no header for input.h in dt-binding include. We need
to add them first and then use it.
Probably it can be done along with all cleanups on dts file atleast for
Tegra.
I can start this if no one faster than me for this activity but for this
patch, I like to go on legacy way.
next prev parent reply other threads:[~2013-07-10 7:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-06 9:14 [PATCH V2] ARM: tegra: enable gpio-keys on dalmore Laxman Dewangan
2013-07-06 9:14 ` Laxman Dewangan
2013-07-06 9:14 ` Laxman Dewangan
2013-07-08 15:51 ` Stephen Warren
2013-07-08 15:51 ` Stephen Warren
[not found] ` <51DADFEC.1050901-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-07-08 17:12 ` Laxman Dewangan
2013-07-08 17:12 ` Laxman Dewangan
2013-07-08 17:12 ` Laxman Dewangan
[not found] ` <1373102069-5641-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-09 6:04 ` Thierry Reding
2013-07-09 6:04 ` Thierry Reding
2013-07-09 6:04 ` Thierry Reding
2013-07-10 7:03 ` Laxman Dewangan [this message]
2013-07-10 7:03 ` Laxman Dewangan
2013-07-10 7:03 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DD0757.8060406@nvidia.com \
--to=ldewangan-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.