From: Chen Gang <gang.chen@asianux.com>
To: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>, mpm@selenic.com, linux-mm@kvack.org
Subject: Re: [PATCH] mm/slub.c: beautify code of this file
Date: Mon, 15 Jul 2013 08:31:56 +0800 [thread overview]
Message-ID: <51E342FC.5060705@asianux.com> (raw)
In-Reply-To: <0000013fd32d0b91-4cab82b6-a24f-42e2-a1d2-ac5df2be6f4c-000000@email.amazonses.com>
On 07/12/2013 09:58 PM, Christoph Lameter wrote:
> On Fri, 12 Jul 2013, Chen Gang wrote:
>
>> Be sure of 80 column limitation for both code and comments.
>> Correct tab alignment for 'if-else' statement.
>
> Thanks.
>
Thank you too.
>> Remove redundancy 'break' statement.
>
> Hmm... I'd rather have the first break removed.
>
Yeah, that will be better for coding and understanding. I will send
patch v2 for it.
>> Remove useless BUG_ON(), since it can never happen.
>
> It may happen if more code is added to that function. Recently the cgroups
> thing was added f.e.
>
Hmm... at least what you said is reasonable. I need respect the related
maintainers' willing and opinions (e.g. you for "slub.c").
> Could you separate this out into multiple patches that each do one thing
> only?
>
OK, thanks. I will do.
Originally, I think these are minor, I should do with them in a patch,
so can save maintainers' time resource (now, I know it is incorrect).
:-)
Thanks.
--
Chen Gang
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-07-15 0:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 1:43 [PATCH] mm/slub.c: use 'unsigned long' instead of 'int' for variable 'slub_debug' Chen Gang
2013-07-12 3:27 ` [PATCH] mm/slub.c: beautify code of this file Chen Gang
2013-07-12 13:58 ` Christoph Lameter
2013-07-15 0:31 ` Chen Gang [this message]
2013-07-15 1:04 ` [PATCH 0/2] " Chen Gang
2013-07-15 1:05 ` [PATCH 1/2] mm/slub.c: beautify code for 80 column limitation and tab alignment Chen Gang
2013-07-15 14:19 ` Christoph Lameter
2013-07-16 0:55 ` Chen Gang
2013-07-15 1:06 ` [PATCH 2/2] mm/slub.c: beautify code for removing redundancy 'break' statement Chen Gang
2013-07-17 7:08 ` Pekka Enberg
2013-07-17 14:47 ` Christoph Lameter
2013-07-18 0:02 ` Chen Gang
2013-07-12 13:53 ` [PATCH] mm/slub.c: use 'unsigned long' instead of 'int' for variable 'slub_debug' Christoph Lameter
2013-07-15 0:19 ` Chen Gang
2013-07-15 14:17 ` Christoph Lameter
2013-07-16 0:53 ` Chen Gang
2013-07-17 14:46 ` Christoph Lameter
2013-07-18 0:13 ` Chen Gang
2013-07-18 13:42 ` Christoph Lameter
2013-07-19 0:50 ` Chen Gang F T
2013-07-19 14:00 ` Christoph Lameter
2013-07-22 1:19 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E342FC.5060705@asianux.com \
--to=gang.chen@asianux.com \
--cc=cl@linux.com \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.