From: Chen Gang <gang.chen@asianux.com>
To: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>, mpm@selenic.com, linux-mm@kvack.org
Subject: Re: [PATCH] mm/slub.c: use 'unsigned long' instead of 'int' for variable 'slub_debug'
Date: Thu, 18 Jul 2013 08:13:52 +0800 [thread overview]
Message-ID: <51E73340.5020703@asianux.com> (raw)
In-Reply-To: <0000013fed18f0f2-cb1afad0-560e-4da5-b865-29e854ce5813-000000@email.amazonses.com>
On 07/17/2013 10:46 PM, Christoph Lameter wrote:
> On Tue, 16 Jul 2013, Chen Gang wrote:
>
>> If we really use 32-bit as unsigned number, better to use 'U' instead of
>> 'UL' (e.g. 0x80000000U instead of 0x80000000UL).
>>
>> Since it is unsigned 32-bit number, it is better to use 'unsigned int'
>> instead of 'int', which can avoid related warnings if "EXTRA_CFLAGS=-W".
>
> Ok could you go through the kernel source and change that?
>
Yeah, thanks, I should do it.
Hmm... for each case of this issue, it need communicate with (review by)
various related maintainers.
So, I think one patch for one variable (and related macro contents) is
enough.
Is it OK ?
Thanks.
--
Chen Gang
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-07-18 0:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 1:43 [PATCH] mm/slub.c: use 'unsigned long' instead of 'int' for variable 'slub_debug' Chen Gang
2013-07-12 3:27 ` [PATCH] mm/slub.c: beautify code of this file Chen Gang
2013-07-12 13:58 ` Christoph Lameter
2013-07-15 0:31 ` Chen Gang
2013-07-15 1:04 ` [PATCH 0/2] " Chen Gang
2013-07-15 1:05 ` [PATCH 1/2] mm/slub.c: beautify code for 80 column limitation and tab alignment Chen Gang
2013-07-15 14:19 ` Christoph Lameter
2013-07-16 0:55 ` Chen Gang
2013-07-15 1:06 ` [PATCH 2/2] mm/slub.c: beautify code for removing redundancy 'break' statement Chen Gang
2013-07-17 7:08 ` Pekka Enberg
2013-07-17 14:47 ` Christoph Lameter
2013-07-18 0:02 ` Chen Gang
2013-07-12 13:53 ` [PATCH] mm/slub.c: use 'unsigned long' instead of 'int' for variable 'slub_debug' Christoph Lameter
2013-07-15 0:19 ` Chen Gang
2013-07-15 14:17 ` Christoph Lameter
2013-07-16 0:53 ` Chen Gang
2013-07-17 14:46 ` Christoph Lameter
2013-07-18 0:13 ` Chen Gang [this message]
2013-07-18 13:42 ` Christoph Lameter
2013-07-19 0:50 ` Chen Gang F T
2013-07-19 14:00 ` Christoph Lameter
2013-07-22 1:19 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E73340.5020703@asianux.com \
--to=gang.chen@asianux.com \
--cc=cl@linux.com \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.