From: "tiejun.chen" <tiejun.chen@windriver.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Scott Wood <scottwood@freescale.com>
Cc: Alexander Graf <agraf@suse.de>,
"<kvm-ppc@vger.kernel.org>" <kvm-ppc@vger.kernel.org>,
"<kvm@vger.kernel.org> list" <kvm@vger.kernel.org>
Subject: Re: [v1][PATCH 1/1] KVM: PPC: disable preemption when using hard_irq_disable()
Date: Mon, 15 Jul 2013 02:20:00 +0000 [thread overview]
Message-ID: <51E35C50.6050901@windriver.com> (raw)
In-Reply-To: <1373670311.19894.213.camel@pasglop>
On 07/13/2013 07:05 AM, Benjamin Herrenschmidt wrote:
> On Fri, 2013-07-12 at 12:50 -0500, Scott Wood wrote:
>>
>> [1] SOFT_DISABLE_INTS seems an odd name for something that updates the
>> software state to be consistent with interrupts being *hard* disabled.
>> I can sort of see the logic in it, but it's confusing when first
>> encountered. From the name it looks like all it would do is set
>> soft_enabled to 1.
>
> It's indeed odd. Also worse when we use DISABLE_INTS which is just a
> macro on top of SOFT_DISABLE_INTS :-)
>
> I've been wanting to change the macro name for a while now and never
> got to it. Patch welcome :-)
>
What about SOFT_IRQ_DISABLE? This is close to name hard_irq_disable() :) And
then remove all DISABLE_INTS as well?
Tiejun
WARNING: multiple messages have this Message-ID (diff)
From: "tiejun.chen" <tiejun.chen@windriver.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Scott Wood <scottwood@freescale.com>
Cc: Alexander Graf <agraf@suse.de>,
"<kvm-ppc@vger.kernel.org>" <kvm-ppc@vger.kernel.org>,
"<kvm@vger.kernel.org> list" <kvm@vger.kernel.org>
Subject: Re: [v1][PATCH 1/1] KVM: PPC: disable preemption when using hard_irq_disable()
Date: Mon, 15 Jul 2013 10:20:00 +0800 [thread overview]
Message-ID: <51E35C50.6050901@windriver.com> (raw)
In-Reply-To: <1373670311.19894.213.camel@pasglop>
On 07/13/2013 07:05 AM, Benjamin Herrenschmidt wrote:
> On Fri, 2013-07-12 at 12:50 -0500, Scott Wood wrote:
>>
>> [1] SOFT_DISABLE_INTS seems an odd name for something that updates the
>> software state to be consistent with interrupts being *hard* disabled.
>> I can sort of see the logic in it, but it's confusing when first
>> encountered. From the name it looks like all it would do is set
>> soft_enabled to 1.
>
> It's indeed odd. Also worse when we use DISABLE_INTS which is just a
> macro on top of SOFT_DISABLE_INTS :-)
>
> I've been wanting to change the macro name for a while now and never
> got to it. Patch welcome :-)
>
What about SOFT_IRQ_DISABLE? This is close to name hard_irq_disable() :) And
then remove all DISABLE_INTS as well?
Tiejun
next prev parent reply other threads:[~2013-07-15 2:20 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1373651433.8183.276@snotra>
2013-07-12 23:05 ` [v1][PATCH 1/1] KVM: PPC: disable preemption when using hard_irq_disable() Benjamin Herrenschmidt
2013-07-12 23:05 ` Benjamin Herrenschmidt
2013-07-15 2:20 ` tiejun.chen [this message]
2013-07-15 2:20 ` tiejun.chen
2013-07-15 2:47 ` Benjamin Herrenschmidt
2013-07-15 2:47 ` Benjamin Herrenschmidt
2013-07-15 3:03 ` tiejun.chen
2013-07-15 3:03 ` tiejun.chen
[not found] ` <1373909248.8183.303@snotra>
2013-07-16 2:15 ` tiejun.chen
2013-07-16 2:15 ` tiejun.chen
2013-07-15 2:25 ` tiejun.chen
2013-07-15 2:25 ` tiejun.chen
[not found] <1373559480.8183.258@snotra>
2013-07-12 0:30 ` Benjamin Herrenschmidt
2013-07-12 0:30 ` Benjamin Herrenschmidt
[not found] ` <FB21594A-C233-4A97-8503-E2A1275F8F17@suse.de>
[not found] ` <1373560585.8183.261@snotra>
2013-07-12 3:22 ` tiejun.chen
2013-07-12 3:22 ` tiejun.chen
2013-07-10 6:02 Tiejun Chen
2013-07-10 6:02 ` Tiejun Chen
2013-07-10 9:49 ` Alexander Graf
2013-07-10 9:49 ` Alexander Graf
2013-07-11 2:48 ` tiejun.chen
2013-07-11 2:48 ` tiejun.chen
2013-07-11 9:49 ` Alexander Graf
2013-07-11 9:49 ` Alexander Graf
2013-07-11 12:28 ` Benjamin Herrenschmidt
2013-07-11 12:28 ` Benjamin Herrenschmidt
2013-07-11 12:47 ` Alexander Graf
2013-07-11 12:47 ` Alexander Graf
2013-07-11 12:54 ` Benjamin Herrenschmidt
2013-07-11 12:54 ` Benjamin Herrenschmidt
2013-07-11 13:07 ` Alexander Graf
2013-07-11 13:07 ` Alexander Graf
2013-07-12 0:19 ` Benjamin Herrenschmidt
2013-07-12 0:19 ` Benjamin Herrenschmidt
2013-07-12 2:13 ` tiejun.chen
2013-07-12 2:13 ` tiejun.chen
2013-07-12 3:57 ` Benjamin Herrenschmidt
2013-07-12 3:57 ` Benjamin Herrenschmidt
2013-07-12 4:54 ` tiejun.chen
2013-07-12 4:54 ` tiejun.chen
2013-07-14 4:13 ` Benjamin Herrenschmidt
2013-07-14 4:13 ` Benjamin Herrenschmidt
2013-07-15 3:04 ` tiejun.chen
2013-07-15 3:04 ` tiejun.chen
2013-07-10 19:15 ` Scott Wood
2013-07-10 19:15 ` Scott Wood
2013-07-10 19:15 ` Scott Wood
2013-07-11 2:59 ` tiejun.chen
2013-07-11 3:00 ` tiejun.chen
2013-07-11 3:00 ` tiejun.chen
2013-07-11 14:13 ` Scott Wood
2013-07-11 14:13 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E35C50.6050901@windriver.com \
--to=tiejun.chen@windriver.com \
--cc=agraf@suse.de \
--cc=benh@kernel.crashing.org \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.