Re: [Qemu-devel] [PATCH V2 0/1] ARM aarch64 TCG tlb fast lookup

[Claudio Fontana <claudio.fontana@huawei.com>]

On 10.07.2013 16:48, Jani Kokkonen wrote:
> 
> This patch implements the TCG tlb fast lookup in 
> tcg_out_qemu_ld/st for the aarch64 TCG target.  
> Supports also CONFIG_QEMU_LDST_OPTIMIZATION.
> 
> Tested running on a x86-64 physical machine running Foundation v8,
> running a linux 3.2.0 minimal host system based on linaro v8
> image build 0.8.4423 for user space.
> 
> Tested guests: arm v5, PPC64, sparc, i386 linux test images.
> Also tested on x86-64/linux built with buildroot.
> 
> Changes in v2:
> -Fix whitespace and indentation
> -Pass mem_index into tcg_out_tlb_read() and calculate tlb_offset inside  
>  tcg_out_tlb_read() 
> -Add comments in tcg_out_tlb_read() 
> -Change parameter type from int to TCGREg for data_reg and addr_reg parameters
>  in add_qemu_ldst_label()
> -Use extended register for tcg_out_cmp() in tcg_out_tlb_read() only if needed  
>   
> 
> Jani Kokkonen (1):
>   tcg/aarch64: Implement tlb lookup fast path
> 
>  configure                |    2 +-
>  include/exec/exec-all.h  |   14 +++
>  tcg/aarch64/tcg-target.c |  224 +++++++++++++++++++++++++++++++++++-----------
>  3 files changed, 189 insertions(+), 51 deletions(-)
> 

It's good for me, thank you Jani.

Reviewed-by: Claudio Fontana <claudio.fontana@huawei.com>