* [PATCH] ASoC: omap: Enable COMPILE_TEST build for DT platforms
@ 2013-07-15 15:57 Mark Brown
2013-07-15 16:00 ` Felipe Balbi
2013-07-15 16:43 ` Peter Ujfalusi
0 siblings, 2 replies; 6+ messages in thread
From: Mark Brown @ 2013-07-15 15:57 UTC (permalink / raw)
To: Liam Girdwood, Peter Ujfalusi, Jarkko Nikula
Cc: alsa-devel, linux-omap, Mark Brown
From: Mark Brown <broonie@linaro.org>
The DT platforms don't have any source dependency on any OMAP stuff so
allow them to be built when COMPILE_TEST is enabled.
Signed-off-by: Mark Brown <broonie@linaro.org>
---
sound/soc/omap/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/omap/Kconfig b/sound/soc/omap/Kconfig
index 9f5d55e..68dfc0a 100644
--- a/sound/soc/omap/Kconfig
+++ b/sound/soc/omap/Kconfig
@@ -1,6 +1,6 @@
config SND_OMAP_SOC
tristate "SoC Audio for the Texas Instruments OMAP chips"
- depends on ARCH_OMAP && DMA_OMAP
+ depends on (ARCH_OMAP && DMA_OMAP) || COMPILE_TEST
select SND_SOC_DMAENGINE_PCM
config SND_OMAP_SOC_DMIC
@@ -26,7 +26,7 @@ config SND_OMAP_SOC_N810
config SND_OMAP_SOC_RX51
tristate "SoC Audio support for Nokia RX-51"
- depends on SND_OMAP_SOC && MACH_NOKIA_RX51
+ depends on SND_OMAP_SOC && (MACH_NOKIA_RX51 || COMPILE_TEST)
select SND_OMAP_SOC_MCBSP
select SND_SOC_TLV320AIC3X
select SND_SOC_TPA6130A2
@@ -87,7 +87,7 @@ config SND_OMAP_SOC_OMAP_TWL4030
config SND_OMAP_SOC_OMAP_ABE_TWL6040
tristate "SoC Audio support for OMAP boards using ABE and twl6040 codec"
- depends on TWL6040_CORE && SND_OMAP_SOC && ARCH_OMAP4
+ depends on TWL6040_CORE && SND_OMAP_SOC && (ARCH_OMAP4 || COMPILE_TEST)
select SND_OMAP_SOC_DMIC
select SND_OMAP_SOC_MCPDM
select SND_SOC_TWL6040
--
1.8.3.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: omap: Enable COMPILE_TEST build for DT platforms
2013-07-15 15:57 [PATCH] ASoC: omap: Enable COMPILE_TEST build for DT platforms Mark Brown
@ 2013-07-15 16:00 ` Felipe Balbi
2013-07-15 16:26 ` Mark Brown
2013-07-15 16:43 ` Peter Ujfalusi
1 sibling, 1 reply; 6+ messages in thread
From: Felipe Balbi @ 2013-07-15 16:00 UTC (permalink / raw)
To: Mark Brown
Cc: Liam Girdwood, Peter Ujfalusi, Jarkko Nikula, alsa-devel,
linux-omap, Mark Brown
[-- Attachment #1: Type: text/plain, Size: 418 bytes --]
Hi,
On Mon, Jul 15, 2013 at 04:57:56PM +0100, Mark Brown wrote:
> @@ -26,7 +26,7 @@ config SND_OMAP_SOC_N810
>
> config SND_OMAP_SOC_RX51
> tristate "SoC Audio support for Nokia RX-51"
> - depends on SND_OMAP_SOC && MACH_NOKIA_RX51
> + depends on SND_OMAP_SOC && (MACH_NOKIA_RX51 || COMPILE_TEST)
RX51 is OMAP3, and that's DT at all. This is likely just a case of
updating commit log.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: omap: Enable COMPILE_TEST build for DT platforms
2013-07-15 16:00 ` Felipe Balbi
@ 2013-07-15 16:26 ` Mark Brown
2013-07-15 16:32 ` Felipe Balbi
0 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2013-07-15 16:26 UTC (permalink / raw)
To: Felipe Balbi
Cc: Liam Girdwood, Peter Ujfalusi, Jarkko Nikula, alsa-devel,
linux-omap
[-- Attachment #1: Type: text/plain, Size: 715 bytes --]
On Mon, Jul 15, 2013 at 07:00:45PM +0300, Felipe Balbi wrote:
> On Mon, Jul 15, 2013 at 04:57:56PM +0100, Mark Brown wrote:
> > @@ -26,7 +26,7 @@ config SND_OMAP_SOC_N810
> > config SND_OMAP_SOC_RX51
> > tristate "SoC Audio support for Nokia RX-51"
> > - depends on SND_OMAP_SOC && MACH_NOKIA_RX51
> > + depends on SND_OMAP_SOC && (MACH_NOKIA_RX51 || COMPILE_TEST)
> RX51 is OMAP3, and that's DT at all. This is likely just a case of
> updating commit log.
Sentence parse grammar not.
However... if you look at the driver it actually does have DT support
in there, it checks for the machine type or for compatibility with n900.
Probably needs an ARM dependency which I'll add due to the machine type
check.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: omap: Enable COMPILE_TEST build for DT platforms
2013-07-15 16:26 ` Mark Brown
@ 2013-07-15 16:32 ` Felipe Balbi
0 siblings, 0 replies; 6+ messages in thread
From: Felipe Balbi @ 2013-07-15 16:32 UTC (permalink / raw)
To: Mark Brown
Cc: alsa-devel, Liam Girdwood, Felipe Balbi, Peter Ujfalusi,
linux-omap, Jarkko Nikula
[-- Attachment #1.1: Type: text/plain, Size: 905 bytes --]
On Mon, Jul 15, 2013 at 05:26:05PM +0100, Mark Brown wrote:
> On Mon, Jul 15, 2013 at 07:00:45PM +0300, Felipe Balbi wrote:
> > On Mon, Jul 15, 2013 at 04:57:56PM +0100, Mark Brown wrote:
> > > @@ -26,7 +26,7 @@ config SND_OMAP_SOC_N810
>
> > > config SND_OMAP_SOC_RX51
> > > tristate "SoC Audio support for Nokia RX-51"
> > > - depends on SND_OMAP_SOC && MACH_NOKIA_RX51
> > > + depends on SND_OMAP_SOC && (MACH_NOKIA_RX51 || COMPILE_TEST)
>
> > RX51 is OMAP3, and that's DT at all. This is likely just a case of
^
not
> > updating commit log.
>
> Sentence parse grammar not.
>
> However... if you look at the driver it actually does have DT support
> in there, it checks for the machine type or for compatibility with n900.
> Probably needs an ARM dependency which I'll add due to the machine type
> check.
alright.
--
balbi
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: omap: Enable COMPILE_TEST build for DT platforms
2013-07-15 15:57 [PATCH] ASoC: omap: Enable COMPILE_TEST build for DT platforms Mark Brown
2013-07-15 16:00 ` Felipe Balbi
@ 2013-07-15 16:43 ` Peter Ujfalusi
2013-07-15 17:03 ` Mark Brown
1 sibling, 1 reply; 6+ messages in thread
From: Peter Ujfalusi @ 2013-07-15 16:43 UTC (permalink / raw)
To: Mark Brown
Cc: alsa-devel, linux-omap, Liam Girdwood, Jarkko Nikula, Mark Brown
Hi Mark,
On 07/15/2013 05:57 PM, Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
>
> The DT platforms don't have any source dependency on any OMAP stuff so
> allow them to be built when COMPILE_TEST is enabled.
The OMAP3 generic machine driver could be also included in this patch:
SND_OMAP_SOC_OMAP_TWL4030
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
Otherwise:
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> sound/soc/omap/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/omap/Kconfig b/sound/soc/omap/Kconfig
> index 9f5d55e..68dfc0a 100644
> --- a/sound/soc/omap/Kconfig
> +++ b/sound/soc/omap/Kconfig
> @@ -1,6 +1,6 @@
> config SND_OMAP_SOC
> tristate "SoC Audio for the Texas Instruments OMAP chips"
> - depends on ARCH_OMAP && DMA_OMAP
> + depends on (ARCH_OMAP && DMA_OMAP) || COMPILE_TEST
> select SND_SOC_DMAENGINE_PCM
>
> config SND_OMAP_SOC_DMIC
> @@ -26,7 +26,7 @@ config SND_OMAP_SOC_N810
>
> config SND_OMAP_SOC_RX51
> tristate "SoC Audio support for Nokia RX-51"
> - depends on SND_OMAP_SOC && MACH_NOKIA_RX51
> + depends on SND_OMAP_SOC && (MACH_NOKIA_RX51 || COMPILE_TEST)
> select SND_OMAP_SOC_MCBSP
> select SND_SOC_TLV320AIC3X
> select SND_SOC_TPA6130A2
> @@ -87,7 +87,7 @@ config SND_OMAP_SOC_OMAP_TWL4030
>
> config SND_OMAP_SOC_OMAP_ABE_TWL6040
> tristate "SoC Audio support for OMAP boards using ABE and twl6040 codec"
> - depends on TWL6040_CORE && SND_OMAP_SOC && ARCH_OMAP4
> + depends on TWL6040_CORE && SND_OMAP_SOC && (ARCH_OMAP4 || COMPILE_TEST)
> select SND_OMAP_SOC_DMIC
> select SND_OMAP_SOC_MCPDM
> select SND_SOC_TWL6040
>
--
Péter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: omap: Enable COMPILE_TEST build for DT platforms
2013-07-15 16:43 ` Peter Ujfalusi
@ 2013-07-15 17:03 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2013-07-15 17:03 UTC (permalink / raw)
To: Peter Ujfalusi; +Cc: alsa-devel, linux-omap, Liam Girdwood, Jarkko Nikula
[-- Attachment #1.1: Type: text/plain, Size: 541 bytes --]
On Mon, Jul 15, 2013 at 06:43:46PM +0200, Peter Ujfalusi wrote:
> On 07/15/2013 05:57 PM, Mark Brown wrote:
> > From: Mark Brown <broonie@linaro.org>
> > The DT platforms don't have any source dependency on any OMAP stuff so
> > allow them to be built when COMPILE_TEST is enabled.
> The OMAP3 generic machine driver could be also included in this patch:
> SND_OMAP_SOC_OMAP_TWL4030
There's no need for that - it has no dependencies other than the TWL4030
core driver and SND_OMAP_SOC so as soon as SND_OMAP_SOC can be enabled
it is too.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-07-15 17:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-15 15:57 [PATCH] ASoC: omap: Enable COMPILE_TEST build for DT platforms Mark Brown
2013-07-15 16:00 ` Felipe Balbi
2013-07-15 16:26 ` Mark Brown
2013-07-15 16:32 ` Felipe Balbi
2013-07-15 16:43 ` Peter Ujfalusi
2013-07-15 17:03 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.