All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Toralf Förster" <toralf.foerster@gmx.de>
To: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
Cc: Linux NFS mailing list <linux-nfs@vger.kernel.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	"user-mode-linux-devel@lists.sourceforge.net"
	<user-mode-linux-devel@lists.sourceforge.net>
Subject: Re: sunrpc/clnt.c: BUG kmalloc-256 (Not tainted): Poison overwritten
Date: Mon, 15 Jul 2013 18:54:27 +0200	[thread overview]
Message-ID: <51E42943.8040001@gmx.de> (raw)
In-Reply-To: <1373857286.3181.1.camel@leira.trondhjem.org>

On 07/15/2013 05:01 AM, Myklebust, Trond wrote:
> On Sun, 2013-07-14 at 10:02 +0200, Toralf Förster wrote:
>> This bisected commit produces at a 32 bit user mode linux guest the attached BUG :
>>
>> commit eeee245268c951262b861bc1be4e9dc812352499
>> Author: Trond Myklebust <Trond.Myklebust@netapp.com>
>> Date:   Wed Jul 10 15:33:01 2013 -0400
>>
>>     SUNRPC: Fix a deadlock in rpc_client_register()
>>
>>     Commit 384816051ca9125cd54750e59c780c2a2655fa4f (SUNRPC: fix races on
>>     PipeFS MOUNT notifications) introduces a regression when we call
>>     rpc_setup_pipedir() with RPCSEC_GSS as the auth flavour.
>>
>>     By calling rpcauth_create() while holding the sn->pipefs_sb_lock, we
>>     end up deadlocking in gss_pipes_dentries_create_net().
>>     Fix is to register the client and release the mutex before calling
>>     rpcauth_create().
>>
>>     Reported-by: Weston Andros Adamson <dros@netapp.com>
>>     Tested-by: Weston Andros Adamson <dros@netapp.com>
>>     Cc: Stanislav Kinsbursky <skinsbursky@parallels.com>
>>     Cc: <stable@vger.kernel.org> # : 3848160: SUNRPC: fix races on PipeFS MOUNT
>>     Cc: <stable@vger.kernel.org> # : e73f4cc: SUNRPC: split client creation
>>     Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
>>
>>
>>
>>
>>
>>
>> 2013-07-13T22:09:07.000+02:00 trinity sm-notify[1042]: Version 1.2.6 starting
>> 2013-07-13T22:09:07.000+02:00 trinity sm-notify[1042]: Backgrounding to notify hosts...
>> 2013-07-13T22:09:07.000+02:00 trinity sm-notify[1043]: Running as root.  chown /var/lib/nfs to choose different user
>> 2013-07-13T22:09:10.000+02:00 trinity mount[1047]: mount to NFS server 'n22stab4' failed: No route to host, retrying
>> 2013-07-13T22:09:11.000+02:00 trinity dhcpcd[971]: eth0: sending IPv6 Router Solicitation
>> 2013-07-13T22:09:11.000+02:00 trinity dhcpcd[971]: eth0: no IPv6 Routers available
>> 2013-07-13T22:09:13.000+02:00 trinity mount[1048]: mount to NFS server 'n22stab4' failed: No route to host, retrying
>> 2013-07-13T22:09:13.647+02:00 trinity kernel: =============================================================================
>> 2013-07-13T22:09:13.647+02:00 trinity kernel: BUG kmalloc-256 (Not tainted): Poison overwritten
>> 2013-07-13T22:09:13.647+02:00 trinity kernel: -----------------------------------------------------------------------------

<snip>

>> 2013-07-13T22:09:13.647+02:00 trinity kernel:

> Does the attached patch fix the problem?

Yes.

And it solves another related problem too : a soft lookup of CPU0 during
shutdown of the UML guest

:-)



-- 
MfG/Sincerely
Toralf Förster
pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3

WARNING: multiple messages have this Message-ID (diff)
From: "Toralf Förster" <toralf.foerster@gmx.de>
To: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
Cc: Linux NFS mailing list <linux-nfs@vger.kernel.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	"user-mode-linux-devel@lists.sourceforge.net"
	<user-mode-linux-devel@lists.sourceforge.net>
Subject: Re: sunrpc/clnt.c: BUG kmalloc-256 (Not tainted): Poison overwritten
Date: Mon, 15 Jul 2013 18:54:27 +0200	[thread overview]
Message-ID: <51E42943.8040001@gmx.de> (raw)
In-Reply-To: <1373857286.3181.1.camel@leira.trondhjem.org>

On 07/15/2013 05:01 AM, Myklebust, Trond wrote:
> On Sun, 2013-07-14 at 10:02 +0200, Toralf Förster wrote:
>> This bisected commit produces at a 32 bit user mode linux guest the attached BUG :
>>
>> commit eeee245268c951262b861bc1be4e9dc812352499
>> Author: Trond Myklebust <Trond.Myklebust@netapp.com>
>> Date:   Wed Jul 10 15:33:01 2013 -0400
>>
>>     SUNRPC: Fix a deadlock in rpc_client_register()
>>
>>     Commit 384816051ca9125cd54750e59c780c2a2655fa4f (SUNRPC: fix races on
>>     PipeFS MOUNT notifications) introduces a regression when we call
>>     rpc_setup_pipedir() with RPCSEC_GSS as the auth flavour.
>>
>>     By calling rpcauth_create() while holding the sn->pipefs_sb_lock, we
>>     end up deadlocking in gss_pipes_dentries_create_net().
>>     Fix is to register the client and release the mutex before calling
>>     rpcauth_create().
>>
>>     Reported-by: Weston Andros Adamson <dros@netapp.com>
>>     Tested-by: Weston Andros Adamson <dros@netapp.com>
>>     Cc: Stanislav Kinsbursky <skinsbursky@parallels.com>
>>     Cc: <stable@vger.kernel.org> # : 3848160: SUNRPC: fix races on PipeFS MOUNT
>>     Cc: <stable@vger.kernel.org> # : e73f4cc: SUNRPC: split client creation
>>     Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
>>
>>
>>
>>
>>
>>
>> 2013-07-13T22:09:07.000+02:00 trinity sm-notify[1042]: Version 1.2.6 starting
>> 2013-07-13T22:09:07.000+02:00 trinity sm-notify[1042]: Backgrounding to notify hosts...
>> 2013-07-13T22:09:07.000+02:00 trinity sm-notify[1043]: Running as root.  chown /var/lib/nfs to choose different user
>> 2013-07-13T22:09:10.000+02:00 trinity mount[1047]: mount to NFS server 'n22stab4' failed: No route to host, retrying
>> 2013-07-13T22:09:11.000+02:00 trinity dhcpcd[971]: eth0: sending IPv6 Router Solicitation
>> 2013-07-13T22:09:11.000+02:00 trinity dhcpcd[971]: eth0: no IPv6 Routers available
>> 2013-07-13T22:09:13.000+02:00 trinity mount[1048]: mount to NFS server 'n22stab4' failed: No route to host, retrying
>> 2013-07-13T22:09:13.647+02:00 trinity kernel: =============================================================================
>> 2013-07-13T22:09:13.647+02:00 trinity kernel: BUG kmalloc-256 (Not tainted): Poison overwritten
>> 2013-07-13T22:09:13.647+02:00 trinity kernel: -----------------------------------------------------------------------------

<snip>

>> 2013-07-13T22:09:13.647+02:00 trinity kernel:

> Does the attached patch fix the problem?

Yes.

And it solves another related problem too : a soft lookup of CPU0 during
shutdown of the UML guest

:-)



-- 
MfG/Sincerely
Toralf Förster
pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


  reply	other threads:[~2013-07-15 16:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-14  8:02 sunrpc/clnt.c: BUG kmalloc-256 (Not tainted): Poison overwritten Toralf Förster
2013-07-14  8:02 ` Toralf Förster
2013-07-15  3:01 ` Myklebust, Trond
2013-07-15 16:54   ` Toralf Förster [this message]
2013-07-15 16:54     ` Toralf Förster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E42943.8040001@gmx.de \
    --to=toralf.foerster@gmx.de \
    --cc=Trond.Myklebust@netapp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.