All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huang Shijie <b32955@freescale.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: gregkh@linuxfoundation.org, shawn.guo@linaro.org,
	linux-serial@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] serial: mxs: enable the DMA only when the rts/cts is enabled
Date: Tue, 16 Jul 2013 16:11:19 +0800	[thread overview]
Message-ID: <51E50027.4020701@freescale.com> (raw)
In-Reply-To: <20130716073305.GP12139@pengutronix.de>

于 2013年07月16日 15:33, Uwe Kleine-König 写道:
>> This patch depends on the first patch. :)
> But it's not a hard dependency.
>
do you mean i should merge the patch 1 and patch 2 into a single patch?

>>> Something like:
>>>
>>> 	serial: mxs-auart: DMA unreliable without RTS/CTS
>>>
>>> 	According to [add some document name here] DMA doesn't work
>>> 	reliable without hardware handshaking. So make DMA dependant on
>>>   
>> Please see the spec about the RTSEN and RTS.
> Right, it's not hard for me. Other might not have the manual handy, so
> a comment telling:
>
>> RTSEN enable the flow control by the hardware;
>> RTS enable the flow control by the software.
> would be nice.
i think we need another patch to add this comment.

thanks
Huang Shijie

--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: b32955@freescale.com (Huang Shijie)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] serial: mxs: enable the DMA only when the rts/cts is enabled
Date: Tue, 16 Jul 2013 16:11:19 +0800	[thread overview]
Message-ID: <51E50027.4020701@freescale.com> (raw)
In-Reply-To: <20130716073305.GP12139@pengutronix.de>

? 2013?07?16? 15:33, Uwe Kleine-K?nig ??:
>> This patch depends on the first patch. :)
> But it's not a hard dependency.
>
do you mean i should merge the patch 1 and patch 2 into a single patch?

>>> Something like:
>>>
>>> 	serial: mxs-auart: DMA unreliable without RTS/CTS
>>>
>>> 	According to [add some document name here] DMA doesn't work
>>> 	reliable without hardware handshaking. So make DMA dependant on
>>>   
>> Please see the spec about the RTSEN and RTS.
> Right, it's not hard for me. Other might not have the manual handy, so
> a comment telling:
>
>> RTSEN enable the flow control by the hardware;
>> RTS enable the flow control by the software.
> would be nice.
i think we need another patch to add this comment.

thanks
Huang Shijie

  reply	other threads:[~2013-07-16  8:07 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-15  3:08 [PATCH 1/3] serial: mxs: remove the unused macro Huang Shijie
2013-07-15  3:08 ` Huang Shijie
2013-07-15  3:08 ` [PATCH 2/3] serial: mxs: enable the DMA only when the rts/cts is enabled Huang Shijie
2013-07-15  3:08   ` Huang Shijie
2013-07-15  8:27   ` Uwe Kleine-König
2013-07-15  8:27     ` Uwe Kleine-König
2013-07-15  8:41     ` Huang Shijie
2013-07-15  8:41       ` Huang Shijie
2013-07-15  9:07       ` Uwe Kleine-König
2013-07-15  9:07         ` Uwe Kleine-König
2013-07-15 10:53         ` Huang Shijie
2013-07-15 10:53           ` Huang Shijie
2013-07-16  7:33           ` Uwe Kleine-König
2013-07-16  7:33             ` Uwe Kleine-König
2013-07-16  8:11             ` Huang Shijie [this message]
2013-07-16  8:11               ` Huang Shijie
2013-07-15  3:08 ` [PATCH 3/3] ARM: dts: imx28-evk: add the rts/cts property for auart0 Huang Shijie
2013-07-15  3:08   ` Huang Shijie
2013-07-15  8:20 ` [PATCH 1/3] serial: mxs: remove the unused macro Uwe Kleine-König
2013-07-15  8:20   ` Uwe Kleine-König
2013-07-15  8:30   ` Huang Shijie
2013-07-15  8:30     ` Huang Shijie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E50027.4020701@freescale.com \
    --to=b32955@freescale.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=shawn.guo@linaro.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.