From: Paolo Bonzini <pbonzini@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] memory: Return -1 again on reads from unsigned regions
Date: Tue, 16 Jul 2013 14:47:33 +0200 [thread overview]
Message-ID: <51E540E5.1040004@redhat.com> (raw)
In-Reply-To: <51E5405C.6080108@siemens.com>
Il 16/07/2013 14:45, Jan Kiszka ha scritto:
> This restore the behavior prior to b018ddf633 which accidentally changed
> the return code to 0. Specifically guests probing for register existence
> were affected by this.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> memory.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/memory.c b/memory.c
> index 757e9a5..d19b61b 100644
> --- a/memory.c
> +++ b/memory.c
> @@ -859,7 +859,7 @@ static uint64_t unassigned_mem_read(void *opaque, hwaddr addr,
> cpu_unassigned_access(ENV_GET_CPU(cpu_single_env),
> addr, false, false, 0, size);
> }
> - return 0;
> + return -1ULL;
> }
>
> static void unassigned_mem_write(void *opaque, hwaddr addr,
>
Applied, thanks.
Paolo
next prev parent reply other threads:[~2013-07-16 12:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 12:45 [Qemu-devel] [PATCH] memory: Return -1 again on reads from unsigned regions Jan Kiszka
2013-07-16 12:47 ` Paolo Bonzini [this message]
2013-07-17 2:00 ` Stefan Hajnoczi
2013-08-08 15:13 ` Peter Maydell
2013-08-08 15:31 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E540E5.1040004@redhat.com \
--to=pbonzini@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.